From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C38C646CE9
	for <public@inbox.dpdk.org>; Thu,  7 Aug 2025 19:36:58 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BC73940270;
	Thu,  7 Aug 2025 19:36:58 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 95FA9402CE
 for <test-report@dpdk.org>; Thu,  7 Aug 2025 19:36:57 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 0765512522F; Thu,  7 Aug 2025 19:34:53 +0200 (CEST)
Subject: |WARNING| pw155730 [PATCH v10 09/14] ethdev: add port mirroring
 feature
In-Reply-To: <20250807173437.11442-10-stephen@networkplumber.org>
References: <20250807173437.11442-10-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20250807173453.0765512522F@dpdk.org>
Date: Thu,  7 Aug 2025 19:34:53 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155730

_coding style issues_


WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#141: FILE: app/test/test_ethdev_mirror.c:6:
+#include <stdio.h>

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#498: FILE: lib/ethdev/ethdev_private.c:292:
+	fpo->rx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->rx_mirror;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#499: FILE: lib/ethdev/ethdev_private.c:293:
+	fpo->tx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->tx_mirror;

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#785: FILE: lib/ethdev/rte_ethdev_core.h:111:
+	RTE_ATOMIC(struct rte_eth_mirror *) *rx_mirror;
 	                                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#794: FILE: lib/ethdev/rte_ethdev_core.h:131:
+	RTE_ATOMIC(struct rte_eth_mirror *) *tx_mirror;
 	                                    ^

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#813: FILE: lib/ethdev/rte_mirror.c:9:
+#include <stdio.h>

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#925: FILE: lib/ethdev/rte_mirror.c:121:
+ethdev_insert_mirror(RTE_ATOMIC(struct rte_eth_mirror *) *top,
                                                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1079: FILE: lib/ethdev/rte_mirror.c:275:
+ethdev_find_mirror(RTE_ATOMIC(struct rte_eth_mirror *) *head, uint16_t target_id)
                                                        ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1096: FILE: lib/ethdev/rte_mirror.c:292:
+ethdev_delete_mirror(RTE_ATOMIC(struct rte_eth_mirror *) *top, uint16_t target_id)
                                                          ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1240: FILE: lib/ethdev/rte_mirror.c:436:
+ethdev_mirror_stats_get(RTE_ATOMIC(struct rte_eth_mirror *) *head, uint16_t target_id,
                                                             ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#1279: FILE: lib/ethdev/rte_mirror.c:475:
+ethdev_mirror_stats_reset(RTE_ATOMIC(struct rte_eth_mirror *) *head, uint16_t target_id)
                                                               ^

total: 9 errors, 2 warnings, 1259 lines checked