From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3110A46F4A for ; Mon, 22 Sep 2025 09:32:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B155402EF; Mon, 22 Sep 2025 09:32:27 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 5D201402EF for ; Mon, 22 Sep 2025 09:32:26 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 9DC5F12421D; Mon, 22 Sep 2025 09:29:26 +0200 (CEST) Subject: |WARNING| pw156805 [PATCH] net/tap: fix build with LTO In-Reply-To: <20250922073043.2394557-1-david.marchand@redhat.com> References: <20250922073043.2394557-1-david.marchand@redhat.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: David Marchand Message-Id: <20250922072926.9DC5F12421D@dpdk.org> Date: Mon, 22 Sep 2025 09:29:26 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/156805 _coding style issues_ ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #403: FILE: drivers/net/tap/tap_netlink.h:26: +#define NLMSG_TAIL(msg) (void *)((char *)(msg) + NLMSG_ALIGN((msg)->nh.nlmsg_len)) BUT SEE: do {} while (0) advice is over-stated in a few situations: The more obvious case is macros, like MODULE_PARM_DESC, invoked at file-scope, where C disallows code (it must be in functions). See $exceptions if you have one to add by name. More troublesome is declarative macros used at top of new scope, like DECLARE_PER_CPU. These might just compile with a do-while-0 wrapper, but would be incorrect. Most of these are handled by detecting struct,union,etc declaration primitives in $exceptions. Theres also macros called inside an if (block), which "return" an expression. These cannot do-while, and need a ({}) wrapper. Enjoy this qualification while we work to improve our heuristics. CHECK:MACRO_ARG_REUSE: Macro argument reuse 'msg' - possible side-effects? #403: FILE: drivers/net/tap/tap_netlink.h:26: +#define NLMSG_TAIL(msg) (void *)((char *)(msg) + NLMSG_ALIGN((msg)->nh.nlmsg_len)) total: 1 errors, 0 warnings, 1 checks, 319 lines checked