|WARNING| pw126719 [PATCH] [v2] net/mana: suppress TX CQE generation whenever possible

[dpdklab@iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/126719

_apply patch failure_

Submitter: Long Li <longli@linuxonhyperv.com>
Date: Saturday, May 06 2023 01:32:47 
Applied on: CommitID:d03446724972d2a1bb645ce7f3e64f5ef0203d61
Apply patch set 126719 failed:

Checking patch drivers/net/mana/mana.h...
Hunk #1 succeeded at 366 (offset 13 lines).
Hunk #2 succeeded at 409 (offset 7 lines).
Checking patch drivers/net/mana/tx.c...
error: while searching for:
	int ret;
	void *db_page;
	uint16_t pkt_sent = 0;
	uint32_t num_comp;

	/* Process send completions from GDMA */
	num_comp = gdma_poll_completion_queue(&txq->gdma_cq,
			txq->gdma_comp_buf, txq->num_desc);

	for (uint32_t i = 0; i < num_comp; i++) {
		struct mana_txq_desc *desc =
			&txq->desc_ring[txq->desc_ring_tail];
		struct mana_tx_comp_oob *oob = (struct mana_tx_comp_oob *)

error: patch failed: drivers/net/mana/tx.c:173
Hunk #3 succeeded at 203 (offset -4 lines).
error: while searching for:
		struct one_sgl sgl;
		uint16_t seg_idx;

		/* Drop the packet if it exceeds max segments */
		if (m_pkt->nb_segs > priv->max_send_sge) {
			DP_LOG(ERR, "send packet segments %d exceeding max",

error: patch failed: drivers/net/mana/tx.c:215
error: while searching for:
			tx_oob.short_oob.tx_compute_UDP_checksum = 0;
		}

		tx_oob.short_oob.suppress_tx_CQE_generation = 0;
		tx_oob.short_oob.VCQ_number = txq->gdma_cq.id;

		tx_oob.short_oob.VSQ_frame_num =

error: patch failed: drivers/net/mana/tx.c:310
error: while searching for:
		if (seg_idx != m_pkt->nb_segs)
			continue;

		struct gdma_work_request work_req;
		uint32_t wqe_size_in_bu;


error: patch failed: drivers/net/mana/tx.c:362
error: while searching for:
			/* Update queue for tracking pending requests */
			desc->pkt = m_pkt;
			desc->wqe_size_in_bu = wqe_size_in_bu;
			txq->desc_ring_head =
				(txq->desc_ring_head + 1) % txq->num_desc;

			pkt_sent++;


error: patch failed: drivers/net/mana/tx.c:384
Applied patch drivers/net/mana/mana.h cleanly.
Applying patch drivers/net/mana/tx.c with 5 rejects...
Hunk #1 applied cleanly.
Rejected hunk #2.
Hunk #3 applied cleanly.
Rejected hunk #4.
Rejected hunk #5.
Rejected hunk #6.
Rejected hunk #7.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/drivers/net/mana/tx.c b/drivers/net/mana/tx.c	(rejected hunks)
@@ -173,13 +175,14 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 	int ret;
 	void *db_page;
 	uint16_t pkt_sent = 0;
-	uint32_t num_comp;
+	uint32_t num_comp, i;
 
 	/* Process send completions from GDMA */
 	num_comp = gdma_poll_completion_queue(&txq->gdma_cq,
 			txq->gdma_comp_buf, txq->num_desc);
 
-	for (uint32_t i = 0; i < num_comp; i++) {
+	i = 0;
+	while (i < num_comp) {
 		struct mana_txq_desc *desc =
 			&txq->desc_ring[txq->desc_ring_tail];
 		struct mana_tx_comp_oob *oob = (struct mana_tx_comp_oob *)
@@ -215,6 +227,9 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 		struct one_sgl sgl;
 		uint16_t seg_idx;
 
+		if (txq->desc_ring_len >= txq->num_desc)
+			break;
+
 		/* Drop the packet if it exceeds max segments */
 		if (m_pkt->nb_segs > priv->max_send_sge) {
 			DP_LOG(ERR, "send packet segments %d exceeding max",
@@ -310,7 +325,6 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 			tx_oob.short_oob.tx_compute_UDP_checksum = 0;
 		}
 
-		tx_oob.short_oob.suppress_tx_CQE_generation = 0;
 		tx_oob.short_oob.VCQ_number = txq->gdma_cq.id;
 
 		tx_oob.short_oob.VSQ_frame_num =
@@ -362,6 +376,16 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 		if (seg_idx != m_pkt->nb_segs)
 			continue;
 
+		/* If we can at least queue post two WQEs and there are at
+		 * least two packets to send, use TX CQE suppression for the
+		 * current WQE
+		 */
+		if (txq->desc_ring_len + 1 < txq->num_desc &&
+		    pkt_idx + 1 < nb_pkts)
+			tx_oob.short_oob.suppress_tx_CQE_generation = 1;
+		else
+			tx_oob.short_oob.suppress_tx_CQE_generation = 0;
+
 		struct gdma_work_request work_req;
 		uint32_t wqe_size_in_bu;
 
@@ -384,8 +408,11 @@ mana_tx_burst(void *dpdk_txq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 			/* Update queue for tracking pending requests */
 			desc->pkt = m_pkt;
 			desc->wqe_size_in_bu = wqe_size_in_bu;
+			desc->suppress_tx_cqe =
+				tx_oob.short_oob.suppress_tx_CQE_generation;
 			txq->desc_ring_head =
 				(txq->desc_ring_head + 1) % txq->num_desc;
+			txq->desc_ring_len++;
 
 			pkt_sent++;
 

https://lab.dpdk.org/results/dashboard/patchsets/26173/

UNH-IOL DPDK Community Lab