From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw126880 [PATCH] [v2] lib/kni : coding style is fixed
Date: Tue, 16 May 2023 04:17:29 -0700 (PDT) [thread overview]
Message-ID: <64636649.6b0a0220.33fdb.db84SMTPIN_ADDED_MISSING@mx.google.com> (raw)
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/126880
_apply patch failure_
Submitter: Yasin CANER <yasinncaner@gmail.com>
Date: Tuesday, May 16 2023 11:03:59
Applied on: CommitID:a399d7b5a994e335c446d4b15d7622d71dd8848c
Apply patch set 126880 failed:
.git/rebase-apply/patch:18: trailing whitespace.
/* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/
Checking patch lib/kni/rte_kni.c...
error: while searching for:
RTE_LOG(ERR, KNI, "No valid mempool for allocating mbufs\n");
return;
}
/* First, getting allocation count from alloc_q. alloc_q is allocated in this function
* and/or kni_alloc function from mempool.
* If alloc_q is completely removed, it shall be allocated again.
* */
allocq = kni_fifo_count(kni->alloc_q);
/* How many free allocation is possible from mempool. */
allocq_free = kni_fifo_free_count(kni->alloc_q);
/* Allocated alloc_q count shall be max MAX_MBUF_BURST_NUM. */
allocq_count = MAX_MBUF_BURST_NUM - (int)allocq;
/* Try to figure out how many allocation is possible. allocq_free is max possible.*/
allocq_free = (allocq_free > MAX_MBUF_BURST_NUM )? MAX_MBUF_BURST_NUM : allocq_free;
/* Buffer is not removed so no need re-allocate*/
if(!allocq_count) {
/* Buffer is not removed so no need re-allocation*/
return;
} else if (allocq_free > allocq_count) {
error: patch failed: lib/kni/rte_kni.c:683
Applying patch lib/kni/rte_kni.c with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/lib/kni/rte_kni.c b/lib/kni/rte_kni.c (rejected hunks)
@@ -683,20 +683,21 @@ kni_allocate_mbufs(struct rte_kni *kni)
RTE_LOG(ERR, KNI, "No valid mempool for allocating mbufs\n");
return;
}
- /* First, getting allocation count from alloc_q. alloc_q is allocated in this function
- * and/or kni_alloc function from mempool.
- * If alloc_q is completely removed, it shall be allocated again.
- * */
+
+ /* First, getting allocation count from alloc_q. alloc_q is allocated in this function*/
+ /* and/or kni_alloc function from mempool.*/
+ /* If alloc_q is completely removed, it shall be allocated again.*/
+
allocq = kni_fifo_count(kni->alloc_q);
/* How many free allocation is possible from mempool. */
allocq_free = kni_fifo_free_count(kni->alloc_q);
/* Allocated alloc_q count shall be max MAX_MBUF_BURST_NUM. */
allocq_count = MAX_MBUF_BURST_NUM - (int)allocq;
/* Try to figure out how many allocation is possible. allocq_free is max possible.*/
- allocq_free = (allocq_free > MAX_MBUF_BURST_NUM )? MAX_MBUF_BURST_NUM : allocq_free;
+ allocq_free = (allocq_free > MAX_MBUF_BURST_NUM) ? MAX_MBUF_BURST_NUM : allocq_free;
/* Buffer is not removed so no need re-allocate*/
- if(!allocq_count) {
+ if (!allocq_count) {
/* Buffer is not removed so no need re-allocation*/
return;
} else if (allocq_free > allocq_count) {
https://lab.dpdk.org/results/dashboard/patchsets/26238/
UNH-IOL DPDK Community Lab
next reply other threads:[~2023-05-16 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 11:17 dpdklab [this message]
[not found] <20230516110359.479441-1-yasinncaner@gmail.com>
2023-05-16 10:51 ` |WARNING| pw126880 [PATCH v2] " qemudev
2023-05-16 11:04 ` checkpatch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64636649.6b0a0220.33fdb.db84SMTPIN_ADDED_MISSING@mx.google.com \
--to=dpdklab@iol.unh.edu \
--cc=dpdk-test-reports@iol.unh.edu \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).