From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31AB142B2A for ; Wed, 17 May 2023 10:36:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FA154067B; Wed, 17 May 2023 10:36:46 +0200 (CEST) Received: from mail-pf1-f228.google.com (mail-pf1-f228.google.com [209.85.210.228]) by mails.dpdk.org (Postfix) with ESMTP id AB21A4067B for ; Wed, 17 May 2023 10:36:44 +0200 (CEST) Received: by mail-pf1-f228.google.com with SMTP id d2e1a72fcca58-64359d9c531so329986b3a.3 for ; Wed, 17 May 2023 01:36:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1684312604; x=1686904604; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=LnbuAvWgyPs2xWgI6eA11eDrEQ5nDXBpBAMchTADxOs=; b=j0/hfWKhFb1DDTfLfS6BvdlK33GW6aUdKRyIF99Qr0BuUCWRzKyQ2ctlfzYlSz8n0x iLXD0mUaiQyCAr2LyjHjly8hzNj6GEOfEu7RDkS3qJwGm7HDzj4Fee1R7jfqYLlB9Bxk +K1RL8eXSED0y4HPTRJ0P0j9xeo+lj2kEr2ho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684312604; x=1686904604; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LnbuAvWgyPs2xWgI6eA11eDrEQ5nDXBpBAMchTADxOs=; b=aE+vPQxDetDSrgTKRzQcwGPjzc4c8rePuNCAnsiQj43tk5JqkK3GUK+WPdZSZnCepe wn9BcHev+ifX8VCB/7RvhH9eqn10OIeFP6XVrz4EIKKnnHfE0feJ/KNLhPH+QTk025yQ 04VqmTHUlUWgxBR7HFu9bRKZ/CAGO/LvPGicq8D2fg+qFyqJkV8ti8jKfGei7Qd083g0 74ShxYwey1IRPvKhnycfxB5ightsNWmIeUv6uLCISKJT2PyHo7kMVqFf/CqY+Yhv/mvU HST7S/eTFqrgdMR7ro+Ig24b9LyEgMyM9mBAqO2chB6/4TZVgXDTMT0Y5NFK8aW3ChQT k3fg== X-Gm-Message-State: AC+VfDwPn6tRWTy1jYderaA2udkc2yHjOKrp1PDa7hMj1MlEI54OUzSA 8eF3GNR0lBgUSE8C8AhkOrDVQBRuYhcOXrXCRAZ2AZUHP6hP2+I9GI6lOw== X-Google-Smtp-Source: ACHHUZ6sJJ9WwQrNwJRaK9NioZTlK0DptwRv8byl0V/avvY+eKCL0lPdkeV8jc5JaSJ7pxQPNZp+ta29dEBs X-Received: by 2002:a05:6a00:1150:b0:647:b071:20c4 with SMTP id b16-20020a056a00115000b00647b07120c4mr60871pfm.1.1684312603864; Wed, 17 May 2023 01:36:43 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id u4-20020a056a00098400b0063d357a6835sm2091238pfg.13.2023.05.17.01.36.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2023 01:36:43 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Wed, 17 May 2023 01:36:43 -0700 (PDT) Message-ID: <6464921b.050a0220.195af.69b7SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id 734E5605246B; Wed, 17 May 2023 04:36:42 -0400 (EDT) Subject: |WARNING| pw126905 [PATCH] net/nfp: implement xstats functions From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/126905 _apply patch failure_ Submitter: Chaoyong He Date: Wednesday, May 17 2023 07:33:51 Applied on: CommitID:a399d7b5a994e335c446d4b15d7622d71dd8848c Apply patch set 126905 failed: Checking patch drivers/net/nfp/nfp_common.c... error: while searching for: #include "nfd3/nfp_nfd3.h" #include "nfdk/nfp_nfdk.h" #include #include #include error: patch failed: drivers/net/nfp/nfp_common.c:47 error: while searching for: #include #include static const uint32_t nfp_net_link_speed_nfp2rte[] = { [NFP_NET_CFG_STS_LINK_RATE_UNSUPPORTED] = RTE_ETH_SPEED_NUM_NONE, [NFP_NET_CFG_STS_LINK_RATE_UNKNOWN] = RTE_ETH_SPEED_NUM_NONE, error: patch failed: drivers/net/nfp/nfp_common.c:54 Hunk #3 succeeded at 792 (offset -118 lines). Checking patch drivers/net/nfp/nfp_common.h... Checking patch drivers/net/nfp/nfp_ctrl.h... Hunk #1 succeeded at 334 (offset 5 lines). Hunk #2 succeeded at 356 (offset 5 lines). Checking patch drivers/net/nfp/nfp_ethdev.c... Hunk #1 succeeded at 446 (offset -2 lines). Hunk #2 succeeded at 556 (offset -2 lines). Hunk #3 succeeded at 588 (offset -2 lines). Checking patch drivers/net/nfp/nfp_ethdev_vf.c... Hunk #1 succeeded at 227 (offset -2 lines). Hunk #2 succeeded at 338 (offset -2 lines). Applying patch drivers/net/nfp/nfp_common.c with 2 rejects... Rejected hunk #1. Rejected hunk #2. Hunk #3 applied cleanly. Applied patch drivers/net/nfp/nfp_common.h cleanly. Applied patch drivers/net/nfp/nfp_ctrl.h cleanly. Applied patch drivers/net/nfp/nfp_ethdev.c cleanly. Applied patch drivers/net/nfp/nfp_ethdev_vf.c cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c (rejected hunks) @@ -47,6 +47,7 @@ #include "nfd3/nfp_nfd3.h" #include "nfdk/nfp_nfdk.h" +#include #include #include #include @@ -54,6 +55,121 @@ #include #include +enum nfp_xstat_group { + NFP_XSTAT_GROUP_NET, + NFP_XSTAT_GROUP_MAC +}; +struct nfp_xstat { + char name[RTE_ETH_XSTATS_NAME_SIZE]; + int offset; + enum nfp_xstat_group group; +}; + +#define NFP_XSTAT_NET(_name, _offset) { \ + .name = _name, \ + .offset = NFP_NET_CFG_STATS_##_offset, \ + .group = NFP_XSTAT_GROUP_NET, \ +} + +#define NFP_XSTAT_MAC(_name, _offset) { \ + .name = _name, \ + .offset = NFP_MAC_STATS_##_offset, \ + .group = NFP_XSTAT_GROUP_MAC, \ +} + +static const struct nfp_xstat nfp_net_xstats[] = { + /** + * Basic xstats available on both VF and PF. + * Note that in case new statistics of group NFP_XSTAT_GROUP_NET + * are added to this array, they must appear before any statistics + * of group NFP_XSTAT_GROUP_MAC. + */ + NFP_XSTAT_NET("rx_good_packets_mc", RX_MC_FRAMES), + NFP_XSTAT_NET("tx_good_packets_mc", TX_MC_FRAMES), + NFP_XSTAT_NET("rx_good_packets_bc", RX_BC_FRAMES), + NFP_XSTAT_NET("tx_good_packets_bc", TX_BC_FRAMES), + NFP_XSTAT_NET("rx_good_bytes_uc", RX_UC_OCTETS), + NFP_XSTAT_NET("tx_good_bytes_uc", TX_UC_OCTETS), + NFP_XSTAT_NET("rx_good_bytes_mc", RX_MC_OCTETS), + NFP_XSTAT_NET("tx_good_bytes_mc", TX_MC_OCTETS), + NFP_XSTAT_NET("rx_good_bytes_bc", RX_BC_OCTETS), + NFP_XSTAT_NET("tx_good_bytes_bc", TX_BC_OCTETS), + NFP_XSTAT_NET("tx_missed_erros", TX_DISCARDS), + NFP_XSTAT_NET("bpf_pass_pkts", APP0_FRAMES), + NFP_XSTAT_NET("bpf_pass_bytes", APP0_BYTES), + NFP_XSTAT_NET("bpf_app1_pkts", APP1_FRAMES), + NFP_XSTAT_NET("bpf_app1_bytes", APP1_BYTES), + NFP_XSTAT_NET("bpf_app2_pkts", APP2_FRAMES), + NFP_XSTAT_NET("bpf_app2_bytes", APP2_BYTES), + NFP_XSTAT_NET("bpf_app3_pkts", APP3_FRAMES), + NFP_XSTAT_NET("bpf_app3_bytes", APP3_BYTES), + /** + * MAC xstats available only on PF. These statistics are not available for VFs as the + * PF is not initialized when the VF is initialized as it is still bound to the kernel + * driver. As such, the PMD cannot obtain a CPP handle and access the rtsym_table in order + * to get the pointer to the start of the MAC statistics counters. + */ + NFP_XSTAT_MAC("mac.rx_octets", RX_IN_OCTS), + NFP_XSTAT_MAC("mac.rx_frame_too_long_errors", RX_FRAME_TOO_LONG_ERRORS), + NFP_XSTAT_MAC("mac.rx_range_length_errors", RX_RANGE_LENGTH_ERRORS), + NFP_XSTAT_MAC("mac.rx_vlan_received_ok", RX_VLAN_RECEIVED_OK), + NFP_XSTAT_MAC("mac.rx_errors", RX_IN_ERRORS), + NFP_XSTAT_MAC("mac.rx_broadcast_pkts", RX_IN_BROADCAST_PKTS), + NFP_XSTAT_MAC("mac.rx_drop_events", RX_DROP_EVENTS), + NFP_XSTAT_MAC("mac.rx_alignment_errors", RX_ALIGNMENT_ERRORS), + NFP_XSTAT_MAC("mac.rx_pause_mac_ctrl_frames", RX_PAUSE_MAC_CTRL_FRAMES), + NFP_XSTAT_MAC("mac.rx_frames_received_ok", RX_FRAMES_RECEIVED_OK), + NFP_XSTAT_MAC("mac.rx_frame_check_sequence_errors", RX_FRAME_CHECK_SEQ_ERRORS), + NFP_XSTAT_MAC("mac.rx_unicast_pkts", RX_UNICAST_PKTS), + NFP_XSTAT_MAC("mac.rx_multicast_pkts", RX_MULTICAST_PKTS), + NFP_XSTAT_MAC("mac.rx_pkts", RX_PKTS), + NFP_XSTAT_MAC("mac.rx_undersize_pkts", RX_UNDERSIZE_PKTS), + NFP_XSTAT_MAC("mac.rx_pkts_64_octets", RX_PKTS_64_OCTS), + NFP_XSTAT_MAC("mac.rx_pkts_65_to_127_octets", RX_PKTS_65_TO_127_OCTS), + NFP_XSTAT_MAC("mac.rx_pkts_128_to_255_octets", RX_PKTS_128_TO_255_OCTS), + NFP_XSTAT_MAC("mac.rx_pkts_256_to_511_octets", RX_PKTS_256_TO_511_OCTS), + NFP_XSTAT_MAC("mac.rx_pkts_512_to_1023_octets", RX_PKTS_512_TO_1023_OCTS), + NFP_XSTAT_MAC("mac.rx_pkts_1024_to_1518_octets", RX_PKTS_1024_TO_1518_OCTS), + NFP_XSTAT_MAC("mac.rx_pkts_1519_to_max_octets", RX_PKTS_1519_TO_MAX_OCTS), + NFP_XSTAT_MAC("mac.rx_jabbers", RX_JABBERS), + NFP_XSTAT_MAC("mac.rx_fragments", RX_FRAGMENTS), + NFP_XSTAT_MAC("mac.rx_oversize_pkts", RX_OVERSIZE_PKTS), + NFP_XSTAT_MAC("mac.rx_pause_frames_class0", RX_PAUSE_FRAMES_CLASS0), + NFP_XSTAT_MAC("mac.rx_pause_frames_class1", RX_PAUSE_FRAMES_CLASS1), + NFP_XSTAT_MAC("mac.rx_pause_frames_class2", RX_PAUSE_FRAMES_CLASS2), + NFP_XSTAT_MAC("mac.rx_pause_frames_class3", RX_PAUSE_FRAMES_CLASS3), + NFP_XSTAT_MAC("mac.rx_pause_frames_class4", RX_PAUSE_FRAMES_CLASS4), + NFP_XSTAT_MAC("mac.rx_pause_frames_class5", RX_PAUSE_FRAMES_CLASS5), + NFP_XSTAT_MAC("mac.rx_pause_frames_class6", RX_PAUSE_FRAMES_CLASS6), + NFP_XSTAT_MAC("mac.rx_pause_frames_class7", RX_PAUSE_FRAMES_CLASS7), + NFP_XSTAT_MAC("mac.rx_mac_ctrl_frames_received", RX_MAC_CTRL_FRAMES_REC), + NFP_XSTAT_MAC("mac.rx_mac_head_drop", RX_MAC_HEAD_DROP), + NFP_XSTAT_MAC("mac.tx_queue_drop", TX_QUEUE_DROP), + NFP_XSTAT_MAC("mac.tx_octets", TX_OUT_OCTS), + NFP_XSTAT_MAC("mac.tx_vlan_transmitted_ok", TX_VLAN_TRANSMITTED_OK), + NFP_XSTAT_MAC("mac.tx_errors", TX_OUT_ERRORS), + NFP_XSTAT_MAC("mac.tx_broadcast_pkts", TX_BROADCAST_PKTS), + NFP_XSTAT_MAC("mac.tx_pause_mac_ctrl_frames", TX_PAUSE_MAC_CTRL_FRAMES), + NFP_XSTAT_MAC("mac.tx_frames_transmitted_ok", TX_FRAMES_TRANSMITTED_OK), + NFP_XSTAT_MAC("mac.tx_unicast_pkts", TX_UNICAST_PKTS), + NFP_XSTAT_MAC("mac.tx_multicast_pkts", TX_MULTICAST_PKTS), + NFP_XSTAT_MAC("mac.tx_pkts_64_octets", TX_PKTS_64_OCTS), + NFP_XSTAT_MAC("mac.tx_pkts_65_to_127_octets", TX_PKTS_65_TO_127_OCTS), + NFP_XSTAT_MAC("mac.tx_pkts_128_to_255_octets", TX_PKTS_128_TO_255_OCTS), + NFP_XSTAT_MAC("mac.tx_pkts_256_to_511_octets", TX_PKTS_256_TO_511_OCTS), + NFP_XSTAT_MAC("mac.tx_pkts_512_to_1023_octets", TX_PKTS_512_TO_1023_OCTS), + NFP_XSTAT_MAC("mac.tx_pkts_1024_to_1518_octets", TX_PKTS_1024_TO_1518_OCTS), + NFP_XSTAT_MAC("mac.tx_pkts_1519_to_max_octets", TX_PKTS_1519_TO_MAX_OCTS), + NFP_XSTAT_MAC("mac.tx_pause_frames_class0", TX_PAUSE_FRAMES_CLASS0), + NFP_XSTAT_MAC("mac.tx_pause_frames_class1", TX_PAUSE_FRAMES_CLASS1), + NFP_XSTAT_MAC("mac.tx_pause_frames_class2", TX_PAUSE_FRAMES_CLASS2), + NFP_XSTAT_MAC("mac.tx_pause_frames_class3", TX_PAUSE_FRAMES_CLASS3), + NFP_XSTAT_MAC("mac.tx_pause_frames_class4", TX_PAUSE_FRAMES_CLASS4), + NFP_XSTAT_MAC("mac.tx_pause_frames_class5", TX_PAUSE_FRAMES_CLASS5), + NFP_XSTAT_MAC("mac.tx_pause_frames_class6", TX_PAUSE_FRAMES_CLASS6), + NFP_XSTAT_MAC("mac.tx_pause_frames_class7", TX_PAUSE_FRAMES_CLASS7), +}; + static const uint32_t nfp_net_link_speed_nfp2rte[] = { [NFP_NET_CFG_STS_LINK_RATE_UNSUPPORTED] = RTE_ETH_SPEED_NUM_NONE, [NFP_NET_CFG_STS_LINK_RATE_UNKNOWN] = RTE_ETH_SPEED_NUM_NONE, https://lab.dpdk.org/results/dashboard/patchsets/26250/ UNH-IOL DPDK Community Lab