From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7B30A42B2C
	for <public@inbox.dpdk.org>; Wed, 17 May 2023 19:45:19 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5A5A1406B7;
	Wed, 17 May 2023 19:45:19 +0200 (CEST)
Received: from mail-oa1-f97.google.com (mail-oa1-f97.google.com
 [209.85.160.97]) by mails.dpdk.org (Postfix) with ESMTP id AE956406B7
 for <test-report@dpdk.org>; Wed, 17 May 2023 19:45:18 +0200 (CEST)
Received: by mail-oa1-f97.google.com with SMTP id
 586e51a60fabf-1924ec320c5so777716fac.1
 for <test-report@dpdk.org>; Wed, 17 May 2023 10:45:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1684345518; x=1686937518;
 h=cc:to:from:subject:message-id:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=VKMvLFxYkY+l53DxZrhczIgutV8xsJ/KRHaigwMpTs0=;
 b=f32c1G7viUa/u8CPPM+Y8rz/v5UKWiXIwvBHkROJfq57E2PjKo4WmitcVQIBo3jxRN
 QVQHvcFwoK/vKv9h6uGiauj+bM/rH4rceVI/qeqrZVr0ZZVSXtwwj36as95TJnusu0Mk
 8uGxvqtgnGH7es1vibZXuK+rSJGGzXYcfnWzo=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1684345518; x=1686937518;
 h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=VKMvLFxYkY+l53DxZrhczIgutV8xsJ/KRHaigwMpTs0=;
 b=StTbmrejTqOT1/shKgKP5mY2Z9R/EwKP7qBkG6F5tarZMecWT0i/Nln5MihvZNBbal
 cIBIyvEiZs3POX6r7+2Aqid5DUhPVUWFKS7c0s4Mg47v8YMTPwqNNrfpS8JZo3KsWdAg
 u5463L3nJy1L9bBFkqXwQR/2faiKnkeF5l/PlegZa+U/1tblhihe/1s+HrkG4OsC9mFH
 /u00DIn89HVOgFLJ3WmpbgJECA5dR/99KhxFoTxvaNrTo/+xtB8xLX4WnDoFP83T08Z2
 7B/F+t9UTq7RRKzUgY3DUWolcfvy2wMJxk2GSem9CqOvhKePr7/Edql0ZRlcFH5yRxOm
 SkZg==
X-Gm-Message-State: AC+VfDz/cyWP854VicLVboIlBnCiP/s25BYq3gSDCKLJmA5A8GNwlnRI
 uSIuCgGc1vqCHGFGoVxnO0UjCGdj45nXeUiIPJjVMSlbE825gl0NLp3o6jPSlbjIxefT71VLvw=
 =
X-Google-Smtp-Source: ACHHUZ5e430gw55Z+2l0zlwbuLG+jdBXGrygfY0fnwVx5yum5nMkQh1cmaukOyqiFkMuDDhlsDsgwFbPL7tW
X-Received: by 2002:a05:6870:a704:b0:177:b62d:cc1c with SMTP id
 g4-20020a056870a70400b00177b62dcc1cmr11860695oam.0.1684345517981; 
 Wed, 17 May 2023 10:45:17 -0700 (PDT)
Received: from postal.iol.unh.edu (postal.iol.unh.edu.
 [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id
 ee1-20020a056870c80100b001968dd2e1ecsm823359oab.2.2023.05.17.10.45.17
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 17 May 2023 10:45:17 -0700 (PDT)
X-Relaying-Domain: iol.unh.edu
Date: Wed, 17 May 2023 10:45:17 -0700 (PDT)
Message-ID: <646512ad.050a0220.14e80.8d94SMTPIN_ADDED_MISSING@mx.google.com>
Received: from [172.17.0.2] (unknown [172.18.0.34])
 by postal.iol.unh.edu (Postfix) with ESMTP id 91FE1605246B;
 Wed, 17 May 2023 13:45:17 -0400 (EDT)
Subject: |WARNING| pw126947 [PATCH] lib/cryptodev: move RSA padding
 information into xform
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Content-Type: text/plain
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/126947

_apply patch failure_

Submitter: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Date: Wednesday, May 17 2023 16:52:41 
Applied on: CommitID:a399d7b5a994e335c446d4b15d7622d71dd8848c
Apply patch set 126947 failed:

Checking patch app/test/test_cryptodev_asym.c...
error: while searching for:
	asym_op->rsa.message.length = rsaplaintext.len;
	asym_op->rsa.sign.length = RTE_DIM(rsa_n);
	asym_op->rsa.sign.data = output_buf;
	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;

	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
		      asym_op->rsa.message.length);

error: patch failed: app/test/test_cryptodev_asym.c:92
Hunk #2 succeeded at 124 (offset 1 line).
error: while searching for:
	asym_op->rsa.cipher.data = cipher_buf;
	asym_op->rsa.cipher.length = RTE_DIM(rsa_n);
	asym_op->rsa.message.length = rsaplaintext.len;
	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;

	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
		      asym_op->rsa.message.length);

error: patch failed: app/test/test_cryptodev_asym.c:183
error: while searching for:
	asym_op = result_op->asym;
	asym_op->rsa.message.length = RTE_DIM(rsa_n);
	asym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT;
	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;

	/* Process crypto operation */
	if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {

error: patch failed: app/test/test_cryptodev_asym.c:215
Hunk #5 succeeded at 411 (offset 3 lines).
Checking patch app/test/test_cryptodev_rsa_test_vectors.h...
Checking patch drivers/common/cpt/cpt_ucode_asym.h...
Checking patch drivers/crypto/cnxk/cnxk_ae.h...
Checking patch drivers/crypto/octeontx/otx_cryptodev_ops.c...
Checking patch drivers/crypto/openssl/openssl_pmd_private.h...
Checking patch drivers/crypto/openssl/rte_openssl_pmd.c...
Checking patch drivers/crypto/openssl/rte_openssl_pmd_ops.c...
Checking patch drivers/crypto/qat/qat_asym.c...
Checking patch examples/fips_validation/main.c...
Checking patch lib/cryptodev/rte_crypto_asym.h...
error: while searching for:
	 * This could be validated and overwritten by the PMD
	 * with the signature length.
	 */

	struct rte_crypto_rsa_padding padding;
	/**< RSA padding information */
};

/**

error: patch failed: lib/cryptodev/rte_crypto_asym.h:451
Applying patch app/test/test_cryptodev_asym.c with 3 rejects...
Rejected hunk #1.
Hunk #2 applied cleanly.
Rejected hunk #3.
Rejected hunk #4.
Hunk #5 applied cleanly.
Applied patch app/test/test_cryptodev_rsa_test_vectors.h cleanly.
Applied patch drivers/common/cpt/cpt_ucode_asym.h cleanly.
Applied patch drivers/crypto/cnxk/cnxk_ae.h cleanly.
Applied patch drivers/crypto/octeontx/otx_cryptodev_ops.c cleanly.
Applied patch drivers/crypto/openssl/openssl_pmd_private.h cleanly.
Applied patch drivers/crypto/openssl/rte_openssl_pmd.c cleanly.
Applied patch drivers/crypto/openssl/rte_openssl_pmd_ops.c cleanly.
Applied patch drivers/crypto/qat/qat_asym.c cleanly.
Applied patch examples/fips_validation/main.c cleanly.
Applying patch lib/cryptodev/rte_crypto_asym.h with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c	(rejected hunks)
@@ -92,7 +92,6 @@ queue_ops_rsa_sign_verify(void *sess)
 	asym_op->rsa.message.length = rsaplaintext.len;
 	asym_op->rsa.sign.length = RTE_DIM(rsa_n);
 	asym_op->rsa.sign.data = output_buf;
-	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;
 
 	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
 		      asym_op->rsa.message.length);
@@ -183,7 +181,6 @@ queue_ops_rsa_enc_dec(void *sess)
 	asym_op->rsa.cipher.data = cipher_buf;
 	asym_op->rsa.cipher.length = RTE_DIM(rsa_n);
 	asym_op->rsa.message.length = rsaplaintext.len;
-	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;
 
 	debug_hexdump(stdout, "message", asym_op->rsa.message.data,
 		      asym_op->rsa.message.length);
@@ -215,7 +212,6 @@ queue_ops_rsa_enc_dec(void *sess)
 	asym_op = result_op->asym;
 	asym_op->rsa.message.length = RTE_DIM(rsa_n);
 	asym_op->rsa.op_type = RTE_CRYPTO_ASYM_OP_DECRYPT;
-	asym_op->rsa.padding.type = RTE_CRYPTO_RSA_PADDING_PKCS1_5;
 
 	/* Process crypto operation */
 	if (rte_cryptodev_enqueue_burst(dev_id, 0, &op, 1) != 1) {
diff a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h	(rejected hunks)
@@ -451,9 +454,6 @@ struct rte_crypto_rsa_op_param {
 	 * This could be validated and overwritten by the PMD
 	 * with the signature length.
 	 */
-
-	struct rte_crypto_rsa_padding padding;
-	/**< RSA padding information */
 };
 
 /**

https://lab.dpdk.org/results/dashboard/patchsets/26264/

UNH-IOL DPDK Community Lab