From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07B1342C40 for ; Tue, 6 Jun 2023 15:34:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB05C40223; Tue, 6 Jun 2023 15:34:16 +0200 (CEST) Received: from mail-io1-f98.google.com (mail-io1-f98.google.com [209.85.166.98]) by mails.dpdk.org (Postfix) with ESMTP id 8AA9D40223 for ; Tue, 6 Jun 2023 15:34:15 +0200 (CEST) Received: by mail-io1-f98.google.com with SMTP id ca18e2360f4ac-777b4560ae8so79454039f.2 for ; Tue, 06 Jun 2023 06:34:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686058455; x=1688650455; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=War+Vo9VbylvyehJJWzl/L6k1Ygvmo6q3zO+dWaZnGI=; b=YqWpfWjc0bQmz3COZEJ3dzgcoJrP+LZHS6jIq5ycUny3QKsMx/ldKSP4gtMH44ohvm C+KKhOuGHO2jjj3UJoF0p6whoZtpGY/baSCM8z8sHlZl75F3JR0P1bjg23+E/wHlneCA 1KY8KODikutUmAw2OoPpui+fJqs7/o4o0kWRE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686058455; x=1688650455; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=War+Vo9VbylvyehJJWzl/L6k1Ygvmo6q3zO+dWaZnGI=; b=LvE56LE3J54JdVAFDZqwNAiJ1/PkcTQbFQXUQ90d3ZHZG+HOuOaIDpgWl4vo/+LziT fSGbq1ZglBzZBu6Fu/ggNVIGHBvEfR9c1V1f2OhBUCc+YZjv/puuDxJdq/X3slk05cVD Wrdr44kMWxBow9WmlamRLv4Y91X2V87jtrsqsXsZqGzpwspl5c1zGULdsdFVTxwixhEb /xl5MBjp5tER945+bpNbkKMUujZs+2nGVLTpAuIzcJadmD5qxdJ9WexuMCSdella2iQ/ 90YL6ajIkaK4fdov+pCdBTaVlojnRD9q1oimSmzIo/q4vbxTWEE43ka7Kmto+zQ6xmvJ 4ZZA== X-Gm-Message-State: AC+VfDyeK+2Iwrwb5v+vW2ub0n20S/pQXAiSBMf8jGwkQ+YHZ6vtRLpu G2ZC2BOFyN95LJO/8Pkrzj1IV9iIZtWIgvndAEQywLI7Yj7re8wgLw32RQ== X-Google-Smtp-Source: ACHHUZ65eoPc/pUS4DimX0Zzn4QVQ3K6w0B8Tb2oxVMIjcnHY/dPtiCB8pTNYzM5/jm4Dr6b7fsUZlqmnYa2 X-Received: by 2002:a5e:df4b:0:b0:775:3e8a:f57e with SMTP id g11-20020a5edf4b000000b007753e8af57emr2812201ioq.18.1686058454911; Tue, 06 Jun 2023 06:34:14 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id z4-20020a056602080400b00775aadf724fsm807003iow.4.2023.06.06.06.34.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jun 2023 06:34:14 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Tue, 06 Jun 2023 06:34:14 -0700 (PDT) Message-ID: <647f35d6.050a0220.c4ba0.1584SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id 6F864605246B; Tue, 6 Jun 2023 09:34:14 -0400 (EDT) Subject: |WARNING| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/128163 _apply patch failure_ Submitter: Rahul Bhansali Date: Tuesday, June 06 2023 06:12:49 Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91 Apply patch set 128163 failed: Checking patch drivers/net/cnxk/cn10k_ethdev.c... Checking patch drivers/net/cnxk/cn10k_rxtx.h... Checking patch drivers/net/cnxk/cn10k_tx.h... error: while searching for: if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1174 error: while searching for: if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1323 error: while searching for: handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } else { scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1879 Applied patch drivers/net/cnxk/cn10k_ethdev.c cleanly. Applied patch drivers/net/cnxk/cn10k_rxtx.h cleanly. Applying patch drivers/net/cnxk/cn10k_tx.h with 3 rejects... Hunk #1 applied cleanly. Rejected hunk #2. Rejected hunk #3. Rejected hunk #4. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h (rejected hunks) @@ -1174,11 +1215,9 @@ cn10k_nix_xmit_pkts(void *tx_queue, uint64_t *ws, struct rte_mbuf **tx_pkts, if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); - if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; - } + if (!(flags & NIX_TX_VWQE_F)) + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); + /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); @@ -1323,11 +1362,9 @@ cn10k_nix_xmit_pkts_mseg(void *tx_queue, uint64_t *ws, if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); - if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; - } + if (!(flags & NIX_TX_VWQE_F)) + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); + /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); @@ -1879,11 +1916,9 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws, handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); } else { scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); https://lab.dpdk.org/results/dashboard/patchsets/26545/ UNH-IOL DPDK Community Lab