From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C237842C64 for ; Thu, 8 Jun 2023 23:33:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFC1740151; Thu, 8 Jun 2023 23:33:56 +0200 (CEST) Received: from mail-pj1-f99.google.com (mail-pj1-f99.google.com [209.85.216.99]) by mails.dpdk.org (Postfix) with ESMTP id C073040151 for ; Thu, 8 Jun 2023 23:33:50 +0200 (CEST) Received: by mail-pj1-f99.google.com with SMTP id 98e67ed59e1d1-256422ad25dso128409a91.0 for ; Thu, 08 Jun 2023 14:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686260030; x=1688852030; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=War+Vo9VbylvyehJJWzl/L6k1Ygvmo6q3zO+dWaZnGI=; b=BMrYLlrgI+Y4rJrnocfxMqalPdx1o+99I8aczwkMay43swFfwpPnyE1BdpdNDV88MC lyOgUMfvlg04qPo5smGMweWAZwLQZDkzyuGh3aSEwcpUz88x7TywvBE68xca0+JXw3xt FkTC4ukhm9pxf+kQvq2OicchopIMn2jrtwxf4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686260030; x=1688852030; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=War+Vo9VbylvyehJJWzl/L6k1Ygvmo6q3zO+dWaZnGI=; b=U2j1kFRhW99PPmiM07v1wDxOh+78BD7jP/nUurvPQwWOlW9/1g0fyJDEGdK0wCCQsT 75p4rKZqOF+CeEXMDQTA1X5KEQWrBHbmBQDCkrm/VX9cJaySgu6u8ZrFq8nRbqvF9CDk JUmK7BflpFlcLPecX4hlBByDDvsqgRUnXk5xf/DkUUvQhh+5fELrQbSnGkDeVqOFXhRU y4dtZeDdqyIK/8etPp+rmHgUC3Sp1M4iATaIIH1t2eoFCk/U0/l20LV/g9OpdRDS70Gb 49mzDadP/mkS2tMk1ilZWk7pE3DH9T/sG+DtN806qLZ/lnXgPEJWf6SLUcGDZh7WU35B LoSA== X-Gm-Message-State: AC+VfDx1lS5fgMZnd3db6frxHWVaJ49kbBGXZ7FPUjBmP2i+KFNgp4LR QXrvB/gV9ZPKFLbVMMZOpIF7KddLn95VDluGvdtzvOnEvAsBwG6rMRiCKZ/Mx5tyFEwSzhb2jA= = X-Google-Smtp-Source: ACHHUZ5PocNKp4yqAwAdfwOrR8377eQRcXNKoBWLjgU5F/5rA1iHX8OTqspttOOKkPTjlCsRD8k/2sSwcD3w X-Received: by 2002:a17:90a:bf87:b0:250:7347:39d9 with SMTP id d7-20020a17090abf8700b00250734739d9mr4861944pjs.37.1686260030093; Thu, 08 Jun 2023 14:33:50 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id np7-20020a17090b4c4700b002590343be4dsm180807pjb.15.2023.06.08.14.33.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jun 2023 14:33:50 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Thu, 08 Jun 2023 14:33:50 -0700 (PDT) Message-ID: <6482493e.170a0220.8cf8c.5d8eSMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.4] (unknown [172.18.0.217]) by postal.iol.unh.edu (Postfix) with ESMTP id 8F2EC605246B; Thu, 8 Jun 2023 17:33:49 -0400 (EDT) Subject: |WARNING| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/128163 _apply patch failure_ Submitter: Rahul Bhansali Date: Tuesday, June 06 2023 06:12:49 Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91 Apply patch set 128163 failed: Checking patch drivers/net/cnxk/cn10k_ethdev.c... Checking patch drivers/net/cnxk/cn10k_rxtx.h... Checking patch drivers/net/cnxk/cn10k_tx.h... error: while searching for: if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1174 error: while searching for: if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1323 error: while searching for: handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } else { scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1879 Applied patch drivers/net/cnxk/cn10k_ethdev.c cleanly. Applied patch drivers/net/cnxk/cn10k_rxtx.h cleanly. Applying patch drivers/net/cnxk/cn10k_tx.h with 3 rejects... Hunk #1 applied cleanly. Rejected hunk #2. Rejected hunk #3. Rejected hunk #4. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h (rejected hunks) @@ -1174,11 +1215,9 @@ cn10k_nix_xmit_pkts(void *tx_queue, uint64_t *ws, struct rte_mbuf **tx_pkts, if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); - if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; - } + if (!(flags & NIX_TX_VWQE_F)) + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); + /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); @@ -1323,11 +1362,9 @@ cn10k_nix_xmit_pkts_mseg(void *tx_queue, uint64_t *ws, if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); - if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; - } + if (!(flags & NIX_TX_VWQE_F)) + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); + /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); @@ -1879,11 +1916,9 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws, handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); } else { scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); https://lab.dpdk.org/results/dashboard/patchsets/26545/ UNH-IOL DPDK Community Lab