From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8584F42C64 for ; Thu, 8 Jun 2023 23:35:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8278640151; Thu, 8 Jun 2023 23:35:10 +0200 (CEST) Received: from mail-oi1-f226.google.com (mail-oi1-f226.google.com [209.85.167.226]) by mails.dpdk.org (Postfix) with ESMTP id 702DA40151 for ; Thu, 8 Jun 2023 23:35:08 +0200 (CEST) Received: by mail-oi1-f226.google.com with SMTP id 5614622812f47-392116ae103so142715b6e.0 for ; Thu, 08 Jun 2023 14:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686260107; x=1688852107; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=9mfIfylaa6O0K26TM6K44n5+EKVD3dyXxmqKtA0d9xg=; b=Uk3ipm5WBXCXJWua3GRYmYblBTzPrvGms78iErf83Jz9uMu2XdZe41SZev9WBiU9YX KJ8UQ68ECKaxlbnUlPRgnu3PIYy+HfT1kF/MJFpi4oX0jxhrTpErnP3OkWjm87N6OUEE pfYyN/rrNldWfAe6f/Zz5wqNcJiw7Awh0WGPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686260107; x=1688852107; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9mfIfylaa6O0K26TM6K44n5+EKVD3dyXxmqKtA0d9xg=; b=ROH37Y7y+VNiC8zb64qh5GsmIztBVQvLC3KITjV8BzxIiH2QSaAAGVsPtSajyRBpc7 aUMTH5XWZAzJqoRI4v4jMGY7+0csWAkn0vZ5xUn/zedbmhn5SVJYBQdlqxbpdICup1Ja oyp70FYVMGTSOiaApopbP+/4P2cA8CPEDhj6X8PI95bd/x+bmUAbs9GtomrbTb2rFV27 d7r9GGNLXBHnmCPA8c3ulnefb26bnqlZC6lRr3t5ysUaCV/BMCbXKPzMo+/sdvygvNwE 9SaG7Jz1esmR3ohESd7UhtShlEVEaXRK3HdWaVsdtRCJB3wUD1Hzx22pzUEDEkDixZIq N6qQ== X-Gm-Message-State: AC+VfDwEjPqhg2PNPCwIOXtB52NeOnVHjAdhRbJPniK8CPcnqL+Ju+gu Qq69SA87f+K4xgVMZjJS08ctOgbrz89pzSXwsq6KC3CXF6AL3aH2d7+SDoYPXGVKkvFPg64G0g= = X-Google-Smtp-Source: ACHHUZ52NaYFbWg1HJC+flRYgJ5mNxjVJuesCc1G98ktosJJgOddJQcwQUmM9mY1IB3hcBvspXqR/0hIexhh X-Received: by 2002:a05:6808:34d:b0:398:2a6b:8647 with SMTP id j13-20020a056808034d00b003982a6b8647mr6855574oie.35.1686260107781; Thu, 08 Jun 2023 14:35:07 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id y20-20020a0cf154000000b00618d521b819sm137553qvl.53.2023.06.08.14.35.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Jun 2023 14:35:07 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Thu, 08 Jun 2023 14:35:07 -0700 (PDT) Message-ID: <6482498b.0c0a0220.c25b9.39b1SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id 7F2EC605246B; Thu, 8 Jun 2023 17:35:07 -0400 (EDT) Subject: |WARNING| pw128166-128191 [PATCH] [v5, 26/26] vhost: add VDUSE device stop From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/128166 _apply patch failure_ Submitter: Maxime Coquelin Date: Tuesday, June 06 2023 08:18:52 Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91 Apply patch set 128166-128191 failed: Checking patch lib/vhost/iotlb.c... Checking patch lib/vhost/iotlb.h... Checking patch lib/vhost/vhost.c... Hunk #1 succeeded at 63 (offset -4 lines). Hunk #2 succeeded at 75 (offset -4 lines). Hunk #3 succeeded at 85 (offset -4 lines). error: while searching for: vhost_free_async_mem(vq); rte_rwlock_write_unlock(&vq->access_lock); rte_free(vq->batch_copy_elems); vhost_user_iotlb_destroy(vq); rte_free(vq->log_cache); rte_free(vq); } error: patch failed: lib/vhost/vhost.c:401 Hunk #5 succeeded at 575 (offset -3 lines). Hunk #6 succeeded at 595 (offset -3 lines). error: while searching for: dev->virtqueue[i] = vq; init_vring_queue(dev, vq, i); rte_rwlock_init(&vq->access_lock); vq->avail_wrap_counter = 1; vq->used_wrap_counter = 1; vq->signalled_used_valid = false; error: patch failed: lib/vhost/vhost.c:635 Hunk #8 succeeded at 793 (offset -4 lines). Checking patch lib/vhost/vhost.h... Hunk #1 succeeded at 302 (offset -3 lines). Hunk #2 succeeded at 476 (offset -3 lines). Checking patch lib/vhost/vhost_user.c... error: while searching for: if (!vva) return RTE_VHOST_MSG_RESULT_ERR; for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; vhost_user_iotlb_cache_insert(dev, vq, imsg->iova, vva, len, imsg->perm); if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); translate_ring_addresses(&dev, &vq); error: patch failed: lib/vhost/vhost_user.c:2639 error: while searching for: } break; case VHOST_IOTLB_INVALIDATE: for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; vhost_user_iotlb_cache_remove(dev, vq, imsg->iova, imsg->size); if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); vring_invalidate(dev, vq); error: patch failed: lib/vhost/vhost_user.c:2657 Hunk #8 succeeded at 2676 (offset 2 lines). Applied patch lib/vhost/iotlb.c cleanly. Applied patch lib/vhost/iotlb.h cleanly. Applying patch lib/vhost/vhost.c with 2 rejects... Hunk #1 applied cleanly. Hunk #2 applied cleanly. Hunk #3 applied cleanly. Rejected hunk #4. Hunk #5 applied cleanly. Hunk #6 applied cleanly. Rejected hunk #7. Hunk #8 applied cleanly. Applied patch lib/vhost/vhost.h cleanly. Applying patch lib/vhost/vhost_user.c with 2 rejects... Hunk #1 applied cleanly. Hunk #2 applied cleanly. Hunk #3 applied cleanly. Hunk #4 applied cleanly. Hunk #5 applied cleanly. Rejected hunk #6. Rejected hunk #7. Hunk #8 applied cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/lib/vhost/vhost.c b/lib/vhost/vhost.c (rejected hunks) @@ -401,7 +401,6 @@ free_vq(struct virtio_net *dev, struct vhost_virtqueue *vq) vhost_free_async_mem(vq); rte_rwlock_write_unlock(&vq->access_lock); rte_free(vq->batch_copy_elems); - vhost_user_iotlb_destroy(vq); rte_free(vq->log_cache); rte_free(vq); } @@ -635,6 +632,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) dev->virtqueue[i] = vq; init_vring_queue(dev, vq, i); rte_rwlock_init(&vq->access_lock); + rte_rwlock_init(&vq->iotlb_lock); vq->avail_wrap_counter = 1; vq->used_wrap_counter = 1; vq->signalled_used_valid = false; diff a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c (rejected hunks) @@ -2639,15 +2641,14 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, if (!vva) return RTE_VHOST_MSG_RESULT_ERR; + vhost_user_iotlb_cache_insert(dev, imsg->iova, vva, len, imsg->perm); + for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; - vhost_user_iotlb_cache_insert(dev, vq, imsg->iova, vva, - len, imsg->perm); - if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); translate_ring_addresses(&dev, &vq); @@ -2657,15 +2658,14 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, } break; case VHOST_IOTLB_INVALIDATE: + vhost_user_iotlb_cache_remove(dev, imsg->iova, imsg->size); + for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; - vhost_user_iotlb_cache_remove(dev, vq, imsg->iova, - imsg->size); - if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); vring_invalidate(dev, vq); Checking patch lib/vhost/iotlb.c... error: lib/vhost/iotlb.c: does not match index Checking patch lib/vhost/iotlb.h... error: lib/vhost/iotlb.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/iotlb.c... error: lib/vhost/iotlb.c: does not match index Checking patch lib/vhost/iotlb.h... error: lib/vhost/iotlb.h: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/socket.c... Hunk #1 succeeded at 221 (offset -2 lines). Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index Checking patch lib/vhost/vhost_user.h... Applied patch lib/vhost/socket.c cleanly. Applied patch lib/vhost/vhost_user.h cleanly. hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/iotlb.c... error: lib/vhost/iotlb.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index Checking patch lib/vhost/vhost_user.h... error: lib/vhost/vhost_user.h: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch doc/guides/prog_guide/vhost_lib.rst... error: while searching for: Inject the offloaded interrupt received by the 'guest_notify' callback, into the vhost device's queue. Vhost-user Implementations -------------------------- error: patch failed: doc/guides/prog_guide/vhost_lib.rst:339 Checking patch doc/guides/rel_notes/release_23_07.rst... error: while searching for: rte_vhost_notify_guest(), is added to raise the interrupt outside of the fast path. Removed Items ------------- error: patch failed: doc/guides/rel_notes/release_23_07.rst:62 Checking patch lib/vhost/rte_vhost.h... Hunk #1 succeeded at 588 (offset -21 lines). Checking patch lib/vhost/socket.c... error: lib/vhost/socket.c: does not match index Checking patch lib/vhost/version.map... error: while searching for: # added in 23.07 rte_vhost_notify_guest; }; INTERNAL { error: patch failed: lib/vhost/version.map:107 Applying patch doc/guides/prog_guide/vhost_lib.rst with 1 reject... Rejected hunk #1. Applying patch doc/guides/rel_notes/release_23_07.rst with 1 reject... Rejected hunk #1. Applied patch lib/vhost/rte_vhost.h cleanly. Applying patch lib/vhost/version.map with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst (rejected hunks) @@ -339,6 +339,10 @@ The following is an overview of some key Vhost API functions: Inject the offloaded interrupt received by the 'guest_notify' callback, into the vhost device's queue. +* ``rte_vhost_driver_set_max_queue_num(const char *path, uint32_t max_queue_pairs)`` + + Set the maximum number of queue pairs supported by the device. + Vhost-user Implementations -------------------------- diff a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst (rejected hunks) @@ -62,6 +62,11 @@ New Features rte_vhost_notify_guest(), is added to raise the interrupt outside of the fast path. +* **Added Vhost API to set maximum queue pairs supported.** + + Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit the + maximum number of supported queue pairs, required for VDUSE support. + Removed Items ------------- diff a/lib/vhost/version.map b/lib/vhost/version.map (rejected hunks) @@ -107,6 +107,7 @@ EXPERIMENTAL { # added in 23.07 rte_vhost_notify_guest; + rte_vhost_driver_set_max_queue_num; }; INTERNAL { Checking patch lib/vhost/meson.build... Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/virtio_net_ctrl.c... Checking patch lib/vhost/virtio_net_ctrl.h... Applied patch lib/vhost/meson.build cleanly. Applied patch lib/vhost/virtio_net_ctrl.c cleanly. Applied patch lib/vhost/virtio_net_ctrl.h cleanly. hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/meson.build... error: lib/vhost/meson.build: does not match index Checking patch lib/vhost/socket.c... error: lib/vhost/socket.c: does not match index Checking patch lib/vhost/vduse.c... Checking patch lib/vhost/vduse.h... Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Applied patch lib/vhost/vduse.c cleanly. Applied patch lib/vhost/vduse.h cleanly. hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch doc/guides/rel_notes/release_23_07.rst... error: while searching for: Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit the maximum number of supported queue pairs, required for VDUSE support. Removed Items ------------- error: patch failed: doc/guides/rel_notes/release_23_07.rst:67 Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index Applying patch doc/guides/rel_notes/release_23_07.rst with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst (rejected hunks) @@ -67,6 +67,13 @@ New Features Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit the maximum number of supported queue pairs, required for VDUSE support. +* **Added VDUSE support into Vhost library.** + + VDUSE aims at implementing vDPA devices in userspace. It can be used as an + alternative to Vhost-user when using Vhost-vDPA, but also enable providing a + virtio-net netdev to the host when using Virtio-vDPA driver. A limitation in + this release is the lack of reconnection support. + Removed Items ------------- https://lab.dpdk.org/results/dashboard/patchsets/26546/ UNH-IOL DPDK Community Lab