From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C97B242C72 for ; Fri, 9 Jun 2023 23:45:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A711C40A84; Fri, 9 Jun 2023 23:45:48 +0200 (CEST) Received: from mail-io1-f97.google.com (mail-io1-f97.google.com [209.85.166.97]) by mails.dpdk.org (Postfix) with ESMTP id 16AF440A84 for ; Fri, 9 Jun 2023 23:45:47 +0200 (CEST) Received: by mail-io1-f97.google.com with SMTP id ca18e2360f4ac-77493b3d18cso104111439f.0 for ; Fri, 09 Jun 2023 14:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686347146; x=1688939146; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=War+Vo9VbylvyehJJWzl/L6k1Ygvmo6q3zO+dWaZnGI=; b=WfxpxmYT2jXp2VeL7flQdo6DmEYp9h92/BnNfZbj4N2h6meFV4+ZnoHmE1X36N7SFP 0UGRJhCNKjZ3XSfnTmaTbykK8nlzUjHH6QBA8hBQl4v3mwIBHO8Z9+vLvPa45tOF2AcE SCdcZDT/r8gWg4f+952VGzzbhvMFgPuvLB6iQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686347146; x=1688939146; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=War+Vo9VbylvyehJJWzl/L6k1Ygvmo6q3zO+dWaZnGI=; b=N5xYjxBTuKobfLY69ANl3ARgc+Rs0sHXXWLt9i1XnBXkXyMFKwFJt5cJt1BfchA4Pb 3gYhpE9DBuYoogeVMWuBfEqmYbwgwfzCDYrw2bu5m20EYh8aZ6DLOtQxTmCC8kUnaYdq cq6JWfpFFT5Z+2FwZ94LUks/FcOAnnaEOsHZ8Sax8k9GdPaQjlSmBtyBApvBh1SBoMlJ z9zhTivMkj2GYgXULBksnAcpXl6v5jAXY9J2cNLp63n3sikMAz4FdOdRC8AdaGt2P4Cu 97c8nzh4FkY1bHxVElhuoIsm2UbWUAw+QHPRT2j0FZPjbQkvfkEEgcWzw9uIqtxic8FH RmKw== X-Gm-Message-State: AC+VfDzv3Tf9aro5KQSG4iTBIebu5hpng4NT9Ua9uaJusSYOkUidgjMj CTLRol3FmJ2xUc/OYyXc17H8FTsqes/rblt58iZK0C5GmFkp+YHjvzciTA== X-Google-Smtp-Source: ACHHUZ69pitkyo3yjWZCNakhMkGc345KQGclvurBcFocmnGMLXNYSOpQXM2bsgF3zssyJDBX5a3ufj//64wW X-Received: by 2002:a6b:e50a:0:b0:775:5f74:f4c7 with SMTP id y10-20020a6be50a000000b007755f74f4c7mr3169908ioc.17.1686347146430; Fri, 09 Jun 2023 14:45:46 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id ep22-20020a0566384e1600b0041f6957b295sm244701jab.58.2023.06.09.14.45.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jun 2023 14:45:46 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Fri, 09 Jun 2023 14:45:46 -0700 (PDT) Message-ID: <64839d8a.050a0220.41a68.4aafSMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.3] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id EEA93605246B; Fri, 9 Jun 2023 17:45:45 -0400 (EDT) Subject: |WARNING| pw128163 [PATCH] net/cnxk: add atomic fc check in poll mode Tx path From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/128163 _apply patch failure_ Submitter: Rahul Bhansali Date: Tuesday, June 06 2023 06:12:49 Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91 Apply patch set 128163 failed: Checking patch drivers/net/cnxk/cn10k_ethdev.c... Checking patch drivers/net/cnxk/cn10k_rxtx.h... Checking patch drivers/net/cnxk/cn10k_tx.h... error: while searching for: if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1174 error: while searching for: if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1323 error: while searching for: handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { NIX_XMIT_FC_OR_RETURN(txq, pkts); scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); /* Reduce the cached count */ txq->fc_cache_pkts -= pkts; } else { scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); error: patch failed: drivers/net/cnxk/cn10k_tx.h:1879 Applied patch drivers/net/cnxk/cn10k_ethdev.c cleanly. Applied patch drivers/net/cnxk/cn10k_rxtx.h cleanly. Applying patch drivers/net/cnxk/cn10k_tx.h with 3 rejects... Hunk #1 applied cleanly. Rejected hunk #2. Rejected hunk #3. Rejected hunk #4. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h (rejected hunks) @@ -1174,11 +1215,9 @@ cn10k_nix_xmit_pkts(void *tx_queue, uint64_t *ws, struct rte_mbuf **tx_pkts, if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); - if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; - } + if (!(flags & NIX_TX_VWQE_F)) + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); + /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); @@ -1323,11 +1362,9 @@ cn10k_nix_xmit_pkts_mseg(void *tx_queue, uint64_t *ws, if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F && txq->tx_compl.ena) handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); - if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; - } + if (!(flags & NIX_TX_VWQE_F)) + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); + /* Get cmd skeleton */ cn10k_nix_tx_skeleton(txq, cmd, flags, !(flags & NIX_TX_VWQE_F)); @@ -1879,11 +1916,9 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_t *ws, handle_tx_completion_pkts(txq, flags & NIX_TX_VWQE_F); if (!(flags & NIX_TX_VWQE_F)) { - NIX_XMIT_FC_OR_RETURN(txq, pkts); scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); - /* Reduce the cached count */ - txq->fc_cache_pkts -= pkts; + NIX_XMIT_FC_CHECK_RETURN(txq, pkts); } else { scalar = pkts & (NIX_DESCS_PER_LOOP - 1); pkts = RTE_ALIGN_FLOOR(pkts, NIX_DESCS_PER_LOOP); https://lab.dpdk.org/results/dashboard/patchsets/26545/ UNH-IOL DPDK Community Lab