From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6969142C72
	for <public@inbox.dpdk.org>; Sat, 10 Jun 2023 00:32:28 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 69C6640A84;
	Sat, 10 Jun 2023 00:32:28 +0200 (CEST)
Received: from mail-pj1-f98.google.com (mail-pj1-f98.google.com
 [209.85.216.98]) by mails.dpdk.org (Postfix) with ESMTP id A879F40A84
 for <test-report@dpdk.org>; Sat, 10 Jun 2023 00:32:23 +0200 (CEST)
Received: by mail-pj1-f98.google.com with SMTP id
 98e67ed59e1d1-25676b4fb78so931334a91.2
 for <test-report@dpdk.org>; Fri, 09 Jun 2023 15:32:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1686349943; x=1688941943;
 h=cc:to:from:subject:message-id:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=aBvELKlWOdIzY+rIgiJzPhAKd9zhjx/nS3QESejuVZc=;
 b=bogL18CvXZi9Sycjra0exANMXfU3mw26ERE7/znDLEEmuoDGYjWKeLauyhxNwosIBq
 JgUaHSWimgEMu31IzKLBRs31hhDE6spN/e69dbqNXWfoZkReZEiwfQIyo4JjIkprCO7I
 YGmW5aWyPDshaXml4Joh1aAZ6KyDgzTGfVdBQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1686349943; x=1688941943;
 h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=aBvELKlWOdIzY+rIgiJzPhAKd9zhjx/nS3QESejuVZc=;
 b=cdxVafymSUQqJFME4NAgc1Bb8A+pxpX9HoWg+VgpuvbmNJ66ZQNBA9U4KdhJEoHbtg
 Qwnp3Tk6hFAp8mQQ7N53kc/3Lzl75l4yH8lXX2srGoczoOiKbib6olKimwst2d2JeaDv
 ZpnV4EMMeMMEOcd4VW21XyC7ji/I/LIddqvHcOJkb/+e7p15fD4b+jEVCGfwJWbB47Pf
 Lvj+bdNthHwONtxRwFAgKBVP19HU8teK4RfXSRP2tJrprkXLzN8Erfq68m723IAtGYwK
 3Rs1s0EmsoPoxODxDB6f7hkBsqlqITOPVLqKpdii3aVr41xKOuf1fcrjc3gJmYw7tDXG
 cRUw==
X-Gm-Message-State: AC+VfDzglCgI8RDwd6bensVZ7gpCL+CWGjrGwOsNaaUAa2aEw5mZfjCp
 OYg/lLPDITzrtaP7CzYdiNvdQzmAc4ghZXweNgv3smMGieXm7UKtfLPzcMkMK867uAWPe5m/7Q=
 =
X-Google-Smtp-Source: ACHHUZ5pC4rSc9TUioMGOORDBHpgKihsqvs7b6yGjkVlVircJGXISe2+Qy+5JaFOjyYdnL+z50B9GDMG/lmO
X-Received: by 2002:a17:90b:46cc:b0:258:c4b5:c6b8 with SMTP id
 jx12-20020a17090b46cc00b00258c4b5c6b8mr2078975pjb.11.1686349942911; 
 Fri, 09 Jun 2023 15:32:22 -0700 (PDT)
Received: from postal.iol.unh.edu (postal.iol.unh.edu.
 [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id
 kb13-20020a17090ae7cd00b0025921d935ecsm485895pjb.13.2023.06.09.15.32.22
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 09 Jun 2023 15:32:22 -0700 (PDT)
X-Relaying-Domain: iol.unh.edu
Date: Fri, 09 Jun 2023 15:32:22 -0700 (PDT)
Message-ID: <6483a876.170a0220.ee9c1.e14dSMTPIN_ADDED_MISSING@mx.google.com>
Received: from [172.17.0.5] (unknown [172.18.0.214])
 by postal.iol.unh.edu (Postfix) with ESMTP id 1F905605246B;
 Fri,  9 Jun 2023 18:32:22 -0400 (EDT)
Subject: |WARNING| pw127872 [PATCH] node: add IPv4 reassembly node
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Content-Type: text/plain
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/127872

_apply patch failure_

Submitter: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Date: Thursday, June 01 2023 19:42:07 
Applied on: CommitID:c9df59bcc9bec67783de98486879594e52bdc418
Apply patch set 127872 failed:

Checking patch doc/guides/prog_guide/graph_lib.rst...
error: while searching for:
the packet out to a particular ethdev_tx node.
``rte_node_ip4_rewrite_add()`` is control path API to add next-hop info.

ip6_lookup
~~~~~~~~~~
This node is an intermediate node that does LPM lookup for the received

error: patch failed: doc/guides/prog_guide/graph_lib.rst:388
Checking patch lib/node/ethdev_rx.c...
Checking patch lib/node/ethdev_rx_priv.h...
Checking patch lib/node/ip4_reassembly.c...
Checking patch lib/node/ip4_reassembly_priv.h...
Checking patch lib/node/meson.build...
error: while searching for:
        'null.c',
        'pkt_cls.c',
        'pkt_drop.c',
)
headers = files('rte_node_ip4_api.h', 'rte_node_ip6_api.h', 'rte_node_eth_api.h')
# Strict-aliasing rules are violated by uint8_t[] to context size casts.
cflags += '-fno-strict-aliasing'
deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev']

error: patch failed: lib/node/meson.build:19
Checking patch lib/node/rte_node_ip4_api.h...
Checking patch lib/node/version.map...
error: while searching for:
	rte_node_eth_config;
	rte_node_ip4_route_add;
	rte_node_ip4_rewrite_add;
	rte_node_ip6_rewrite_add;
	rte_node_ip6_route_add;
	rte_node_logtype;

error: patch failed: lib/node/version.map:4
Applying patch doc/guides/prog_guide/graph_lib.rst with 1 reject...
Rejected hunk #1.
Applied patch lib/node/ethdev_rx.c cleanly.
Applied patch lib/node/ethdev_rx_priv.h cleanly.
Applied patch lib/node/ip4_reassembly.c cleanly.
Applied patch lib/node/ip4_reassembly_priv.h cleanly.
Applying patch lib/node/meson.build with 1 reject...
Rejected hunk #1.
Applied patch lib/node/rte_node_ip4_api.h cleanly.
Applying patch lib/node/version.map with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/doc/guides/prog_guide/graph_lib.rst b/doc/guides/prog_guide/graph_lib.rst	(rejected hunks)
@@ -388,6 +388,14 @@ to determine the L2 header to be written to the packet before sending
 the packet out to a particular ethdev_tx node.
 ``rte_node_ip4_rewrite_add()`` is control path API to add next-hop info.

+ip4_reassembly
+~~~~~~~~~~~~~~
+This node is an intermediate node that reassembles ipv4 fragmented packets,
+non-fragmented packets pass through the node un-effected. The node rewrites
+it's stream and moves it to the next node.
+The fragment table and death row table should be setup via the
+``rte_node_ip4_reassembly_configure`` API.
+
 ip6_lookup
 ~~~~~~~~~~
 This node is an intermediate node that does LPM lookup for the received
diff a/lib/node/meson.build b/lib/node/meson.build	(rejected hunks)
@@ -19,8 +19,9 @@ sources = files(
         'null.c',
         'pkt_cls.c',
         'pkt_drop.c',
+        'ip4_reassembly.c'
 )
 headers = files('rte_node_ip4_api.h', 'rte_node_ip6_api.h', 'rte_node_eth_api.h')
 # Strict-aliasing rules are violated by uint8_t[] to context size casts.
 cflags += '-fno-strict-aliasing'
-deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev']
+deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev', 'ip_frag']
diff a/lib/node/version.map b/lib/node/version.map	(rejected hunks)
@@ -4,6 +4,7 @@ EXPERIMENTAL {
 	rte_node_eth_config;
 	rte_node_ip4_route_add;
 	rte_node_ip4_rewrite_add;
+	rte_node_ip4_reassembly_configure;
 	rte_node_ip6_rewrite_add;
 	rte_node_ip6_route_add;
 	rte_node_logtype;

https://lab.dpdk.org/results/dashboard/patchsets/26493/

UNH-IOL DPDK Community Lab