From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 927C242C60
	for <public@inbox.dpdk.org>; Sat, 10 Jun 2023 20:18:58 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7439F40DD8;
	Sat, 10 Jun 2023 20:18:58 +0200 (CEST)
Received: from mail-pf1-f228.google.com (mail-pf1-f228.google.com
 [209.85.210.228])
 by mails.dpdk.org (Postfix) with ESMTP id 98A5640DD8
 for <test-report@dpdk.org>; Sat, 10 Jun 2023 20:18:57 +0200 (CEST)
Received: by mail-pf1-f228.google.com with SMTP id
 d2e1a72fcca58-653436fcc1bso2524661b3a.2
 for <test-report@dpdk.org>; Sat, 10 Jun 2023 11:18:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=iol.unh.edu; s=unh-iol; t=1686421137; x=1689013137;
 h=cc:to:from:subject:message-id:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=nMomJchI9qYblhMTe8VmrmE4c5gghEhRsM1iu67wGZg=;
 b=i8GoOKg/jMOMltxkeFpYrYFBtuLXCWk+O2GLTRv2URYVXeAsFGPFzGxcJvwCXbZEA5
 7NFJ9OCVdwniAbC7Vd0Eq2Q5vHnrwPoaiwFP6KelbD8hKSJ0iRhTpyJQlPSoOuiXaXkf
 szz0zznPdaxiPxGPXj8IRH+Fo9WNgGYSkUggw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1686421137; x=1689013137;
 h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=nMomJchI9qYblhMTe8VmrmE4c5gghEhRsM1iu67wGZg=;
 b=DxZFkmIgLmXWSuPBumeit4X/o0H0RC900gf3Kl+/hpKq81h1/nuSww79ROfiub9ilG
 LsgXt5huJBEXrMLojFFnLjg3m0kJbRmvw2cZvPDIFz2D4BDnXIKcQIlD9qcTcWFOSdbE
 KHxGWzk/5Qi1ngBkXZ9t0wyojlkg211UjCLNQrVw1izPOUpYscYUJRHYoE46caV0+24+
 T7i8cJUxCsBWTTYS7pp2ois4gw4Wnq4HPBiSG8otFuH+0DBn843+aMy0G4TIVk0oaWmK
 qSwI2STSIA9ILEQgFg217LHGVTyQrYQT6r3bHhW/+YD8lDPQDSUoSgBGc3Xn//0ssKdb
 InRw==
X-Gm-Message-State: AC+VfDw2f/dL1rb7212LAz6jKzflZiGqDeoSW47KD0G638KlBcVULpQI
 e4ByQSZdReT4WEsHh4JW9XCf1rGveUxvXY1sVHtIeIck5P5bixzb6xdU4A6CGeVku1DnFDQDIA=
 =
X-Google-Smtp-Source: ACHHUZ4C23KuAJ7bmBYPq+kCFqbG145RfgaFBRyH+QT2XvOftaE4+f2625DMtYbcqNsbWHwiZVTTBLj9wgMp
X-Received: by 2002:a05:6a00:2296:b0:664:8521:678c with SMTP id
 f22-20020a056a00229600b006648521678cmr1825376pfe.21.1686421136720; 
 Sat, 10 Jun 2023 11:18:56 -0700 (PDT)
Received: from postal.iol.unh.edu (postal.iol.unh.edu.
 [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id
 x18-20020aa79ad2000000b0065f2ef4b637sm526877pfp.14.2023.06.10.11.18.56
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Sat, 10 Jun 2023 11:18:56 -0700 (PDT)
X-Relaying-Domain: iol.unh.edu
Date: Sat, 10 Jun 2023 11:18:56 -0700 (PDT)
Message-ID: <6484be90.a70a0220.3f0dc.d303SMTPIN_ADDED_MISSING@mx.google.com>
Received: from [172.17.0.3] (unknown [172.18.0.34])
 by postal.iol.unh.edu (Postfix) with ESMTP id 6F1B1605246B;
 Sat, 10 Jun 2023 14:18:55 -0400 (EDT)
Subject: |WARNING| pw127978 [PATCH] [v2] node: add IPv4 reassembly node
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Content-Type: text/plain
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/127978

_apply patch failure_

Submitter: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Date: Friday, June 02 2023 16:48:40 
Applied on: CommitID:abaa473297cf21cb81e5348185a7694ae2f221e7
Apply patch set 127978 failed:

Checking patch doc/guides/prog_guide/graph_lib.rst...
error: while searching for:
the packet out to a particular ethdev_tx node.
``rte_node_ip4_rewrite_add()`` is control path API to add next-hop info.

ip6_lookup
~~~~~~~~~~
This node is an intermediate node that does LPM lookup for the received

error: patch failed: doc/guides/prog_guide/graph_lib.rst:388
Checking patch lib/node/ethdev_rx.c...
Checking patch lib/node/ethdev_rx_priv.h...
Checking patch lib/node/ip4_reassembly.c...
Checking patch lib/node/ip4_reassembly_priv.h...
Checking patch lib/node/meson.build...
error: while searching for:
        'null.c',
        'pkt_cls.c',
        'pkt_drop.c',
)
headers = files('rte_node_ip4_api.h', 'rte_node_ip6_api.h', 'rte_node_eth_api.h')
# Strict-aliasing rules are violated by uint8_t[] to context size casts.
cflags += '-fno-strict-aliasing'
deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev']

error: patch failed: lib/node/meson.build:19
Checking patch lib/node/rte_node_ip4_api.h...
Checking patch lib/node/version.map...
error: while searching for:
	rte_node_eth_config;
	rte_node_ip4_route_add;
	rte_node_ip4_rewrite_add;
	rte_node_ip6_rewrite_add;
	rte_node_ip6_route_add;
	rte_node_logtype;

error: patch failed: lib/node/version.map:4
Applying patch doc/guides/prog_guide/graph_lib.rst with 1 reject...
Rejected hunk #1.
Applied patch lib/node/ethdev_rx.c cleanly.
Applied patch lib/node/ethdev_rx_priv.h cleanly.
Applied patch lib/node/ip4_reassembly.c cleanly.
Applied patch lib/node/ip4_reassembly_priv.h cleanly.
Applying patch lib/node/meson.build with 1 reject...
Rejected hunk #1.
Applied patch lib/node/rte_node_ip4_api.h cleanly.
Applying patch lib/node/version.map with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/doc/guides/prog_guide/graph_lib.rst b/doc/guides/prog_guide/graph_lib.rst	(rejected hunks)
@@ -388,6 +388,14 @@ to determine the L2 header to be written to the packet before sending
 the packet out to a particular ethdev_tx node.
 ``rte_node_ip4_rewrite_add()`` is control path API to add next-hop info.

+ip4_reassembly
+~~~~~~~~~~~~~~
+This node is an intermediate node that reassembles ipv4 fragmented packets,
+non-fragmented packets pass through the node un-effected. The node rewrites
+it's stream and moves it to the next node.
+The fragment table and death row table should be setup via the
+``rte_node_ip4_reassembly_configure`` API.
+
 ip6_lookup
 ~~~~~~~~~~
 This node is an intermediate node that does LPM lookup for the received
diff a/lib/node/meson.build b/lib/node/meson.build	(rejected hunks)
@@ -19,8 +19,9 @@ sources = files(
         'null.c',
         'pkt_cls.c',
         'pkt_drop.c',
+        'ip4_reassembly.c'
 )
 headers = files('rte_node_ip4_api.h', 'rte_node_ip6_api.h', 'rte_node_eth_api.h')
 # Strict-aliasing rules are violated by uint8_t[] to context size casts.
 cflags += '-fno-strict-aliasing'
-deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev']
+deps += ['graph', 'mbuf', 'lpm', 'ethdev', 'mempool', 'cryptodev', 'ip_frag']
diff a/lib/node/version.map b/lib/node/version.map	(rejected hunks)
@@ -4,6 +4,7 @@ EXPERIMENTAL {
 	rte_node_eth_config;
 	rte_node_ip4_route_add;
 	rte_node_ip4_rewrite_add;
+	rte_node_ip4_reassembly_configure;
 	rte_node_ip6_rewrite_add;
 	rte_node_ip6_route_add;
 	rte_node_logtype;

https://lab.dpdk.org/results/dashboard/patchsets/26515/

UNH-IOL DPDK Community Lab