From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6B8042C8C for ; Sun, 11 Jun 2023 19:49:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD7E1400D5; Sun, 11 Jun 2023 19:49:43 +0200 (CEST) Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) by mails.dpdk.org (Postfix) with ESMTP id DEB1A400D5 for ; Sun, 11 Jun 2023 19:49:41 +0200 (CEST) Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-25bcedd9575so616159a91.3 for ; Sun, 11 Jun 2023 10:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686505781; x=1689097781; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=efjK7QQ+QaPp9cW7Vlxevq3U7w0/xxaRyWw+WXTa7zM=; b=fuTG8iAJTfJ3D7MBnigaIdt33r1CWpOMeCwUUtavvjiEQ4TEZaUMxMfv4b60tZ3gQC RtDgNA9u689Atg5iH7jqnHePoVf+PieL7zDm0cBND+JIlO3RNmzaX7tZTYk1tSr3tzZ5 r9AjfRmixpFCiykOuTN+NPfZH9YYfiTNe7PPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686505781; x=1689097781; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=efjK7QQ+QaPp9cW7Vlxevq3U7w0/xxaRyWw+WXTa7zM=; b=Q9LHIG3tvf9mR+m7xAMSKjuSZbv4miP23TZ+f0G0GqL/vDXGIIH5MfIQwPSaPnOrCb O7SISkGSWNR1OwVWljeZCd2FBkZb7+i89IalwT/SLlw6lwYF6grX2vUWOXaPNt3pEDzC 5+nVrmjvGK/iQltBZulEEqEmww6ykWrNJAB/r4LJCWd6r8GfmE4zOrqjWR7p0uO5AwnO DNk6u0E0QyWzDf+CIJQYXq3izJjKz0F09FdbYBBmFqcdzJmA/LV531fWKd2iDBpgpF0o P6fu6YgRi1gLvcnqwlvJcYwza7Ol0zboOg6Sst86pFA4VK4BNWrFRo2aidc8d7+7fLHa 8O5A== X-Gm-Message-State: AC+VfDyvRNFv1P97vdbRiWKY/ZEQHcjGx0ETsiTM/U1T+P6LgbBzW2g/ lYrIh9UVm0wTDcHQklzSTG1vw6qY/SyJee/bEf6d2LzChesW+yDJtfZkkQ== X-Google-Smtp-Source: ACHHUZ4AsWRzfqE3LciRZatS8sLFjGXomF9siYJ8r9TjzeNh6SToOT8pB7s61iQMSOijVNjV0EWkDajSCqHJ X-Received: by 2002:a17:90a:65c3:b0:247:6ead:d0ed with SMTP id i3-20020a17090a65c300b002476eadd0edmr6788081pjs.28.1686505781014; Sun, 11 Jun 2023 10:49:41 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id n11-20020a17090a4e0b00b00250b5ffafcesm804813pjh.9.2023.06.11.10.49.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Jun 2023 10:49:41 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Sun, 11 Jun 2023 10:49:41 -0700 (PDT) Message-ID: <64860935.170a0220.a95ef.2692SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id 28A56605246B; Sun, 11 Jun 2023 13:49:40 -0400 (EDT) Subject: |WARNING| pw127803-127805 [PATCH] [3/3] net/sfc: support VLAN stripping offload From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/127803 _apply patch failure_ Submitter: Artemii Morozov Date: Wednesday, May 31 2023 13:41:22 Applied on: CommitID:c9df59bcc9bec67783de98486879594e52bdc418 Apply patch set 127803-127805 failed: Checking patch drivers/common/sfc_efx/base/ef10_nic.c... Hunk #1 succeeded at 1227 (offset -89 lines). Checking patch drivers/common/sfc_efx/base/efx.h... Hunk #1 succeeded at 1638 (offset -12 lines). Checking patch drivers/common/sfc_efx/base/siena_nic.c... error: while searching for: encp->enc_rx_include_fcs_supported = B_FALSE; encp->enc_rx_es_super_buffer_supported = B_FALSE; encp->enc_fw_subvariant_no_tx_csum_supported = B_FALSE; /* Siena supports two 10G ports, and 8 lanes of PCIe Gen2 */ encp->enc_required_pcie_bandwidth_mbps = 2 * 10000; error: patch failed: drivers/common/sfc_efx/base/siena_nic.c:190 Applied patch drivers/common/sfc_efx/base/ef10_nic.c cleanly. Applied patch drivers/common/sfc_efx/base/efx.h cleanly. Applying patch drivers/common/sfc_efx/base/siena_nic.c with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/common/sfc_efx/base/siena_nic.c b/drivers/common/sfc_efx/base/siena_nic.c (rejected hunks) @@ -190,6 +190,7 @@ siena_board_cfg( encp->enc_rx_include_fcs_supported = B_FALSE; encp->enc_rx_es_super_buffer_supported = B_FALSE; encp->enc_fw_subvariant_no_tx_csum_supported = B_FALSE; + encp->enc_rx_vlan_stripping = B_FALSE; /* Siena supports two 10G ports, and 8 lanes of PCIe Gen2 */ encp->enc_required_pcie_bandwidth_mbps = 2 * 10000; Checking patch drivers/common/sfc_efx/base/ef10_filter.c... error: while searching for: FILTER_OP_V3_IN_MATCH_SET_FLAG, 1); } efx_mcdi_execute(enp, &req); if (req.emr_rc != 0) { error: patch failed: drivers/common/sfc_efx/base/ef10_filter.c:338 Hunk #2 succeeded at 852 (offset -5 lines). Hunk #3 succeeded at 2020 (offset -5 lines). Hunk #4 succeeded at 2155 (offset -5 lines). Hunk #5 succeeded at 2168 (offset -5 lines). Checking patch drivers/common/sfc_efx/base/ef10_impl.h... Checking patch drivers/common/sfc_efx/base/efx.h... error: drivers/common/sfc_efx/base/efx.h: does not match index Checking patch drivers/common/sfc_efx/base/efx_filter.c... Checking patch drivers/common/sfc_efx/base/efx_impl.h... Hunk #1 succeeded at 1045 (offset -1 lines). Checking patch drivers/common/sfc_efx/base/efx_rx.c... error: while searching for: } } enp->en_rx_qcount++; *erpp = erp; return (0); fail5: EFSYS_PROBE(fail5); error: patch failed: drivers/common/sfc_efx/base/efx_rx.c:943 Checking patch drivers/common/sfc_efx/base/rhead_rx.c... Applying patch drivers/common/sfc_efx/base/ef10_filter.c with 1 reject... Rejected hunk #1. Hunk #2 applied cleanly. Hunk #3 applied cleanly. Hunk #4 applied cleanly. Hunk #5 applied cleanly. Applied patch drivers/common/sfc_efx/base/ef10_impl.h cleanly. Applied patch drivers/common/sfc_efx/base/efx_filter.c cleanly. Applied patch drivers/common/sfc_efx/base/efx_impl.h cleanly. Applying patch drivers/common/sfc_efx/base/efx_rx.c with 1 reject... Hunk #1 applied cleanly. Rejected hunk #2. Applied patch drivers/common/sfc_efx/base/rhead_rx.c cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/common/sfc_efx/base/ef10_filter.c b/drivers/common/sfc_efx/base/ef10_filter.c (rejected hunks) @@ -338,6 +338,11 @@ efx_mcdi_filter_op_add( FILTER_OP_V3_IN_MATCH_SET_FLAG, 1); } + if (spec->efs_flags & EFX_FILTER_FLAG_VLAN_STRIP) { + MCDI_IN_SET_DWORD_FIELD(req, FILTER_OP_V3_IN_MATCH_ACTION_FLAGS, + FILTER_OP_V3_IN_MATCH_STRIP_VLAN, 1); + } + efx_mcdi_execute(enp, &req); if (req.emr_rc != 0) { diff a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c (rejected hunks) @@ -943,11 +944,27 @@ efx_rx_qcreate_internal( } } + if (flags & EFX_RXQ_FLAG_VLAN_STRIP) { + const efx_rx_prefix_layout_t *erplp = &erp->er_prefix_layout; + const efx_rx_prefix_field_info_t *vlan_tci_field; + + vlan_tci_field = + &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI]; + if (vlan_tci_field->erpfi_width_bits == 0) { + rc = ENOTSUP; + goto fail6; + } + + erp->er_flags |= EFX_RXQ_FLAG_VLAN_STRIP; + } + enp->en_rx_qcount++; *erpp = erp; return (0); +fail6: + EFSYS_PROBE(fail6); fail5: EFSYS_PROBE(fail5); Checking patch doc/guides/nics/sfc_efx.rst... Hunk #1 succeeded at 118 (offset 38 lines). Hunk #2 succeeded at 134 (offset 40 lines). Checking patch drivers/net/sfc/sfc_ef100_rx.c... Checking patch drivers/net/sfc/sfc_rx.c... error: while searching for: if (encp->enc_rx_include_fcs_supported == 0) no_caps |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; return ~no_caps; } error: patch failed: drivers/net/sfc/sfc_rx.c:942 Hunk #2 succeeded at 1186 (offset -7 lines). Hunk #3 succeeded at 1698 (offset -7 lines). Applied patch doc/guides/nics/sfc_efx.rst cleanly. Applied patch drivers/net/sfc/sfc_ef100_rx.c cleanly. Applying patch drivers/net/sfc/sfc_rx.c with 1 reject... Rejected hunk #1. Hunk #2 applied cleanly. Hunk #3 applied cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c (rejected hunks) @@ -942,6 +942,9 @@ sfc_rx_get_offload_mask(struct sfc_adapter *sa) if (encp->enc_rx_include_fcs_supported == 0) no_caps |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; + if (encp->enc_rx_vlan_stripping == 0) + no_caps |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP; + return ~no_caps; } https://lab.dpdk.org/results/dashboard/patchsets/26474/ UNH-IOL DPDK Community Lab