From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84ED442C8D for ; Sun, 11 Jun 2023 20:03:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5833E400D5; Sun, 11 Jun 2023 20:03:31 +0200 (CEST) Received: from mail-vk1-f225.google.com (mail-vk1-f225.google.com [209.85.221.225]) by mails.dpdk.org (Postfix) with ESMTP id 5CD01400D5 for ; Sun, 11 Jun 2023 20:03:30 +0200 (CEST) Received: by mail-vk1-f225.google.com with SMTP id 71dfb90a1353d-45d3e523a43so1407061e0c.2 for ; Sun, 11 Jun 2023 11:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686506609; x=1689098609; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=efjK7QQ+QaPp9cW7Vlxevq3U7w0/xxaRyWw+WXTa7zM=; b=KPHQUxA6yfeVIWx245oE2ayKnGH2jUp5HcCBF3QZHaRG4dfReY0dL0V0Dm32Hx3bQh 58AkhFT+gtDzqfZ6rw68Me9JBQtnfJCU9CNbvqCeJRbSoPZ872xCr/dmWRTCj5fswJ6b G/Co58LpHzR39iOjE9TdUU83oAHwKU5fTAwvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686506609; x=1689098609; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=efjK7QQ+QaPp9cW7Vlxevq3U7w0/xxaRyWw+WXTa7zM=; b=koTDYOQYMQ1j5JR0OLXR3B2eyGPXpBWcnlMNTXW0unTthfFG1DVNdGlz7Md1LrjdPI 0mV8zHaCo2a4Y6oNzKQ4eGG5+MBqeBRZaprHJQgzEFzr3xbwx+MYI5OVc21VkAYGT4Cs 6iL/vWbuVzVRAK6WF52S9bzQai4P7mD0B5Gd+I/2ntGoeqkaI6GjbQ2d5f4UjkahcCiD idVo8MXFCFjqGb/G4SrP4Bpr8MReEN7thT6uGp7WN35uraPT4qiAqmlFJXER3f6TC4Bh G5Lv8D/O4e+v2FtayK7+kCfso9oaDuv0txqLraVFxz96XXCnNs6Gczm/mN0YSKwdnQFM xSIA== X-Gm-Message-State: AC+VfDxSXHi26Oh+TpwrF1jce5vKguQdYACfkq90A3bsRh4s4AGgXP58 eoI/dJr1P+O6G8OEacsmZQHRPAr2dxT9GzqRczdxafPxj1hIkqdokC4WiweTDbdGsIV3HeRgPg= = X-Google-Smtp-Source: ACHHUZ67mA2snBsf6IZMCrL2Qx8gmpLpNCGRpLDxS/XLszpaCvm4ajxXEMToQEXGfZD1q2LtP1a1+B7Fdqby X-Received: by 2002:a1f:d405:0:b0:464:cd5c:b37e with SMTP id l5-20020a1fd405000000b00464cd5cb37emr3727492vkg.0.1686506609662; Sun, 11 Jun 2023 11:03:29 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id cl8-20020a056122250800b00465e23f0da0sm940407vkb.6.2023.06.11.11.03.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Jun 2023 11:03:29 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Sun, 11 Jun 2023 11:03:29 -0700 (PDT) Message-ID: <64860c71.050a0220.9f12a.8237SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.3] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id E0FE1605246B; Sun, 11 Jun 2023 14:03:28 -0400 (EDT) Subject: |WARNING| pw127803-127805 [PATCH] [3/3] net/sfc: support VLAN stripping offload From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/127803 _apply patch failure_ Submitter: Artemii Morozov Date: Wednesday, May 31 2023 13:41:22 Applied on: CommitID:c9df59bcc9bec67783de98486879594e52bdc418 Apply patch set 127803-127805 failed: Checking patch drivers/common/sfc_efx/base/ef10_nic.c... Hunk #1 succeeded at 1227 (offset -89 lines). Checking patch drivers/common/sfc_efx/base/efx.h... Hunk #1 succeeded at 1638 (offset -12 lines). Checking patch drivers/common/sfc_efx/base/siena_nic.c... error: while searching for: encp->enc_rx_include_fcs_supported = B_FALSE; encp->enc_rx_es_super_buffer_supported = B_FALSE; encp->enc_fw_subvariant_no_tx_csum_supported = B_FALSE; /* Siena supports two 10G ports, and 8 lanes of PCIe Gen2 */ encp->enc_required_pcie_bandwidth_mbps = 2 * 10000; error: patch failed: drivers/common/sfc_efx/base/siena_nic.c:190 Applied patch drivers/common/sfc_efx/base/ef10_nic.c cleanly. Applied patch drivers/common/sfc_efx/base/efx.h cleanly. Applying patch drivers/common/sfc_efx/base/siena_nic.c with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/common/sfc_efx/base/siena_nic.c b/drivers/common/sfc_efx/base/siena_nic.c (rejected hunks) @@ -190,6 +190,7 @@ siena_board_cfg( encp->enc_rx_include_fcs_supported = B_FALSE; encp->enc_rx_es_super_buffer_supported = B_FALSE; encp->enc_fw_subvariant_no_tx_csum_supported = B_FALSE; + encp->enc_rx_vlan_stripping = B_FALSE; /* Siena supports two 10G ports, and 8 lanes of PCIe Gen2 */ encp->enc_required_pcie_bandwidth_mbps = 2 * 10000; Checking patch drivers/common/sfc_efx/base/ef10_filter.c... error: while searching for: FILTER_OP_V3_IN_MATCH_SET_FLAG, 1); } efx_mcdi_execute(enp, &req); if (req.emr_rc != 0) { error: patch failed: drivers/common/sfc_efx/base/ef10_filter.c:338 Hunk #2 succeeded at 852 (offset -5 lines). Hunk #3 succeeded at 2020 (offset -5 lines). Hunk #4 succeeded at 2155 (offset -5 lines). Hunk #5 succeeded at 2168 (offset -5 lines). Checking patch drivers/common/sfc_efx/base/ef10_impl.h... Checking patch drivers/common/sfc_efx/base/efx.h... error: drivers/common/sfc_efx/base/efx.h: does not match index Checking patch drivers/common/sfc_efx/base/efx_filter.c... Checking patch drivers/common/sfc_efx/base/efx_impl.h... Hunk #1 succeeded at 1045 (offset -1 lines). Checking patch drivers/common/sfc_efx/base/efx_rx.c... error: while searching for: } } enp->en_rx_qcount++; *erpp = erp; return (0); fail5: EFSYS_PROBE(fail5); error: patch failed: drivers/common/sfc_efx/base/efx_rx.c:943 Checking patch drivers/common/sfc_efx/base/rhead_rx.c... Applying patch drivers/common/sfc_efx/base/ef10_filter.c with 1 reject... Rejected hunk #1. Hunk #2 applied cleanly. Hunk #3 applied cleanly. Hunk #4 applied cleanly. Hunk #5 applied cleanly. Applied patch drivers/common/sfc_efx/base/ef10_impl.h cleanly. Applied patch drivers/common/sfc_efx/base/efx_filter.c cleanly. Applied patch drivers/common/sfc_efx/base/efx_impl.h cleanly. Applying patch drivers/common/sfc_efx/base/efx_rx.c with 1 reject... Hunk #1 applied cleanly. Rejected hunk #2. Applied patch drivers/common/sfc_efx/base/rhead_rx.c cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/common/sfc_efx/base/ef10_filter.c b/drivers/common/sfc_efx/base/ef10_filter.c (rejected hunks) @@ -338,6 +338,11 @@ efx_mcdi_filter_op_add( FILTER_OP_V3_IN_MATCH_SET_FLAG, 1); } + if (spec->efs_flags & EFX_FILTER_FLAG_VLAN_STRIP) { + MCDI_IN_SET_DWORD_FIELD(req, FILTER_OP_V3_IN_MATCH_ACTION_FLAGS, + FILTER_OP_V3_IN_MATCH_STRIP_VLAN, 1); + } + efx_mcdi_execute(enp, &req); if (req.emr_rc != 0) { diff a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c (rejected hunks) @@ -943,11 +944,27 @@ efx_rx_qcreate_internal( } } + if (flags & EFX_RXQ_FLAG_VLAN_STRIP) { + const efx_rx_prefix_layout_t *erplp = &erp->er_prefix_layout; + const efx_rx_prefix_field_info_t *vlan_tci_field; + + vlan_tci_field = + &erplp->erpl_fields[EFX_RX_PREFIX_FIELD_VLAN_STRIP_TCI]; + if (vlan_tci_field->erpfi_width_bits == 0) { + rc = ENOTSUP; + goto fail6; + } + + erp->er_flags |= EFX_RXQ_FLAG_VLAN_STRIP; + } + enp->en_rx_qcount++; *erpp = erp; return (0); +fail6: + EFSYS_PROBE(fail6); fail5: EFSYS_PROBE(fail5); Checking patch doc/guides/nics/sfc_efx.rst... Hunk #1 succeeded at 118 (offset 38 lines). Hunk #2 succeeded at 134 (offset 40 lines). Checking patch drivers/net/sfc/sfc_ef100_rx.c... Checking patch drivers/net/sfc/sfc_rx.c... error: while searching for: if (encp->enc_rx_include_fcs_supported == 0) no_caps |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; return ~no_caps; } error: patch failed: drivers/net/sfc/sfc_rx.c:942 Hunk #2 succeeded at 1186 (offset -7 lines). Hunk #3 succeeded at 1698 (offset -7 lines). Applied patch doc/guides/nics/sfc_efx.rst cleanly. Applied patch drivers/net/sfc/sfc_ef100_rx.c cleanly. Applying patch drivers/net/sfc/sfc_rx.c with 1 reject... Rejected hunk #1. Hunk #2 applied cleanly. Hunk #3 applied cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c (rejected hunks) @@ -942,6 +942,9 @@ sfc_rx_get_offload_mask(struct sfc_adapter *sa) if (encp->enc_rx_include_fcs_supported == 0) no_caps |= RTE_ETH_RX_OFFLOAD_KEEP_CRC; + if (encp->enc_rx_vlan_stripping == 0) + no_caps |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP; + return ~no_caps; } https://lab.dpdk.org/results/dashboard/patchsets/26474/ UNH-IOL DPDK Community Lab