|WARNING| pw155017 [PATCH] ntb/ae4dma: added Amd userspace DMA and NTB drivers

automatic DPDK test reports
 help / color / mirror / Atom feed

* |WARNING| pw155017 [PATCH] ntb/ae4dma: added Amd userspace DMA and NTB drivers
       [not found] <20250705141001.34223-1-bhagyada.modali@amd.com>
@ 2025-07-05 13:40 ` qemudev
  2025-07-05 14:10 ` checkpatch
  2025-07-05 14:31 ` dpdklab
  2 siblings, 0 replies; 3+ messages in thread
From: qemudev @ 2025-07-05 13:40 UTC (permalink / raw)
  To: test-report; +Cc: Bhagyada Modali, zhoumin

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/155017

_apply patch failure_

Submitter: Bhagyada Modali <bhagyada.modali@amd.com>
Date: Sat, 5 Jul 2025 19:40:01 +0530
DPDK git baseline: Repo:dpdk
  Branch: main
  CommitID: 70c2297528e7c7789af452f78de1932e9a20c8a2

Apply patch set 155017 failed:

/home/zhoumin/dpdk-ci/tools/../series/35647/155017.patch:3291: trailing whitespace.
	
Checking patch app/test-dma-perf/benchmark.c...
Checking patch app/test-dma-perf/config.ini...
Checking patch app/test-dma-perf/main.c...
Checking patch app/test/test_dmadev.c...
Hunk #15 succeeded at 653 (offset 3 lines).
Hunk #16 succeeded at 903 (offset 3 lines).
Hunk #17 succeeded at 1182 (offset 3 lines).
Hunk #18 succeeded at 1232 (offset 3 lines).
Hunk #19 succeeded at 1267 (offset 3 lines).
Hunk #20 succeeded at 1340 (offset 3 lines).
Checking patch drivers/dma/ae4dma/ae4dma_dmadev.c...
Checking patch drivers/dma/ae4dma/ae4dma_hw_defs.h...
Checking patch drivers/dma/ae4dma/ae4dma_internal.h...
Checking patch drivers/dma/ae4dma/meson.build...
Checking patch drivers/dma/meson.build...
Checking patch drivers/raw/ntb/meson.build...
Checking patch drivers/raw/ntb/ntb.c...
Checking patch drivers/raw/ntb/ntb.h...
Checking patch drivers/raw/ntb/ntb_hw_amd.c...
/home/zhoumin/dpdk-ci/tools/../series/35647/155017.patch:3143: new blank line at EOF.
+
Checking patch drivers/raw/ntb/ntb_hw_amd.h...
Checking patch drivers/raw/ntb/ntb_hw_intel.c...
Hunk #1 succeeded at 612 (offset -1 lines).
Hunk #2 succeeded at 647 (offset -1 lines).
Checking patch drivers/raw/ntb/rte_pmd_ntb.h...
Checking patch examples/ntb/commands.list...
Checking patch examples/ntb/ntb_fwd.c...
Checking patch usertools/dpdk-devbind.py...
Hunk #1 succeeded at 72 (offset 6 lines).
Hunk #2 succeeded at 86 (offset 6 lines).
error: while searching for:
network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
baseband_devices = [acceleration_class]
crypto_devices = [encryption_class, intel_processor_class]
dma_devices = [cnxk_dma, hisilicon_dma,
               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
               odm_dma]
eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, cnxk_sso]

error: patch failed: usertools/dpdk-devbind.py:83
error: usertools/dpdk-devbind.py: patch does not apply


^ permalink raw reply	[flat|nested] 3+ messages in thread

* |WARNING| pw155017 [PATCH] ntb/ae4dma: added Amd userspace DMA and NTB drivers
       [not found] <20250705141001.34223-1-bhagyada.modali@amd.com>
  2025-07-05 13:40 ` |WARNING| pw155017 [PATCH] ntb/ae4dma: added Amd userspace DMA and NTB drivers qemudev
@ 2025-07-05 14:10 ` checkpatch
  2025-07-05 14:31 ` dpdklab
  2 siblings, 0 replies; 3+ messages in thread
From: checkpatch @ 2025-07-05 14:10 UTC (permalink / raw)
  To: test-report; +Cc: Bhagyada Modali

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 18780 bytes --]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155017

_coding style issues_


ERROR:C99_COMMENTS: do not use C99 // comments
#216: FILE: app/test-dma-perf/benchmark.c:332:
+				rte_mbuf_data_iova(dsts[i]), buf_size, 0);//

ERROR:C99_COMMENTS: do not use C99 // comments
#479: FILE: app/test/test_dmadev.c:24:
+//#define TEST_RINGSIZE 512

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#551: FILE: app/test/test_dmadev.c:263:
+/*		else
+			printf("Data MATCHED! at char %u [ %02x == %02x]
", i,

ERROR:GLOBAL_INITIALISERS: do not initialise globals to 0
#696: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:15:
+int hwq_id = 0;

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#737: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:56:
+ /*       AE4DMA_PMD_INFO("Allocate memzone for %s, size %u on socket %u",
+			queue_name, queue_size, socket_id);

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#845: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:164:
+	cmd_q->stats.submitted += (uint16_t)(cmd_q->next_write - cmd_q->last_write + AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#845: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:164:
+	cmd_q->stats.submitted += (uint16_t)(cmd_q->next_write - cmd_q->last_write + AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:LONG_LINE: line length of 146 exceeds 100 columns
#845: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:164:
+	cmd_q->stats.submitted += (uint16_t)(cmd_q->next_write - cmd_q->last_write + AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#896: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:215:
+	cmd_q->next_write = (write + 1) % (AE4DMA_DESCRITPTORS_PER_CMDQ);

WARNING:LONG_LINE: line length of 134 exceeds 100 columns
#932: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:251:
+	fprintf(f, "queues per ae4dma engine     = %d
", AE4DMA_READ_REG_OFFSET(ae4dma_mmio_base_addr, AE4DMA_COMMON_CONFIG_OFFSET));

WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#935: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:254:
+	fprintf(f, "  Ring IOVA: %#lx	%#lx	%#lx
", cmd_q->qbase_desc, cmd_q->qbase_addr, cmd_q->qbase_phys_addr);

ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - uint16_t *get_static_ptr() should probably be uint16_t *get_static_ptr(void)
#977: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:296:
+static inline uint16_t *get_static_ptr()

ERROR:INITIALISED_STATIC: do not initialise statics to NULL
#979: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:298:
+	static uint16_t *ptr = NULL;

WARNING:TYPO_SPELLING: 'failes' may be misspelled - perhaps 'fails'?
#992: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:311:
+ *   The  number of operations that  completed - both success and failes

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#1023: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:342:
+					AE4DMA_PMD_WARN("WARNING:Desc error code : %d
", hw_desc->dw1.err_code);

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1031: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:350:
+				tail = (tail + 1) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:TYPO_SPELLING: 'successfull' may be misspelled - perhaps 'successful'?
#1048: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:367:
+/* Returns successfull operations count and sets error flag if any errors. */

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1067: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:386:
+		*last_idx = (cmd_q->next_read - 1 + AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1067: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:386:
+		*last_idx = (cmd_q->next_read - 1 + AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#1067: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:386:
+		*last_idx = (cmd_q->next_read - 1 + AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1096: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:415:
+		*last_idx = (cmd_q->next_read-1+AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1096: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:415:
+		*last_idx = (cmd_q->next_read-1+AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#1096: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:415:
+		*last_idx = (cmd_q->next_read-1+AE4DMA_DESCRITPTORS_PER_CMDQ) % AE4DMA_DESCRITPTORS_PER_CMDQ;

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1228: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:547:
+	AE4DMA_WRITE_REG(&cmd_q->hwq_regs->max_idx, AE4DMA_DESCRITPTORS_PER_CMDQ);

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#1286: FILE: drivers/dma/ae4dma/ae4dma_dmadev.c:605:
+	dmadev = rte_dma_pmd_allocate(hwq_dev_name, dev->device.numa_node, sizeof(struct ae4dma_dmadev));

WARNING:TYPO_SPELLING: 'MEMEORY' may be misspelled - perhaps 'MEMORY'?
#1538: FILE: drivers/dma/ae4dma/ae4dma_hw_defs.h:147:
+#define AE4DMA_DWORD0_SOURCE_MEMEORY_TYPE   GENMASK(7, 6)

WARNING:TYPO_SPELLING: 'MEMEORY' may be misspelled - perhaps 'MEMORY'?
#1542: FILE: drivers/dma/ae4dma/ae4dma_hw_defs.h:151:
+#define AE4DMA_DWORD0_SOURCE_MEMEORY_TYPE_MEMORY    0x0

WARNING:TYPO_SPELLING: 'MEMEORY' may be misspelled - perhaps 'MEMORY'?
#1543: FILE: drivers/dma/ae4dma/ae4dma_hw_defs.h:152:
+#define AE4DMA_DWORD0_SOURCE_MEMEORY_TYPE_IOMEMORY  (1<<6)

WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns
#1586: FILE: drivers/dma/ae4dma/ae4dma_hw_defs.h:195:
+			uint32_t queue_status: 2; /* 0–empty, 1–full, 2–stopped, 3–error , 4–Not Empty */

ERROR:C99_COMMENTS: do not use C99 // comments
#1630: FILE: drivers/dma/ae4dma/ae4dma_internal.h:10:
+//#ifdef STRUCT_DEFINED_REGS

ERROR:C99_COMMENTS: do not use C99 // comments
#1632: FILE: drivers/dma/ae4dma/ae4dma_internal.h:12:
+//#endif

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1647: FILE: drivers/dma/ae4dma/ae4dma_internal.h:27:
+#define AE4DMA_DESCRITPTORS_PER_CMDQ 32

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1649: FILE: drivers/dma/ae4dma/ae4dma_internal.h:29:
+#define AE4DMA_QUEUE_SIZE(n)  (AE4DMA_DESCRITPTORS_PER_CMDQ * (n))

WARNING:TYPO_SPELLING: 'DESCRITPTORS' may be misspelled - perhaps 'DESCRIPTORS'?
#1711: FILE: drivers/dma/ae4dma/ae4dma_internal.h:91:
+	enum ae4dma_dma_err status[AE4DMA_DESCRITPTORS_PER_CMDQ];

ERROR:C99_COMMENTS: do not use C99 // comments
#1733: FILE: drivers/dma/ae4dma/ae4dma_internal.h:113:
+//	struct rte_dma_vchan_conf qcfg;

ERROR:C99_COMMENTS: do not use C99 // comments
#1740: FILE: drivers/dma/ae4dma/ae4dma_internal.h:120:
+//	struct ae4dma_cmd_queue cmd_q[AE4DMA_MAX_HW_QUEUES]; /**< ae4dma queue */

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#1819: FILE: drivers/raw/ntb/ntb.c:90:
+	if ((hw->pci_dev->id.device_id ==  NTB_AMD_DEV_ID_PRI) || (hw->pci_dev->id.device_id == NTB_AMD_DEV_ID_SEC)) {

WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#1869: FILE: drivers/raw/ntb/ntb.c:121:
+			NTB_LOG(INFO, "after spad_write SPAD_USED_MWS hw->used_mw_num %d", hw->used_mw_num);

WARNING:LONG_LINE: line length of 137 exceeds 100 columns
#1879: FILE: drivers/raw/ntb/ntb.c:131:
+			NTB_LOG(INFO, "after spad_write SPAD_MW0_BA_H SPAD_MW0_BA_H + 2 * i 0x%x, val 0x%x", SPAD_MW0_BA_H + 2 * i, val);

WARNING:LONG_LINE: line length of 137 exceeds 100 columns
#1885: FILE: drivers/raw/ntb/ntb.c:137:
+			NTB_LOG(INFO, "after spad_write SPAD_MW0_BA_L SPAD_MW0_BA_L + 2 * i 0x%x, val 0x%x", SPAD_MW0_BA_L + 2 * i, val);

WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#1989: FILE: drivers/raw/ntb/ntb.c:208:
+	if ((hw->pci_dev->id.device_id ==  NTB_AMD_DEV_ID_PRI) || (hw->pci_dev->id.device_id == NTB_AMD_DEV_ID_SEC)) {

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#2049: FILE: drivers/raw/ntb/ntb.c:252:
+			 * * * */

WARNING:LONG_LINE: line length of 134 exceeds 100 columns
#2061: FILE: drivers/raw/ntb/ntb.c:264:
+				NTB_LOG(ERR, "Both mw cnt must be the same. peer_mw_cnt %d  hw->mw_cnt %d ", peer_mw_cnt, hw->mw_cnt);

WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#2168: FILE: drivers/raw/ntb/ntb.c:522:
+	if (!((hw->pci_dev->id.device_id ==  NTB_AMD_DEV_ID_PRI) || (hw->pci_dev->id.device_id == NTB_AMD_DEV_ID_SEC))) {

WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2250: FILE: drivers/raw/ntb/ntb.c:1025:
+	if (!((hw->pci_dev->id.device_id ==  NTB_AMD_DEV_ID_PRI) ||  (hw->pci_dev->id.device_id == NTB_AMD_DEV_ID_SEC))) {

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#2410: FILE: drivers/raw/ntb/ntb_hw_amd.c:6:
+#include <stdio.h>

ERROR:C99_COMMENTS: do not use C99 // comments
#2455: FILE: drivers/raw/ntb/ntb_hw_amd.c:51:
+	// Bit 0 of link status register

WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2464: FILE: drivers/raw/ntb/ntb_hw_amd.c:60:
+	NTB_LOG(INFO, "dev_init() - amd_hw-> self_mmio 0x%x amd_hw->peermmio 0x%x", amd_hw->self_mmio, amd_hw->peer_mmio);

ERROR:C99_COMMENTS: do not use C99 // comments
#2466: FILE: drivers/raw/ntb/ntb_hw_amd.c:62:
+	// memory window, door bell, scratcpad count

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2480: FILE: drivers/raw/ntb/ntb_hw_amd.c:76:
+		NTB_LOG(INFO, "dev_init() - bar %d ntb->mw_size[%d] - 0x%x ", bar, i, ntb->mw_size[i]);

ERROR:C99_COMMENTS: do not use C99 // comments
#2483: FILE: drivers/raw/ntb/ntb_hw_amd.c:79:
+	// splitting the scratchpad registers to half and assign it to each side

ERROR:C99_COMMENTS: do not use C99 // comments
#2485: FILE: drivers/raw/ntb/ntb_hw_amd.c:81:
+//	ntb->spad_cnt >>= 1;   //// commenting for now.

ERROR:C99_COMMENTS: do not use C99 // comments
#2494: FILE: drivers/raw/ntb/ntb_hw_amd.c:90:
+	// Reserve the last 2 spad registers for users.

ERROR:C99_COMMENTS: do not use C99 // comments
#2504: FILE: drivers/raw/ntb/ntb_hw_amd.c:100:
+// Memory window address - particular bar

ERROR:C99_COMMENTS: do not use C99 // comments
#2537: FILE: drivers/raw/ntb/ntb_hw_amd.c:133:
+// Setting the registers with memory window details (start addresses and sizes)

WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#2674: FILE: drivers/raw/ntb/ntb_hw_amd.c:270:
+						pdev->addr.domain, pdev->addr.bus, pdev->addr.devid, pdev->addr.function);

ERROR:C99_COMMENTS: do not use C99 // comments
#2712: FILE: drivers/raw/ntb/ntb_hw_amd.c:308:
+// Find PCIe capability offset

ERROR:C99_COMMENTS: do not use C99 // comments
#2891: FILE: drivers/raw/ntb/ntb_hw_amd.c:487:
+		// AMD_SIDE_READY is a read-only register which tells topology (prim\secondary)

WARNING:TYPO_SPELLING: 'registed' may be misspelled - perhaps 'registered'?
#2905: FILE: drivers/raw/ntb/ntb_hw_amd.c:501:
+// scratch pad registed read

ERROR:C99_COMMENTS: do not use C99 // comments
#2905: FILE: drivers/raw/ntb/ntb_hw_amd.c:501:
+// scratch pad registed read

ERROR:C99_COMMENTS: do not use C99 // comments
#2928: FILE: drivers/raw/ntb/ntb_hw_amd.c:524:
+//scratchpad register write

WARNING:LONG_LINE: line length of 131 exceeds 100 columns
#3038: FILE: drivers/raw/ntb/ntb_hw_amd.c:634:
+			NTB_LOG(ERR, "Both mw cnt must be the same peer_mw_cnt %d,  ntb->mw_cnt %d  .", peer_mw_cnt,  ntb->mw_cnt);

WARNING:IF_1: Consider removing the #if 1 and its #endif
#3169: FILE: drivers/raw/ntb/ntb_hw_amd.h:21:
+#if 1

ERROR:CODE_INDENT: code indent should use tabs where possible
#3171: FILE: drivers/raw/ntb/ntb_hw_amd.h:23:
+        struct rte_bus bus;               /**< Inherit the generic class */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3171: FILE: drivers/raw/ntb/ntb_hw_amd.h:23:
+        struct rte_bus bus;               /**< Inherit the generic class */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3172: FILE: drivers/raw/ntb/ntb_hw_amd.h:24:
+        RTE_TAILQ_HEAD(, rte_pci_device) device_list; /**< List of PCI devices */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3172: FILE: drivers/raw/ntb/ntb_hw_amd.h:24:
+        RTE_TAILQ_HEAD(, rte_pci_device) device_list; /**< List of PCI devices */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3173: FILE: drivers/raw/ntb/ntb_hw_amd.h:25:
+        RTE_TAILQ_HEAD(, rte_pci_driver) driver_list; /**< List of PCI drivers */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3173: FILE: drivers/raw/ntb/ntb_hw_amd.h:25:
+        RTE_TAILQ_HEAD(, rte_pci_driver) driver_list; /**< List of PCI drivers */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3181: FILE: drivers/raw/ntb/ntb_hw_amd.h:33:
+        RTE_TAILQ_FOREACH(p, &(rte_pci_bus.device_list), next)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3181: FILE: drivers/raw/ntb/ntb_hw_amd.h:33:
+        RTE_TAILQ_FOREACH(p, &(rte_pci_bus.device_list), next)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3184: FILE: drivers/raw/ntb/ntb_hw_amd.h:36:
+        RTE_TAILQ_FOREACH(p, &(rte_pci_bus.driver_list), next)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3184: FILE: drivers/raw/ntb/ntb_hw_amd.h:36:
+        RTE_TAILQ_FOREACH(p, &(rte_pci_bus.driver_list), next)$

WARNING:TYPO_SPELLING: 'Regsiters' may be misspelled - perhaps 'Registers'?
#3189: FILE: drivers/raw/ntb/ntb_hw_amd.h:41:
+/* AMD NTB Regsiters */

ERROR:CODE_INDENT: code indent should use tabs where possible
#3259: FILE: drivers/raw/ntb/ntb_hw_amd.h:111:
+        void  *peer_mmio;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3259: FILE: drivers/raw/ntb/ntb_hw_amd.h:111:
+        void  *peer_mmio;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3260: FILE: drivers/raw/ntb/ntb_hw_amd.h:112:
+        unsigned int self_spad;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3260: FILE: drivers/raw/ntb/ntb_hw_amd.h:112:
+        unsigned int self_spad;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3261: FILE: drivers/raw/ntb/ntb_hw_amd.h:113:
+        unsigned int peer_spad;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3261: FILE: drivers/raw/ntb/ntb_hw_amd.h:113:
+        unsigned int peer_spad;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3284: FILE: drivers/raw/ntb/ntb_hw_intel.c:620:
+        struct ntb_hw *hw = dev->dev_private;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3284: FILE: drivers/raw/ntb/ntb_hw_intel.c:620:
+        struct ntb_hw *hw = dev->dev_private;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3285: FILE: drivers/raw/ntb/ntb_hw_intel.c:621:
+        uint32_t val_h, val_l;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3285: FILE: drivers/raw/ntb/ntb_hw_intel.c:621:
+        uint32_t val_h, val_l;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3286: FILE: drivers/raw/ntb/ntb_hw_intel.c:622:
+        uint64_t peer_mw_size;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3286: FILE: drivers/raw/ntb/ntb_hw_intel.c:622:
+        uint64_t peer_mw_size;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3287: FILE: drivers/raw/ntb/ntb_hw_intel.c:623:
+        uint64_t db_bits = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3287: FILE: drivers/raw/ntb/ntb_hw_intel.c:623:
+        uint64_t db_bits = 0;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3288: FILE: drivers/raw/ntb/ntb_hw_intel.c:624:
+        uint8_t peer_mw_cnt;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3288: FILE: drivers/raw/ntb/ntb_hw_intel.c:624:
+        uint8_t peer_mw_cnt;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3289: FILE: drivers/raw/ntb/ntb_hw_intel.c:625:
+        int i = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3289: FILE: drivers/raw/ntb/ntb_hw_intel.c:625:
+        int i = 0;$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#3290: FILE: drivers/raw/ntb/ntb_hw_intel.c:626:
+^I$

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#3380: FILE: examples/ntb/ntb_fwd.c:53:
+#define ERR_RETURN(...) do { print_err(__func__, __LINE__, __VA_ARGS__); return -1; } while (0)

WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#3513: FILE: examples/ntb/ntb_fwd.c:456:
+				rte_memcpy(dst + current_dst_offset, src_buffers[i], total_order - current_dst_offset);

WARNING:LONG_LINE: line length of 124 exceeds 100 columns
#3525: FILE: examples/ntb/ntb_fwd.c:468:
+				rte_dma_copy(dma_dev_id, 0, rte_mempool_virt2iova(src_buffers[i]), dst + current_dst_offset,

WARNING:LONG_LINE: line length of 116 exceeds 100 columns
#3531: FILE: examples/ntb/ntb_fwd.c:474:
+			rte_dma_copy(dma_dev_id, 0, rte_mempool_virt2iova(src_buffers[i]), dst + current_dst_offset,

WARNING:LONG_LINE: line length of 180 exceeds 100 columns
#3546: FILE: examples/ntb/ntb_fwd.c:489:
+		printf("Data copied: %u bytes in  %.3f ms. Bandwidth: %.2f MBytes/s on thread %u with dmadev %u
", total_order, cpu_time_ms, bandwidth_MBps, lcore_id, dma_dev_id);

WARNING:LONG_LINE: line length of 153 exceeds 100 columns
#3548: FILE: examples/ntb/ntb_fwd.c:491:
+		printf("Data copied: %u bytes in  %.3f ms. Bandwidth: %.2f MBytes/s on thread %u
", total_order, cpu_time_ms, bandwidth_MBps, lcore_id);

WARNING:TYPO_SPELLING: 'queus' may be misspelled - perhaps 'queues'?
#3628: FILE: examples/ntb/ntb_fwd.c:781:
+		 printf("num_queus = %u
", num_queues);

WARNING:LINE_CONTINUATIONS: Avoid line continuations in quoted strings
#3800: FILE: examples/ntb/ntb_fwd.c:1291:
+				rte_exit(EXIT_FAILURE, "Unsupported mode. (Should be: file-trans \

total: 35 errors, 66 warnings, 3622 lines checked
Warning in drivers/dma/ae4dma/ae4dma_internal.h:
Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE
Warning in drivers/dma/ae4dma/ae4dma_dmadev.c:
Warning in drivers/raw/ntb/ntb_hw_amd.c:
Writing to stdout or stderr
Warning in drivers/raw/ntb/ntb_hw_amd.c:
Warning in examples/ntb/ntb_fwd.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t
Warning in drivers/dma/ae4dma/ae4dma_internal.h:
Do not use variadic argument pack in macros
Please use __rte_cache_aligned only for struct or union types alignment.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* |WARNING| pw155017 [PATCH] ntb/ae4dma: added Amd userspace DMA and NTB drivers
       [not found] <20250705141001.34223-1-bhagyada.modali@amd.com>
  2025-07-05 13:40 ` |WARNING| pw155017 [PATCH] ntb/ae4dma: added Amd userspace DMA and NTB drivers qemudev
  2025-07-05 14:10 ` checkpatch
@ 2025-07-05 14:31 ` dpdklab
  2 siblings, 0 replies; 3+ messages in thread
From: dpdklab @ 2025-07-05 14:31 UTC (permalink / raw)
  To: test-report; +Cc: dpdk-test-reports

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/155017

_apply patch failure_

Submitter: Bhagyada Modali <bhagyada.modali@amd.com>
Date: Saturday, July 05 2025 14:10:01 
Applied on: CommitID:70c2297528e7c7789af452f78de1932e9a20c8a2
Apply patch set 155017 failed:

Cloning the DPDK mirror at: https://github.com/DPDK/dpdk.git (Attempt 1 of 3)
Trying to checkout branch: origin/main
Checked out to main (70c2297528e7c7789af452f78de1932e9a20c8a2)
Done: main commit 70c2297528e7c7789af452f78de1932e9a20c8a2
Trying to checkout branch: origin/main
Checked out to main (70c2297528e7c7789af452f78de1932e9a20c8a2)
Applying patch...

Failed to apply patch:
Applying: ntb/ae4dma: added Amd userspace DMA and NTB drivers
.git/rebase-apply/patch:3148: trailing whitespace.

.git/rebase-apply/patch:3000: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	app/test/test_dmadev.c
M	drivers/raw/ntb/ntb_hw_intel.c
M	usertools/dpdk-devbind.py
Falling back to patching base and 3-way merge...
Auto-merging usertools/dpdk-devbind.py
CONFLICT (content): Merge conflict in usertools/dpdk-devbind.py
Auto-merging drivers/raw/ntb/ntb_hw_intel.c
Auto-merging app/test/test_dmadev.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 ntb/ae4dma: added Amd userspace DMA and NTB drivers
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

https://lab.dpdk.org/results/dashboard/patchsets/33597/

UNH-IOL DPDK Community Lab

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-07-05 14:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20250705141001.34223-1-bhagyada.modali@amd.com>
2025-07-05 13:40 ` |WARNING| pw155017 [PATCH] ntb/ae4dma: added Amd userspace DMA and NTB drivers qemudev
2025-07-05 14:10 ` checkpatch
2025-07-05 14:31 ` dpdklab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).