From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96762A0471 for ; Fri, 16 Aug 2019 05:44:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CC951BE8D; Fri, 16 Aug 2019 05:44:17 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DEE461BE8D for ; Fri, 16 Aug 2019 05:44:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 20:44:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; d="scan'208";a="194904264" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 15 Aug 2019 20:44:13 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 20:44:13 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 20:44:13 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.15]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0439.000; Fri, 16 Aug 2019 11:44:11 +0800 From: "Zhang, Qi Z" To: "Ye, Xiaolong" CC: "Gavin Hu (Arm Technology China)" , "Richardson, Bruce" , "Ananyev, Konstantin" , "users@dpdk.org" , "Honnappa Nagarahalli" , "Phil Yang (Arm Technology China)" , "Ruifeng Wang (Arm Technology China)" Thread-Topic: i40e vPMD fix out of order Rx read issue Thread-Index: AdVCzJhDNbgBl9FATkWplfpJPawhKgAEGCLwAC59RaAAIKjSIAOMKbFQAAGo47AAUmFQgAASdNcQ Date: Fri, 16 Aug 2019 03:44:10 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153D7E363@SHSMSX105.ccr.corp.intel.com> References: <039ED4275CED7440929022BC67E7061153D71548@SHSMSX105.ccr.corp.intel.com> <039ED4275CED7440929022BC67E7061153D7485E@SHSMSX105.ccr.corp.intel.com> <039ED4275CED7440929022BC67E7061153D7D657@SHSMSX105.ccr.corp.intel.com> <20190816025058.GA53345@intel.com> In-Reply-To: <20190816025058.GA53345@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmJhYzFhMmItZjllOC00YTk3LTk2MDgtM2MxZTcyNWFjMDMzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidHJaTVBXTzVBUXZDRzRXbCtCeUNpVmt0OG9IMUNGNElzUCtYc3dUTW85dzBiaVE3bllkaHBOWDdkZ1BaZHpXcSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-users] i40e vPMD fix out of order Rx read issue X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" > -----Original Message----- > From: Ye, Xiaolong > Sent: Friday, August 16, 2019 10:51 AM > To: Zhang, Qi Z > Cc: Gavin Hu (Arm Technology China) ; Richardson, > Bruce ; Ananyev, Konstantin > ; users@dpdk.org; Honnappa Nagarahalli > ; Phil Yang (Arm Technology China) > ; Ruifeng Wang (Arm Technology China) > > Subject: Re: i40e vPMD fix out of order Rx read issue >=20 > On 08/14, Zhang, Qi Z wrote: > >+ Xiaolong > > > >I think we can merge them to dpdk-next-net-intel early since 19.11 cycle= is > started. >=20 > Ok, could you help to ack these patches? I'm not expert on arm, the patch is only impact on the arm platform and it = is reviewed by peoples that works on arm already, I think we can just apply= it. >=20 >=20 > Thanks, > Xiaolong > > > >> -----Original Message----- > >> From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > >> Sent: Wednesday, August 14, 2019 11:20 AM > >> To: Zhang, Qi Z ; Richardson, Bruce > >> ; Ananyev, Konstantin > >> > >> Cc: users@dpdk.org; Honnappa Nagarahalli > >> ; Phil Yang (Arm Technology China) > >> ; Ruifeng Wang (Arm Technology China) > >> > >> Subject: RE: i40e vPMD fix out of order Rx read issue > >> > >> Hi Qi, > >> > >> > -----Original Message----- > >> > From: Zhang, Qi Z > >> > Sent: Saturday, July 27, 2019 9:33 AM > >> > To: Gavin Hu (Arm Technology China) ; Richardson, > >> > Bruce ; Ananyev, Konstantin > >> > > >> > Cc: users@dpdk.org; Honnappa Nagarahalli > >> > ; Phil Yang (Arm Technology China) > >> > ; Ruifeng Wang (Arm Technology China) > >> > > >> > Subject: RE: i40e vPMD fix out of order Rx read issue > >> > > >> > > >> > > >> > > -----Original Message----- > >> > > From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > >> > > Sent: Friday, July 26, 2019 6:01 PM > >> > > To: Zhang, Qi Z ; Richardson, Bruce > >> > > ; Ananyev, Konstantin > >> > > > >> > > Cc: users@dpdk.org; Honnappa Nagarahalli > >> > > ; Phil Yang (Arm Technology China) > >> > > ; Ruifeng Wang (Arm Technology China) > >> > > > >> > > Subject: RE: i40e vPMD fix out of order Rx read issue > >> > > > >> > > Hi Qi, > >> > > > >> > > Thanks for your explanation! > >> > > I did some testing and found the barriers caused a big drop in > >> > > RFC2544 NDR performance on aarch64, how about it on X86? > >> > For x86, I think we don't have performance drop, the memory barrier > >> > just change the compiler's behavior to avoid generate out of order > >> > read instructions, and x86 guarantee no out of read execution, so > >> > it does not add new instructions that cost CPU cycles. > >> > > >> > > Is it possible to count DD bits in a way of surviving across the > >> > > out-of-order descriptors reading? > >> > > >> > I think it is possible, but this will impact performance on x86, > >> > but for aarch64, you can try out to see if that benefit and do > >> > proper optimization on related vPMD implementation. > >> The patches for aarch64 are in community review, and performances > >> gain were measured both for ixgbe and i40e vPMD. Very appreciate if > >> you can further review and comment. > >> Here are the patch links: > >> IXGBE vPMD: > >> http://patches.dpdk.org/patch/57649/ > >> http://patches.dpdk.org/patch/57650/ > >> I40e vPMD: > >> http://patches.dpdk.org/cover/57651/ > >> http://patches.dpdk.org/patch/57652/ > > > > > > > >> > > > >> > > Best Regards, > >> > > Gavin > >> > > > >> > > > -----Original Message----- > >> > > > From: Zhang, Qi Z > >> > > > Sent: Thursday, July 25, 2019 8:11 PM > >> > > > To: Gavin Hu (Arm Technology China) ; > >> > > > Richardson, Bruce ; Ananyev, > >> > > > Konstantin > >> > > > Cc: users@dpdk.org; Honnappa Nagarahalli > >> > > > ; Phil Yang (Arm Technology > >> > > > China) > >> > > > Subject: RE: i40e vPMD fix out of order Rx read issue > >> > > > > >> > > > Hi Gavin: > >> > > > > >> > > > in vPMD, we read 4 or 8 packets as batch, we count DD bits for > >> > > > packet received, but not check the if they are continues or > >> > > > not, we assume it should always be 1000, 1100, 1110, 1111 > >> > > > ....(take batch size is 4 as > >> > > > example) while the out of order read instruction generated by > >> > > > compiler will cause driver to get un-continues DD bits, like > >> > > > 1011, the descriptor on the hole actually is invalid since when > >> > > > it is read , descriptor is not write back yet, but we still > >> > > > process this as 1110, it cause > >> > an > >> > > corrupted mbuf returned. > >> > > > > >> > > > hope this is helpful. > >> > > > > >> > > > Regards > >> > > > Qi > >> > > > > >> > > > > -----Original Message----- > >> > > > > From: Gavin Hu (Arm Technology China) > >> > > > > [mailto:Gavin.Hu@arm.com] > >> > > > > Sent: Thursday, July 25, 2019 5:57 PM > >> > > > > To: Zhang, Qi Z ; Richardson, Bruce > >> > > > > ; Ananyev, Konstantin > >> > > > > > >> > > > > Cc: users@dpdk.org; Honnappa Nagarahalli > >> > > > > ; Phil Yang (Arm Technology > >> > > > > China) > >> > > > > Subject: i40e vPMD fix out of order Rx read issue > >> > > > > > >> > > > > Hi Qi, > >> > > > > > >> > > > > I am working on optimizing the i40e vPMD on aarch64 and I see > >> > > > > this patch relevant. > >> > > > > Could you illuminate what issue this patch was fixing? > >> > > > > I understand the PMD works at the driver layer, for delivery > >> > > > > of > >> > > > > L2 > >> > packets. > >> > > > > It does not own the responsibility to keep order(the > >> > > > > responsibility lies with > >> > > > the > >> > > > > protocol stack, like TCP)? > >> > > > > > >> > > > > http://patches.dpdk.org/patch/16665/ > >> > > > > > >> > > > > Best regards, > >> > > > > Gavin > >> > > > > > >> > > > > IMPORTANT NOTICE: The contents of this email and any > >> > > > > attachments are confidential and may also be privileged. If > >> > > > > you are not the intended recipient, please notify the sender > >> > > > > immediately and do not disclose the contents to any other > >> > > > > person, use it for any purpose, or store or copy the informati= on in > any medium. Thank you. > >> > > IMPORTANT NOTICE: The contents of this email and any attachments > >> > > are confidential and may also be privileged. If you are not the > >> > > intended > >> > recipient, > >> > > please notify the sender immediately and do not disclose the > >> > > contents to > >> > any > >> > > other person, use it for any purpose, or store or copy the > >> > > information in any medium. Thank you. > >> IMPORTANT NOTICE: The contents of this email and any attachments are > >> confidential and may also be privileged. If you are not the intended > >> recipient, please notify the sender immediately and do not disclose > >> the contents to any other person, use it for any purpose, or store or > >> copy the information in any medium. Thank you.