From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpo21.poczta.onet.pl (smtpo21.poczta.onet.pl [213.180.142.152]) by dpdk.org (Postfix) with ESMTP id 5789EC666 for ; Fri, 29 Jan 2016 14:00:31 +0100 (CET) Received: from pmq3v.m5r2.onet (pmq3v.m5r2.onet [10.174.32.69]) by smtp.poczta.onet.pl (Onet) with ESMTP id 3psJgL3RZBz9v7Jm; Fri, 29 Jan 2016 14:00:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vp.pl; s=2011; t=1454072430; bh=bRqgaoR4vhtLz9M8FOdqlMuqFhIaZSlXDIJcSsAXSQg=; h=Content-Type:MIME-Version:Content-Transfer-Encoding:From:Cc:To: Date:Message-Id:Subject; b=l6cGZC1MqcDW5o+Dy3o2Nuy7OhBGOujd6hFQBhbSZXEAkNOihcw+cRV2wfwetmcsM 2egKgLC+iZVKSXGN+dpyvCk7BFei5PsvNfC4vl1H2ces1ucr60u1bRL+8YqdZS9zr3 92Fngpjsp9dOybcLadv5sv9hyBDNRZvgeGimrmHQ= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received: from [78.11.8.249] by pmq3v.m5r2.onet via HTTP id 201601291358388042010001; Fri, 29 Jan 2016 14:00:30 +0100 From: dawid_jurek X-Priority: 3 To: Thomas Monjalon Date: Fri, 29 Jan 2016 14:00:28 +0100 Message-Id: <123374274-5dbc366f90d74852d84b7f6a9beccadf@pmq3v.m5r2.onet> X-Mailer: onet.poczta X-Onet-PMQ: ;78.11.8.249;PL;2 Cc: "users@dpdk.org" Subject: Re: [dpdk-users] SyntaxError in setup.sh during binding ethernet device X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jan 2016 13:00:31 -0000 W dniu 2016-01-27 14:48:05 u=C5=BCytkownik Thomas Monjalon napisa=C5=82: > 2016-01-27 14:44, dawid_jurek: > > W dniu 2016-01-19 11:54:24 u=C5=BCytkownik dawid_jurek napisa=C5=82: > > > = > > > = > > > W dniu 2016-01-19 11:19:55 u=C5=BCytkownik Thomas Monjalon napisa=C5=82: > > > > Hi > > > > = > > > > 2016-01-19 10:45, dawid_jurek: > > > > > Hello DPDK developers, > > > > > I experienced issue when I ran tools/setup.sh and chose option [2= 3]: Bind Ethernet device to IGB UIO module. > > > > > Script Output: > > > > > File ".../dpdk/dpdk-2.2.0/tools/dpdk_nic_bind.py", line 113 > > > > > """ % locals() # replace items from local variables > > > > > ^ > > > > > SyntaxError: invalid syntax > > > > > It turned out that python 2.7 set as default in system was needed. > > > > > So I added python2 to every line with dpdk_nic_bind.py call in to= ols/setup.sh and now it works fine. > > > > > But the question is: is it expected behaviour? Shouldn't it be fi= xed by simple patch in way I did it? > > > > = > > > > Yes a patch would be appreciated to make it python 3 friendly. > > > > Thanks > > > > = > > > = > > > OK. I will prepare patch for dpdk_nic_bind.py soon. > > > Regards, > > > Dawid > > > = > > > = > > = > > Hello again, > > patch for this issue was prepared and tested on Arch (Python 3 is defau= lt) and Ubuntu (Python 2 is default) distros. = > > In both cases syntax errors from dpdk_nic_bind.py disappeared and every= thing worked as expected. = > > Patch is very simple and in most cases just adds extra brackets to prin= t functions. > > Anyway please review this. > = > It looks simple and good. > Please could you send it on dev@dpdk.org? > The procedure is described here: > http://dpdk.org/dev#send > and detailed here: > http://dpdk.org/doc/guides/contributing/patches.html > = > Thanks > = Done. Available here: http://dpdk.org/ml/archives/dev/2016-January/032148.html Regards, Dawid