From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 728542BA3 for ; Fri, 9 Jun 2017 12:15:35 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id v104so28422501wrb.0 for ; Fri, 09 Jun 2017 03:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=h0c1LvBfQi9mhf+nTZ8uehx1R+yTkwnMHnXBC8lHEM8=; b=zqoW9ESjBNZA8GaJRubvsMbUZOgj/9K7ayRxxxXniOsudSbtwcwrDyT6OniCdbr2c5 Ovmd6ci6YlCgM06vV86JN0MhctHRGmf2TBO1niXVzYtHDtQGO6ODIlhVZE2CJGAlKEoO VM3Lsoj3ASlAQjXe3M19/ylHf72Z3V0FeSgCDiU+4UU6wdABpvPU4N8/wyEiixEHhiN3 T7o7WHl4eyyj+O9BKicc/Xf+S7v6hOzof1V0huOZNh6M+415Y73PWaHfGpuud2EMHy/Q +XYFu1ZnqjEgzPs2xjR5ohGp26rxGSXWv73O99V8uWD8OGz8DHSA2poQkW/mknI7QkrU soVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=h0c1LvBfQi9mhf+nTZ8uehx1R+yTkwnMHnXBC8lHEM8=; b=nlCwL4wfpIPc7z3EUnDP+emEHj4BQcq+qheK20/JXPzqWjL8UzFneiZF0Cxr2CK2FY +nHc5gvXSBevi4O5YEbAgZc+IW7f1vvVsuUVP15meJ3Yyq/vI9diHECftb278FPU1+tu sZIamFMKBvcF5C/BVyquf4mdZTM9WgvdJjZ2A9wfuyoVyTwMZ2b0wBD2V8sBD4noQCjk GcDgEeVVwz3xbCk1P0wMxCkpEn3XGBUDFiMw+cLAgVYrG7SwN2Ei6xWDbhMocvSnSiqS 5DjPotsOfy+TOrQl0gUrmNhvuWRZC0416JcHITLsRq/s7hVFM70Z+C81jSsjBsKNdUaV j/mQ== X-Gm-Message-State: AODbwcAau/2OeMFOdE7VhrxbjHtK/qYbavNHp7VYArStKMy9n24Y+L6u 8adaR/B8CWDKVhPv X-Received: by 10.223.174.180 with SMTP id y49mr602775wrc.2.1497003335062; Fri, 09 Jun 2017 03:15:35 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id n21sm742836wra.38.2017.06.09.03.15.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jun 2017 03:15:34 -0700 (PDT) Date: Fri, 9 Jun 2017 12:15:26 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Sam Cc: users@dpdk.org Message-ID: <20170609101526.GF29091@bidouze.vm.6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-users] Why not extand tab into space in dpdk's coding style? X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2017 10:15:35 -0000 Hi Sam, On Fri, Jun 09, 2017 at 06:03:07PM +0800, Sam wrote: > Now coding in dpdk, I find that lots of file use TABs and SPACEs together > for indentation, mixed !!! > > I don't know if this is due to some one prefer SPACE, others prefer TAB. > > For ovs, its coding style restrict to use TAB to extand SPACE, why dpdk > don't like this? The coding style for DPDK is explained in [1]. Indentation is explained in [2]. It is pretty close to LKCS. For hard tabs / space mixes, usually this is the result of the proper indentation not being modulo 8, the length of the tab. In this case, you have to indent as much as possible with hard tabs and complete with spaces. There may be errors in coding style as it has not always been strictly enforced, and some maintainers are less stringent on this, but the choice has been made a long time ago and it is for using tabs. [1]: http://dpdk.org/doc/guides/contributing/coding_style.html [2]: http://dpdk.org/doc/guides/contributing/coding_style.html#c-indentation Cheers, -- Gaëtan Rivet 6WIND