From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id 85AD51B19A for ; Thu, 21 Sep 2017 11:18:17 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id u96so4042198wrb.6 for ; Thu, 21 Sep 2017 02:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=18nZbQfX5RvCqcchQngWiQT/plVu54XU5e0hX91ng04=; b=MhXJiVgUpdd4kFt5F6efWjhFCDschnlDJKKHX2jZPXoEDtkqbn7fE8DoKk/ckhbj8X cOXwW4xauro+owPy7f323em3CwT2Cwq0o0iaAWuJxKKqGKkAtCJJrmD9CzBP2+SGqh5t d4ThmYJF4p9PFYaQGnMMT0waeUZ3qLk7cAi6tjQkcziDwysplzq+kIEqJVrhwNMvIEIa pcGNZ+GGjOoTNWQzWEvld2hEpghwjZiIcIPJeS2KMWxX6Lk9Eu+Czsx9X9jkhCUY/m48 uu6eoqYRIUMzyIszDZPb325JIxH+rnGqA6Sz52KLXzpJTi1cnECRiJI0+LQRoeugZyt9 53qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=18nZbQfX5RvCqcchQngWiQT/plVu54XU5e0hX91ng04=; b=JzUowF1R6ZXGBLTKXVY6pmNHCCqad8d80w7i16QnWrZ3NMwzzR+Jpnb0bG4PkMAct6 Nm2lWNh/5tIQHYlhEBve5LdQvP44jrqAo0q+sjZJn7Q9pByum1nEnYC/sKvAo4MydWhs wuzTfUaafjcenJqoogjwNaeC8bz6nrsG5UnMHbXXnoFnsFn9aAYLOjO9Il/+pBs+cyxA tfmDQkVu4eGRSB9BE3a34UOcbaLfutILOQreTL5AHrqFPR4al6b1ZchbBx/KUHHdRs1q AhULuGceW9EDr3VxGcsxhM3P1ateMIKPLKiIOtTiSlKzcLFXdaMGGMJavAuyi4s7zrx2 bkzw== X-Gm-Message-State: AHPjjUj/jAw2DQbOdfUReCxZaGsdSv9TMoi59Qzs1pq+zVA0zFLSWWwV 59e24BL3zy4EGYhyXSTKD2qDtA== X-Google-Smtp-Source: AOwi7QC0EXuU0FfXKkPJR+gIQ+pvD54ec+5tQybnQHPD+vC5xNnaJg7JMAbMD3jp05wqcygtzWAsVw== X-Received: by 10.223.134.93 with SMTP id 29mr1419334wrw.60.1505985497224; Thu, 21 Sep 2017 02:18:17 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 69sm1369939wmp.11.2017.09.21.02.18.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Sep 2017 02:18:16 -0700 (PDT) Date: Thu, 21 Sep 2017 11:17:59 +0200 From: Adrien Mazarguil To: Kevin Traynor Cc: "Loftus, Ciara" , devendra rawat , "ovs-dev@openvswitch.org" , nelio.laranjeiro@6wind.com, "users@dpdk.org" , Yuanhan Liu , Thomas Monjalon Message-ID: <20170921091759.GA11375@6wind.com> References: <74F120C019F4A64C9B78E802F6AD4CC278E04762@IRSMSX106.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-users] [ovs-dev] adding dpdk ports sharing same pci address to ovs-dpdk bridge X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 09:18:17 -0000 On Wed, Sep 20, 2017 at 06:33:43PM +0100, Kevin Traynor wrote: > On 09/08/2017 10:56 AM, Loftus, Ciara wrote: > >> Hi, > >> > >> I have compiled and built ovs-dpdk using DPDK v17.08 and OVS v2.8.0. The > >> NIC that I am using is Mellanox ConnectX-3 Pro, which is a dual port 10G > >> NIC. The problem with this NIC is that it provides only one PCI address for > >> both the 10G ports. > >> > >> So when I am trying to add the two DPDK ports to my br0 bridge > >> > >> # ovs-vsctl --no-wait add-port br0 dpdk0 -- set Interface dpdk0 type=dpdk > >> options:dpdk-devargs=0002:01:00.0 > >> > >> # ovs-vsctl --no-wait add-port br0 dpdk1 -- set Interface dpdk1 type=dpdk > >> options:dpdk-devargs=0002:01:00.0 > >> > >> The port dpdk1 is added successfully and able to transfer data, but adding > >> dpdk0 to br0 fails: > >> > >> 2017-09-06T14:19:20Z|00045|netdev_dpdk|INFO|Port 0: e4:1d:2d:4f:78:60 > >> 2017-09-06T14:19:20Z|00046|bridge|INFO|bridge br0: added interface dpdk1 > >> on > >> port 1 > >> 2017-09-06T14:19:20Z|00047|bridge|INFO|bridge br0: added interface br0 > >> on > >> port 65534 > >> 2017-09-06T14:19:20Z|00048|dpif_netlink|WARN|Generic Netlink family > >> 'ovs_datapath' does not exist. The Open vSwitch kernel module is probably > >> not loaded. > >> 2017-09-06T14:19:20Z|00049|netdev_dpdk|WARN|'dpdk0' is trying to use > >> device > >> '0002:01:00.0' which is already in use by 'dpdk1' > >> 2017-09-06T14:19:20Z|00050|netdev|WARN|dpdk0: could not set > >> configuration > >> (Address already in use) > >> 2017-09-06T14:19:20Z|00051|bridge|INFO|bridge br0: using datapath ID > >> 0000e41d2d4f7860 > >> > >> > >> With OVS v2.6.1 I never had this problem as dpdk-devargs was not > >> mandatory > >> and just specifying port name was enough to add that port to bridge. > >> > >> Is there a way to add port both ports to bridge ? > > > > It seems the DPDK function rte_eth_dev_get_port_by_name() will always return the port ID of the first port on your NIC, when you specify the single PCI address and that's where the problem is. There doesn't seem to be a way currently to indicate to the calling application that in fact two (or more) port IDs are associated with the one PCI address. > > > > I am cc-ing DPDK users mailing list for hopefully some input. Are there any plans for the rte_eth_dev_get_port_by_name function to be compatible with NICs with multiple ports under the same PCI address? > > > > Hi Adrien/Nelio, > > Is this something you can answer? We're wondering how to handle this in > OVS and whether a temporary or long term solution is needed. > > The original thread started here: > https://mail.openvswitch.org/pipermail/ovs-dev/2017-September/338418.html Hi, I'm late to this thread and not too familiar with openvswitch's internals, however after reading this thread here are some thoughts. About rte_eth_dev_get_port_by_name(), contrary to other PMDs, mlx4 generates for each port something that is not a PCI bus address precisely to avoid collisions. The name is the concatenation of the associated Verbs device name and the physical port number, e.g. "mlx4_0 port 0" instead of "0000:02:42.0". Referring to a port with this name through the above function should yield the correct device. If necessary, the PCI address to Verbs device name conversion can be performed like the PMD itself by looking at sysfs, e.g: $ PCI=0000:02:42.0 $ ls /sys/bus/pci/devices/$PCI/infiniband/ mlx4_0 Since DPDK 17.05, there's also a way to select what ports the mlx4 PMD should register DPDK devices for by providing a "port" parameter (DPDK devargs). The default is to enable them all, see: http://dpdk.org/browse/dpdk/commit/?id=001a520e419fdbab8d83f572c2a4414c7bc8ed07 This can help for single port use cases where several ports are registered by the PMD and the wrong one is used by the application. -- Adrien Mazarguil 6WIND