From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 8A325322C
 for <users@dpdk.org>; Mon, 22 Jan 2018 14:38:18 +0100 (CET)
Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1edcIo-0006f9-FY; Mon, 22 Jan 2018 14:38:24 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Mon, 22 Jan 2018 14:38:15 +0100
Date: Mon, 22 Jan 2018 14:38:15 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: longtb5@viettel.com.vn
Cc: users@dpdk.org
Message-ID: <20180122133815.qdfhjufewirzwb2r@platinum>
References: <001501d3936a$5ad21450$10763cf0$@viettel.com.vn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <001501d3936a$5ad21450$10763cf0$@viettel.com.vn>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-users] librte_cmdline usage
X-BeenThere: users@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK usage discussions <users.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/users>,
 <mailto:users-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/users/>
List-Post: <mailto:users@dpdk.org>
List-Help: <mailto:users-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/users>,
 <mailto:users-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2018 13:38:18 -0000

Hi,

On Mon, Jan 22, 2018 at 05:15:22PM +0700, longtb5@viettel.com.vn wrote:
> Hi all,
> 
> I'm writing an application where there already exists a cmdline. Users can
> issue commands by typing from stdin. I want to support another user
> interface where commands are read from sources other than stdin, saved into
> a string buffer, then executed using the already existed cmd_parse_ctx_t.
> 
> So far I have implemented this functionality using the cmdline_interact()
> API like so (pseudo code).
> 
> /* Initialization */
> /* cmds_ctx is the existing command context
>  * that I wish to reuse
>  */
> new_cl = cmdline_new(cmds_ctx, "", cmdbuf_fd, 1); 
> 
> /* Polling */
> for ( ; ; ) {
> 	snprintf(cmdbuf, cmdlen + 2, "%s\n", raw_string);
> 	lseek(cmdbuf_fd, 0 , SEEK_SET);
> 	cmdline_interact(new_cl);
> }
> 
> There are a couple of questions:
> 
> 1. Using cmdline_interact() seems to be quite expensive. How can I reduce
> this cost. Is there a leaner/more elegant way to implement this using DPDK
> API or do I have to write my own code/change the lib?
> 
> 2. How can I disable the behavior where every interaction is written to
> stdout, i.e., to have no output what so ever. Again this is to improve
> performance since writing to stdout is costly.

If my understanding is correct, you want to use the command line parser
without the i/o (readline part). For this, you can directly call
cmdline_parse(cl, buffer). It will parse the given buffer and invokes
the callback.

There will be no output on stdout done by the cmdline library. But it
does not prevent a command callback to call printf() or similar.

Olivier