From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4AD3A00E6 for ; Tue, 6 Aug 2019 11:12:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA9071BE07; Tue, 6 Aug 2019 11:12:38 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by dpdk.org (Postfix) with ESMTP id 477F71BE01 for ; Tue, 6 Aug 2019 11:12:37 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id k2so1241871wrq.2 for ; Tue, 06 Aug 2019 02:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5j36Sw6c+fxWoXDVqfDn/YHtbV6nL51Go0Cy7gfyyGQ=; b=ae+1unnDguN5AhDKJrBMpKvl+gkFhF3C3j+7VzxTeLSse1fuBJfM3HhJdQKb3HuW8Z e+Tw1bDEtYqKT28AJqB+nFqkZQOZki4u17ooCFjVoF7JWmSnHhm8+bFczLK+8qYrJ1le O3qctcRq8qQKV3SSNdLXAbS0JNvUnVsBtoQ+ytqYx+ZXW8Hm+ZvvqmuMuXnaQuEEFN0+ MzJkMGcx55YLuDpWfKlR2R3gDDyYjHAogyDVc0v9MRZ4Gd8cMMyk+1TJhY58oXBlgHwQ dISJITq7Cuaox0yZcGhTNriX0Uw6ZTvQNIKFWOeaVJf/65le4v81w79DibTCCmmOx5/a /F3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5j36Sw6c+fxWoXDVqfDn/YHtbV6nL51Go0Cy7gfyyGQ=; b=GRA0InpQa92oWo33aiZ+wn3sCXlsyMuIc6ehaSH99ffje2IuD8QouWhE0ebvcmW/tM /84Sc/zKaklNlYs9OeduXl5SNksykXduue4tbCj9OdaSAZGjdY056sqFS7ERVXtmAtwt 7rALumvKhKfup5jBjwMcR3fKzyTNxdxzYTrgjq4j47iXLgPcmuoCLykyMCZlxPbvKRcx FrgToBLQFRb+mOhIMsWRBw5V5NWslcZdpAK9waDJGR7bP0JzQPTs+laMi500VVLhAZhA +Mc1uR8XQ4nuFkUAhzdfBQ+WcUvaDECa6uimDItSSbax/sqMamnrNa+wexFbUUpXO5hV 9edg== X-Gm-Message-State: APjAAAWvx0zRT39PMcD/NNwVUFN/TO4Dof30JH5WdfbjJ7XxCPk6qSvt 7V41bqlvMWH5QOud2y2fy1htqifFwEDrKQ== X-Google-Smtp-Source: APXvYqw0ZA5Jl9admYq1l8i48ZDIy3l138sCPRLlEQvOFQLMBB/3/+CsqOoSTTBCQeNoxaYitQ6nUQ== X-Received: by 2002:a5d:6911:: with SMTP id t17mr3367390wru.268.1565082757082; Tue, 06 Aug 2019 02:12:37 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l8sm168511758wrg.40.2019.08.06.02.12.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 02:12:36 -0700 (PDT) Date: Tue, 6 Aug 2019 11:12:34 +0200 From: Adrien Mazarguil To: Hideyuki Yamashita Cc: Ye Xiaolong , "users@dpdk.org" Message-ID: <20190806091234.GJ4512@6wind.com> References: <20190730122539.GD4512@6wind.com> <20190731113045.8EC1.17218CA3@ntt-tx.co.jp_1> <20190802150619.D107.17218CA3@ntt-tx.co.jp_1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190802150619.D107.17218CA3@ntt-tx.co.jp_1> Subject: Re: [dpdk-users] Why flow can not be created? X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" On Fri, Aug 02, 2019 at 03:06:19PM +0900, Hideyuki Yamashita wrote: > Helllo Experts, I think most of them are on vacation :) > Q1. Are there any NICs which supports entag/detag VLAN? > I searched source DPDK source code with keyword "OF_POP_VLAN" or "OF_POP_VLAN" > and found some codes within mlx5_flow_tcf.c and cxgbe_flow.c. Indeed only those two seem to implement that. However depending on what you're trying to achieve, there could be a workaround as many drivers provide support for VLAN entag/detag outside rte_flow. For Rx, you can dedicate queues to perform VLAN stripping through rte_eth_dev_set_vlan_strip_on_queue(), and use rte_flow to redirect traffic of interest to these queues after matching specific VLANs and other properties for instance. If you don't care about specific VLANs or queues, you can request VLAN stripping globally using ETH_VLAN_STRIP_OFFLOAD with rte_eth_dev_set_vlan_offload(), then rely on mbuf->ol_flags & PKT_RX_VLAN to retrieve it from mbuf->vlan_tci. On the Tx side you simply have to request mbuf->ol_flags | PKT_TX_VLAN while doing Tx. As for Rx, make sure DEV_TX_OFFLOAD_VLAN_INSERT is among the Tx offloads requested during setup (rte_eth_conf->txmode.offloads). > Q2. Are there any plans in DPDK community to update document about > NIC to update support of rte_flow? > I have heard the situation about document form Adrien, and to be honest > I felt it is very hard to take try and error with testpmd for every NIC. This was discussed in the past, however so far no action was taken. I think we cannot summarize all supported combinations for each NIC while covering their specific quirks efficiently. For instance, two NICs may support a given pattern item, but not necessarily at the same position in the pattern. Likewise for pattern item fields, they may not support the same masks. The most sensible approach is perhaps to provide a list of popular flow rules tagged with the NICs supporting them. Anyway since it's not a huge priority at the moment, you should start a discussion on that topic on the dev@dpdk.org mailing list. Without noise, nothing will happen :) As usual contributions are always welcome! -- Adrien Mazarguil 6WIND