From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB674A052E for ; Mon, 9 Mar 2020 18:33:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C722B1C06D; Mon, 9 Mar 2020 18:33:00 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 1F8C11C06B for ; Mon, 9 Mar 2020 18:32:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583775178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+AUfLUj9ruyJE81FW9C6q+/mpOAFhU19u/WLz44DxlA=; b=cPL3wfAFiejI28Uy2Z5c3NVK6757jWtwmZj+Nv4214ktYfwoNyVwJGxNS9Jk4QkSLRbJz2 cCN4fEE/aW/8CXN27mmX+EYMKvuvnvvipBe6QFvIemPzniFycEboLQCwsBe57LVqgydciM QeDQHBmQ+jcWg7fWhL02En7ZuT+sW+Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-PqH4BEXQMGWXbqpFLz_wqw-1; Mon, 09 Mar 2020 13:32:55 -0400 X-MC-Unique: PqH4BEXQMGWXbqpFLz_wqw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2AC7413F5; Mon, 9 Mar 2020 17:32:53 +0000 (UTC) Received: from [10.33.36.148] (unknown [10.33.36.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 42B1A60C05; Mon, 9 Mar 2020 17:32:50 +0000 (UTC) To: "Dey, Souvik" , "dev@dpdk.org" , "Xu, Qian Q" , Wenzhuo Lu , Konstantin Ananyev , "Yu, PingX" Cc: "xiaolong.ye@intel.com" , "xiao.zhang@intel.com" , "users@dpdk.org" , Stephen Hemminger , Ferruh Yigit , "stable@dpdk.org" References: From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <34fab8c4-f975-ace8-5380-e57cddd3268d@redhat.com> Date: Mon, 9 Mar 2020 17:32:49 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-users] [dpdk-dev] Issue with X550 link status X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" On 04/03/2020 21:22, Dey, Souvik wrote: Hi Souvik, > Little more information. It looks like the below X550 nic is broken as th= e change related to http://patches.dpdk.org/patch/63951/ is not been backpo= rted. > The below patch broken the link status for ixgbevf and the fix was done i= n the above patch but we have only backported the below patch to 18.11.6 wh= ich breaks the ixgbevf link status. When is plan for 18.11.7 or updated 18.= 11.6 as we should not have a broken release. >=20 Thanks for reporting this. The fix was in a later DPDK release and will be part of 18.11.7. It is already backported to the 18.11 branch [1]. I am expecting some more backports this week from authors and to create a RC for 18.11.7 next week. After that, it is dependent on different companies to validate and what is found during that validation. At the moment assuming no major issues, I would estimate April 10th. There is a list of validation-contacts, that I can add you to if you are using LTS's so you would get the emails about RC's etc and could test prior to release. Let me know if you are interested. +ixgbe maintainers and Intel validation team, is there a test that can be added to prevent future link status issues? thanks, Kevin. [1] commit 03b69d3c415f084b14833ed911ac9aa2e470b409 Author: Lunyuan Cui Date: Tue Dec 17 06:12:03 2019 +0000 net/ixgbe: fix link status [ upstream commit ff8162cb9571528c006f265a32730a463fd0b886 ] > -- > Regads, > Souvik >=20 > From: Dey, Souvik > Sent: Wednesday, March 4, 2020 4:08 PM > To: dev@dpdk.org > Cc: xiaolong.ye@intel.com; xiao.zhang@intel.com; users@dpdk.org; Stephen = Hemminger ; Ferruh Yigit > Subject: RE: Issue with X550 link status >=20 > The X550 NIC is of the below device id. > [root@stdell10 ~]# lspci -nnn | grep -i ether > 19:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller= 10G X550T [8086:1563] (rev 01) > 19:00.1 Ethernet controller [0200]: Intel Corporation Ethernet Controller= 10G X550T [8086:1563] (rev 01) > 19:10.0 Ethernet controller [0200]: Intel Corporation X550 Virtual Functi= on [8086:1565] > 19:10.1 Ethernet controller [0200]: Intel Corporation X550 Virtual Functi= on [8086:1565] > 19:10.2 Ethernet controller [0200]: Intel Corporation X550 Virtual Functi= on [8086:1565] > 19:10.3 Ethernet controller [0200]: Intel Corporation X550 Virtual Functi= on [8086:1565] >=20 > So the mac_type is ixgbe_mac_X550_vf in the below case. >=20 > -- > Regards, > Souvik >=20 > From: Dey, Souvik > Sent: Wednesday, March 4, 2020 1:17 PM > To: dev@dpdk.org > Cc: xiaolong.ye@intel.com; xiao.zhang@intel= .com; users@dpdk.org > Subject: Issue with X550 link status >=20 > Hi All, > After upgrading to DPDK 18.11.6 LTS release from 18.11.2 th= e link_update call for link status update is not working for X550 NICs SR-= IOV enabled. On debugging it looks like the change introduced as a part of = this patch is causing the issue. >=20 > https://patches.dpdk.org/patch/62140/ >=20 > @@ -4135,6 +4138,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *d= ev, > return rte_eth_linkstatus_set(dev, &link); > } >=20 > + esdp_reg =3D IXGBE_READ_REG(hw, IXGBE_ESDP); > + if ((esdp_reg & IXGBE_ESDP_SDP3)) > + link_up =3D 0; > + > if (link_up =3D=3D 0) { > if (ixgbe_get_media_type(hw) =3D=3D ixgbe_media_type_fiber)= { > intr->flags |=3D IXGBE_FLAG_NEED_LINK_CONFIG; >=20 >=20 > I can see that the esdp_req is coming as 3735928495(0xDEADBEAF) and due t= o which the link_up is set to 0 even when ixgbevf_check_link returned link_= up as 1. Along with this patch I also see a path_fullchk patch introduced ,= does that play any role in this ? > Can someone please let me know if the patch has got some issues or it is = behaving correctly and the link_status is failing for valid reason. As ment= ioned earlier the same HW with same NIC acting in SR-IOV works fine with 18= .11.2 DPDK . I am blocked at a customer bug dew to this and any urgent help= will be much appreciated. >=20 > -- > Regards, > Souvik >=20 >=20 > -------------------------------------------------------------------------= ---------------------------------------------- > Notice: This e-mail together with any attachments may contain information= of Ribbon Communications Inc. that > is confidential and/or proprietary for the sole use of the intended recip= ient. Any review, disclosure, reliance or > distribution by others or forwarding without express permission is strict= ly prohibited. If you are not the intended > recipient, please notify the sender immediately and then delete all copie= s, including any attachments. > -------------------------------------------------------------------------= ---------------------------------------------- >=20