From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 7EB6595B8 for ; Wed, 27 Jan 2016 14:49:15 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id n5so27329492wmn.0 for ; Wed, 27 Jan 2016 05:49:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=5/hIBLYBXogG/Rsl1Nib7TrdOrfw6Og4noaBMmIhO2M=; b=gQRJ8CUavxSn8KNZAf/bUTYhniy70Q7VbY4+zHjnomnWbpBSIuEzkb96hnepDxFhMH x8+wgISOSG+TMRd5vIvk9Sky9+dIvSVwOPoxhdWLXQDfAm0lWUF1ZMeHTiJVLK7kcwyb LGxn/n9eE/L53gjUcUPDRl8x8iu0BVTkBj2gNTfk08is2Lq2bBSG9N0K46QydQRzvjxA iRYiSESGqdgOzKUjjVaspMEnMbBOBYm6htVuBueymoE4H/d5xKGbPOMLso9VA/ydSHLL hMnHhB1fpyz5PvxoiaMn1AMMxU/Y+mzH73oFs3B2PFuE6FOqD4k9VQrb7B4JIqxUxAnR WKmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=5/hIBLYBXogG/Rsl1Nib7TrdOrfw6Og4noaBMmIhO2M=; b=ivKaRVxSftqTlfzKTflKa8j3l2oQOld/Izhb+VDhnjwg9FDxNJtCNQFhpc7+nOgwIx itihcqsCIccXP7UEA1T4Iib32/bVG0VcXe5IzRsAIzGRwjeBqbyusIAX1gOJMo0+9Gtc 6vGrI2EEdLOxqZ6aHVs71F3+RoCDEPJFOJbIxkYqklqLW1CRYgRlHVXruVuC1XWuAbGK voJZO3stR8hfh6yebdG2CBsOu1P0gzUJp/E/rTue4jNw0vuu8GAADqeczDSbV/Gw5UL7 pqsj3GoW9jRRDjd9DwzAqSLj4GbWqCZ/MT0/+K215bECfP3jVr6shW6fHQ3PvNldVfdC xSjA== X-Gm-Message-State: AG10YOQsxaIer4AM+jPxbkrSGvPQ7WS53vrDtB/mPH3A1Hb4U5hCnU049r9jveh8Vi/nrdK/ X-Received: by 10.28.101.131 with SMTP id z125mr29227157wmb.60.1453902555340; Wed, 27 Jan 2016 05:49:15 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id l7sm6368753wjx.14.2016.01.27.05.49.14 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jan 2016 05:49:14 -0800 (PST) From: Thomas Monjalon To: dawid_jurek Date: Wed, 27 Jan 2016 14:48:05 +0100 Message-ID: <363477625.2oxVj6BxUQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <123065911-cd2e3bceeae2c6d9a614feda1f0df9e8@pmq3v.m5r2.onet> References: <123065911-cd2e3bceeae2c6d9a614feda1f0df9e8@pmq3v.m5r2.onet> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: users@dpdk.org Subject: Re: [dpdk-users] SyntaxError in setup.sh during binding ethernet device X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 13:49:15 -0000 2016-01-27 14:44, dawid_jurek: > W dniu 2016-01-19 11:54:24 u=C5=BCytkownik dawid_jurek napisa=C5=82: > >=20 > >=20 > > W dniu 2016-01-19 11:19:55 u=C5=BCytkownik Thomas Monjalon napisa=C5=82: > > > Hi > > >=20 > > > 2016-01-19 10:45, dawid_jurek: > > > > Hello DPDK developers, > > > > I experienced issue when I ran tools/setup.sh and chose option = [23]: Bind Ethernet device to IGB UIO module. > > > > Script Output: > > > > File ".../dpdk/dpdk-2.2.0/tools/dpdk_nic_bind.py", line 113 > > > > """ % locals() # replace items from local variables > > > > ^ > > > > SyntaxError: invalid syntax > > > > It turned out that python 2.7 set as default in system was need= ed. > > > > So I added python2 to every line with dpdk_nic_bind.py call in = tools/setup.sh and now it works fine. > > > > But the question is: is it expected behaviour? Shouldn't it be = fixed by simple patch in way I did it? > > >=20 > > > Yes a patch would be appreciated to make it python 3 friendly. > > > Thanks > > >=20 > >=20 > > OK. I will prepare patch for dpdk_nic_bind.py soon. > > Regards, > > Dawid > >=20 > >=20 >=20 > Hello again, > patch for this issue was prepared and tested on Arch (Python 3 is def= ault) and Ubuntu (Python 2 is default) distros.=20 > In both cases syntax errors from dpdk_nic_bind.py disappeared and eve= rything worked as expected.=20 > Patch is very simple and in most cases just adds extra brackets to pr= int functions. > Anyway please review this. It looks simple and good. Please could you send it on dev@dpdk.org? The procedure is described here: =09http://dpdk.org/dev#send and detailed here: =09http://dpdk.org/doc/guides/contributing/patches.html Thanks