Re: [dpdk-users] DPDK 17.11-rc2 and Pktgen 3.4.2 make error

["Wiles, Keith" <keith.wiles@intel.com>]

Thanks

> On Nov 8, 2017, at 3:21 AM, Gaëtan Rivet <gaetan.rivet@6wind.com> wrote:
> 
> Hey Alessio,
> 
> On Tue, Nov 07, 2017 at 05:13:39PM +0000, Alessio Silvestro wrote:
>> Dear Wiles,
>> 
>> Same error also in app/pktgen-stats.c:187 and app/pktgen-latency.c:163.
>> 
> 
> I may be the cause of this compilation issue.
> I moved around a few PCI declarations.
> 
> A new header now declares rte_pci_device elements.
> You should probably include <rte_bus_pci.h> in addition to <rte_pci.h>.
> 
> Anything that deals with PCI devices, drivers or bus functions are now
> in this new header. "rte_pci.h" only contains PCI utilities.
> 
>> Thanks for the hint.
>> 
>> Best regards,
>> Alessio
>> 
>> -----Original Message-----
>> From: Wiles, Keith [mailto:keith.wiles@intel.com] 
>> Sent: 07 November 2017 17:27
>> To: Alessio Silvestro
>> Cc: users@dpdk.org
>> Subject: Re: [dpdk-users] DPDK 17.11-rc2 and Pktgen 3.4.2 make error
>> 
>> Sorry, around the second fprintf() in the function.
>> 
>>> On Nov 7, 2017, at 10:25 AM, Wiles, Keith <keith.wiles@intel.com> wrote:
>>> 
>>> 
>>> 
>>>> On Nov 7, 2017, at 9:18 AM, Alessio Silvestro <alessio.silvestro@neclab.eu> wrote:
>>>> 
>>>> Dear all,
>>>> 
>>>> I have debian (4.13.0-0.bpo.1-amd64) and dpdk 17.11-rc2.
>>>> 
>>>> I am trying to install pktgen (3.4.2), but when I do make I got the following error:
>>>> 
>>>> 
>>>> CC cli-functions.o
>>>> In file included from /usr/local/pktgen-3.4.2/app/pktgen.h:112:0,
>>>>               from /usr/local/pktgen-3.4.2/app/cli-functions.c:57:
>>>> /usr/local/pktgen-3.4.2/app/pktgen-port-cfg.h: In function Өpktgen_dump_dev_infoӮ:
>>>> /usr/local/pktgen-3.4.2/app/pktgen-port-cfg.h:327:28: error: 
>>>> dereferencing pointer to incomplete type Өstruct rte_pci_deviceӮ  
>>>> di->pci_dev ? di->pci_dev->max_vfs : 0,
>>> 
>>> 
>>> The problem is that we have changed the PCI code, I have fix for this, but it needs to be cleaned up and pushed but I am having some bandwidth problems.
>>> 
>>> In the pktgen-port-cfg.h file at line 327 you need to add a #if around the first fprintf().
>>> 
>>> #if RTE_VERSION < RTE_VERSION_NUM(17, 5, 0, 0)
>>> 	fprintf( …
>>> 		);
>>> #endif
>>> 
>>> Maybe other ones in the code too. I will try to find some time to push that patch.
>>> 
>>>>                          ^~
>>>> /usr/local/pktgen-3.4.2/app/pktgen-port-cfg.h:343:25: warning: format Ө%dӮ expects argument of type ӨintӮ, but argument 3 has type Өuint64_t {aka long unsigned int}Ӯ [-Wformat=]
>>>> "   rx_offload_capa:%4d, tx_offload_capa   :%4d, reta_size     :%6d, flow_type_rss_offloads:%016" PRIx64 "\n",
>>>>                       ^
>>>> /usr/local/pktgen-3.4.2/app/pktgen-port-cfg.h:343:49: warning: format Ө%dӮ expects argument of type ӨintӮ, but argument 4 has type Өuint64_t {aka long unsigned int}Ӯ [-Wformat=]
>>>> "   rx_offload_capa:%4d, tx_offload_capa   :%4d, reta_size     :%6d, flow_type_rss_offloads:%016" PRIx64 "\n",
>>>> 
>>>> Do you have any hint or patch to suggest?
>>>> 
>>>> Thanks,
>>>> Alessio
>>>> 
>>>> 
>>>> ===============================================
>>>> Alessio Silvestro             „¢„ģ„Ć„·„Ŗ””„·„ė„Ł„¹„Č„ķ
>>>> Early Stage Researcher
>>>> 
>>>> Phone: +49 (0) 6221 4342 ØC 134
>>>> e-mail: 
>>>> Alessio.Silvestro@neclab.eu<mailto:Alessio.Silvestro@neclab.eu>
>>>> 
>>>> Data Science and System Platform Research Division NEC Europe Ltd.
>>>> Nec Laboratories Europe
>>>> Kurfعrsten-Anlage 36, 69115 Heidelberg, Germany 
>>>> ===============================================
>>>> NEC Europe Ltd | Registered Office: Athene, Odyssey Business Park, 
>>>> West End  Road, London, HA4 6QE, GB | Registered in England 2832014
>>>> 
>>>> 
>>> 
>>> Regards,
>>> Keith
>> 
>> Regards,
>> Keith
>> 
> 
> -- 
> Gaëtan Rivet
> 6WIND

Regards,
Keith