From: "Wiles, Keith" <keith.wiles@intel.com>
To: Michael Barker <mikeb01@gmail.com>
Cc: "users@dpdk.org" <users@dpdk.org>
Subject: Re: [dpdk-users] Calculating Packet Length
Date: Sat, 29 Sep 2018 14:39:39 +0000 [thread overview]
Message-ID: <B269E5D3-43C5-4E50-8499-86D119E655BB@intel.com> (raw)
In-Reply-To: <CALwNKeSL7HHoC3UaZ2GEeexyVgcqCCHaF3FDkZXCgYwXQeiVfQ@mail.gmail.com>
> On Sep 29, 2018, at 5:19 AM, Michael Barker <mikeb01@gmail.com> wrote:
>
> Hi,
>
> I've new to DPDK and have been started by sending ARP packets. I have a
> question around how to set the mbuf data_len and pkt_size. I Initially did
> the following:
>
> struct rte_mbuf* arp_pkt = rte_pktmbuf_alloc(mbuf_pool);
> const size_t pkt_size = sizeof(struct ether_addr) + sizeof(struct
> arp_hdr);
This does seem to be wrong and sizeof(struct ether_hdr) should have used. As the L2 header is normally 14 bytes in size.
A packet in DPDK must be at least 60 bytes in length is the hardware appends the Frame checksum (4 bytes) because all ethernet frames must be at least 64 bytes in the wire. Some hardware will pad the frame out the correct length then add the FCS (Frame Checksum) bytes. Some hardware will discard the frame and count it as a runt or fragment. Just to be safe I always make sure the length of the frame is 60 bytes at least using a software check.
Hope that helps you.
Also it looks like the3 ptpclient.c file may need to be fixed.
>
> arp_pkt->data_len = pkt_size;
> arp_pkt->pkt_len = pkt_size;
>
> Which is based on ptpclient.c sample code. However after setting all of
> the fields, the packet either doesn't get sent or has some of the data
> truncated from the end of the packet when viewed in Wireshark. If I modify
> the size to be the following:
>
> const size_t pkt_size = sizeof(struct ether_addr) + sizeof(struct
> arp_hdr) + 8;
>
> It works as expected. I'm wondering where the extra 8 bytes come from? Is
> there a better way to calculate the packet length?
>
> Using dpdk 18.08, Linux - kernel 4.15.0-33.
>
> Mike.
Regards,
Keith
next prev parent reply other threads:[~2018-09-29 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 10:19 Michael Barker
2018-09-29 10:39 ` Shyam Shrivastav
2018-09-29 14:39 ` Wiles, Keith [this message]
2018-09-29 20:10 ` Michael Barker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B269E5D3-43C5-4E50-8499-86D119E655BB@intel.com \
--to=keith.wiles@intel.com \
--cc=mikeb01@gmail.com \
--cc=users@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).