From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com [209.85.220.179]) by dpdk.org (Postfix) with ESMTP id 53A56F937 for ; Thu, 9 Feb 2017 12:42:54 +0100 (CET) Received: by mail-qk0-f179.google.com with SMTP id s186so1100514qkb.1 for ; Thu, 09 Feb 2017 03:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=domainhart-com.20150623.gappssmtp.com; s=20150623; h=from:mime-version:subject:message-id:date:to; bh=tbhfRvGTvaWZtoc54xmJYmtfRDsVbOiunKk3BbW/7bI=; b=O+yxwXh+j5wR+qeOIBhRrnz8NILofmtdWmIn4I9lWkYX9ViyqKFD8Tij6J2W6JA6pL PSOy2SnRCXceKHxQGx3sW5LKfYQE+VKAmz2YBxfw1RPTvPOHcQKx3/gqOTjNyCZotrgz quZJ9JfpTMC4Rmn27AAObxNfyFOgoSZnYPisR9E4eXkqAzaxFNHKloF/VaW4lJC4uX/z qQ6zPIcszmLlGmOYJHCL7GJMza7dmj8IxzgY1uFle9HrOpkfAwm7u+s7OAlI+8g3SvHu lXP8vGtpPNTePo34LmFUeNJVG0EmMNKMTldtzTnYjG+IRe2Y/7Ez9FDIFH2iGqepIWYA B6Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=tbhfRvGTvaWZtoc54xmJYmtfRDsVbOiunKk3BbW/7bI=; b=GweTY6W7bcIQhBs/2AvOo44cbNeIyah3vygTOmq8/69Mh0ene2Wqebfkfjq+MSw9/N dy9UXvNi6upLL439lnnaUqKsHY4VDsQueYwemSMnb2HZP6QauVywRv5gza9zmyLmizuc d9BHTIGR9cjN1gzvX2c6zDx7u0t4yo8pVzGmzNCUH/YeKOUvlTaQlODorHn3UMTZtU4H h68W1ZUNv8Q7PCSTKJpTzBAEDdtYpyykq507HHC861SkC8L4kVKjMqul2W867rsFrma7 OwBpwIO/4IP2grHskI67NlQuWq4LA28jsqac+zwdFyvj7wXfxVXL+2BQqxYrxOQQ6O9q DOww== X-Gm-Message-State: AMke39m5ej8R1+XdzrRb4Umyamnh5O+l26XfQI0ShxLtBQb54ZV1G8a8a+x7xVeXBDpBVw== X-Received: by 10.55.197.28 with SMTP id p28mr2234267qki.255.1486640573356; Thu, 09 Feb 2017 03:42:53 -0800 (PST) Received: from [192.168.1.165] (pool-72-93-238-105.bstnma.fios.verizon.net. [72.93.238.105]) by smtp.gmail.com with ESMTPSA id m62sm8868684qkf.31.2017.02.09.03.42.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Feb 2017 03:42:52 -0800 (PST) From: Anthony Hart Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Message-Id: Date: Thu, 9 Feb 2017 06:42:50 -0500 To: users@dpdk.org X-Mailer: Apple Mail (2.3259) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-users] Crash in FM10k - fm10k_rxtx_vec.c X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2017 11:42:54 -0000 Found a crash in the FM10k vector driver when it tries to send a packet = with a VLAN header priority (PCP) field value >=3D 4. This results in = the FM10k returning the following error. testpmd> PMD: fm10k_dev_interrupt_handler_pf(): INT: find fault! PMD: fm10k_dev_handle_fault(): THI_MAL_DIS_Q_FAULT: PF(0) Addr:0x0 Spec: = 0x0 The reason is the (pkt->vlan_tci << 16) value gets sign extended and = causes illegal values to be written into the TX descriptor. The = following is a patch to fix the issue. I don=E2=80=99t know what the = procedure is for getting this into the fix stream. --- ./drivers/net/fm10k/fm10k_rxtx_vec.c 2016-11-13 = 09:28:12.000000000 -0500 +++ ./drivers/net/fm10k/fm10k_rxtx_vec.c.new 2017-02-09 = 06:37:00.362960064 -0500 @@ -718,7 +718,7 @@ vtx1(volatile struct fm10k_tx_desc *txdp struct rte_mbuf *pkt, uint64_t flags) { __m128i descriptor =3D _mm_set_epi64x(flags << 56 | - pkt->vlan_tci << 16 | pkt->data_len, + (uint64_t)(pkt->vlan_tci) << 16 | = (uint64_t)pkt->data_len, MBUF_DMA_ADDR(pkt)); _mm_store_si128((__m128i *)txdp, descriptor); }=