From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f172.google.com (mail-qk0-f172.google.com [209.85.220.172]) by dpdk.org (Postfix) with ESMTP id B5EC12B88 for ; Wed, 22 Feb 2017 14:27:04 +0100 (CET) Received: by mail-qk0-f172.google.com with SMTP id u188so2299547qkc.2 for ; Wed, 22 Feb 2017 05:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=incapsula.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=dVvtmzNSba3pLOTeD//N3LaOciOCFH26tPAgvJombzU=; b=MwLBlwQt59NFrYsjZWi8YheR75fdj0nE9wI/27oEJKgjZKySNCcp+/ySxkAM0qx9s6 xNGJOy/20xdqBwEOk99PYKn/X9xJUJYPVn1dKGakVmwQUXxKYZFV0pt5tzxLRdPRz4xD KxBNJTb7kpZVRI64Mhx1HPEPLGvXC4kgtWYfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=dVvtmzNSba3pLOTeD//N3LaOciOCFH26tPAgvJombzU=; b=p+R7ua8lfIB2IUpgYLLyNvp/KtMjzLUutaCJ7HVF+++H6jCJQIecwLvQSZRS+aUyDx KUcGA6W5IEcBIhiarGcXV4zsdMbV5DcrlczWBCY3VFrhyzdzfMdKyoVpvmYLTHZT5M/M fw+3l7lpGuElUssDYKSAnLTq0AmyJO34h8jT5Hdl+P44Mmcg/XwUPNwaD0ia6DImwMTc YhEN6tKkAfRIu0DKl+rnFjkrL/CtZwaCjeXxhbtkgC+cIBMH9ELcDftY8JdBI02uuM40 0abgw/TnAoaiDm3IgLI5RxvcwFmJXc97XuyIZ5ZZyPH/i7M0v9oG8NDJgBvLwBzlrTJq sdSQ== X-Gm-Message-State: AMke39mkdrdDr6a1lfTUALzWOTBoUDazTsSO6zWqDhCb6XDzARsRedzhScyBVzdzSsoKdFK2cy3wIAgozGsH3j1P X-Received: by 10.55.181.6 with SMTP id e6mr28632707qkf.298.1487770024012; Wed, 22 Feb 2017 05:27:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.33.161 with HTTP; Wed, 22 Feb 2017 05:27:03 -0800 (PST) In-Reply-To: References: From: Eyal Leshem Date: Wed, 22 Feb 2017 15:27:03 +0200 Message-ID: To: users@dpdk.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-users] Checksum offloading on gre outer-ip in dpdk-16.11 X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 13:27:05 -0000 Hi , After some digging in the i40e driver code in 16.11 I found the problem - For checksum offloading on GRE packets in 16.11 there are 2 more parameters that need to be set on the mbuf (parameters that are not required in 16.07): 1. The mbuf->ol_flags PKT_TX_TUNNEL_GRE - must be set. 2. The mbuf->l2_len - must be set to gre header size (4 bytes). That's in addition to the parmas that should be defined in 16.07 - 1. mbuf->ol_flags -PKT_TX_OUTER_IPV4| PKT_TX_OUTER_IP_CKSUM 2. m->outer_l2_len - (The real L2 header size). 3. m->outer_l3_len - (The real L3 header size). It was much more helpful if those changes were documented in the release-notes and not just in a comment inside the driver-code (see i40e_parse_tunneling_params function at i40e_rxtx.c). Thanks Eyal On Wed, Feb 22, 2017 at 9:18 AM, Eyal Leshem wrote: > Hi all, > > I use checksum-offloading for calculating the checksum of packets that i > change/create inside my app. > I use it for regular packets and for gre packets (checksum is calculated > on the outer-header). > > On dpdk-16.07 everything works fine , But when i try to use that with > DPDK-16.11 it seems that the offloading on GRE packets does not work (while > on the regular packets it still works fine). > > In dpdk-16.07 I use the following flags on my mbuf to mark to the NIC that > the packets need checksum calculation (m is the "struct rte_mbuf"): > "m->ol_flags |= PKT_TX_OUTER_IPV4|PKT_TX_OUTER_IP_CKSUM;" > > On 16.11 I tried to add also the PKT_TX_TUNNEL_GRE (As i saw that addition > in "csumonly.c" in the 16.11 version in the "pmd-test" app) - but that also > didn't help. > > My NIC is : "Intel Corporation Ethernet Controller X710 for 10Gbe > backplane" > And i run my app in Ubuntu-14.0.4. > > Any Ideas? > > Thanks in advance - > Eyal >