From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f181.google.com (mail-io0-f181.google.com [209.85.223.181]) by dpdk.org (Postfix) with ESMTP id 9ED7D378B for ; Tue, 26 Jul 2016 21:33:28 +0200 (CEST) Received: by mail-io0-f181.google.com with SMTP id m101so38397766ioi.2 for ; Tue, 26 Jul 2016 12:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riotgames.com; s=riotgames; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Uz8pROkn+YUWegVH0ijnByxw1jcIbW4kRhvHwuuIeoQ=; b=s5Q4IGfXtFIG5ni0FtioGZfvhauCNNuwj2KXneVHQdeFNpyAZax5JGitGFjRkC/ts+ HOM0bzHZ8Dj6WYNKjBnpM+qE8UqHmlp4Yau5QqDrgAgm0Zz2sbIuMr+uMjXDtC/++IUj 5gWn2fqa4dP3m7cbhfR2WLm0V5pZvdNFa+qzM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Uz8pROkn+YUWegVH0ijnByxw1jcIbW4kRhvHwuuIeoQ=; b=QGQEP+xFhQfjk5XO//DyAj592j/TnYRABUpZWTtNsyD5M8dJkvt4kc9XjClMcf6jVm +usxk/nDJMDEAonwaWqdK79xKytocREV8TMzqDAklPImz+ZQiJ4tnKXtimRJI4iiFMrr 9Elv7S4ZETxBAhsDUI+3hkshzMV3WScuodBACpZZyvhirJMFoKT+Asss5uI4WRyv8pOr 8iYf4UwsYdn2xeI9eGuw5rUeIncHkFNc46g/Yqceq5dnl8iKjJOWWOeWoBsSNXav4rFe szdY7uSkA5D7IZDkRkdQqmnFbUzyGV654mpW0MvzETaFQGfDbBhwwVQK26SZILVTPGl/ mZ3g== X-Gm-Message-State: AEkoous5gOcaYEjWsE1cd/wIinrCOO7fBTexGV3CzXGejSwUGLVKZ+gPX1u97cnXAv63o4xG3ToHIMq3y2ekD3aO X-Received: by 10.107.15.157 with SMTP id 29mr27004892iop.123.1469561607664; Tue, 26 Jul 2016 12:33:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.166.145 with HTTP; Tue, 26 Jul 2016 12:33:08 -0700 (PDT) In-Reply-To: References: From: Javier Blazquez Date: Tue, 26 Jul 2016 12:33:08 -0700 Message-ID: To: "Wu, Xiaoban" Cc: "users@dpdk.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-users] compilation error while building mlx5 of dpdk-16.04 on Ubuntu 16.04 X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2016 19:33:29 -0000 I remember having this issue on Ubuntu 16.04 as well. It's fixed in DPDK 16.07 (there's an -rc5 version out already) but if I remember correctly I made a local patch for DPDK 16.04 to keep going. I _think_ it was this patch, but I'm not sure, you may want to try it: diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index c99ef7e..3a86609 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -39,7 +39,6 @@ #include #include #include -#include /* Verbs header. */ /* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */ diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 32af304..757f8e4 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -44,7 +44,6 @@ #include #include #include -#include #include #include #include @@ -657,7 +656,7 @@ mlx5_link_update_unlocked(struct rte_eth_dev *dev, int wait_to_complete) memset(&dev_link, 0, sizeof(dev_link)); dev_link.link_status = ((ifr.ifr_flags & IFF_UP) && (ifr.ifr_flags & IFF_RUNNING)); - ifr.ifr_data = &edata; + ifr.ifr_data = (void *)&edata; if (priv_ifreq(priv, SIOCETHTOOL, &ifr)) { WARN("ioctl(SIOCETHTOOL, ETHTOOL_GSET) failed: %s", strerror(errno)); @@ -864,7 +863,7 @@ mlx5_dev_get_flow_ctrl(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf) if (mlx5_is_secondary()) return -E_RTE_SECONDARY; - ifr.ifr_data = ðpause; + ifr.ifr_data = (void *)ðpause; priv_lock(priv); if (priv_ifreq(priv, SIOCETHTOOL, &ifr)) { ret = errno; @@ -915,7 +914,7 @@ mlx5_dev_set_flow_ctrl(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf) if (mlx5_is_secondary()) return -E_RTE_SECONDARY; - ifr.ifr_data = ðpause; + ifr.ifr_data = (void *)ðpause; ethpause.autoneg = fc_conf->autoneg; if (((fc_conf->mode & RTE_FC_FULL) == RTE_FC_FULL) || (fc_conf->mode & RTE_FC_RX_PAUSE)) diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c index c9cea48..f6b27bb 100644 --- a/drivers/net/mlx5/mlx5_mac.c +++ b/drivers/net/mlx5/mlx5_mac.c @@ -38,7 +38,6 @@ #include #include #include -#include #include #include On Tue, Jul 26, 2016 at 10:49 AM, Wu, Xiaoban wrote: > Dear DPDK Users, > > > I successfully built the mlx5 on Ubuntu 14.04 before, but when I tried to > build it on Ubuntu 16.04, I encountered these compilation errors. The > kernel version is 4.4.0-31-generic. Build command: make install > T=T=x86_64-native-linuxapp-gcc > > > > > CC mlx5.o > In file included from /usr/include/linux/if.h:31:0, > from dpdk-16.04/drivers/net/mlx5/mlx5.h:42, > from /dpdk-16.04/drivers/net/mlx5/mlx5.c:64: > /usr/include/linux/hdlc/ioctl.h:76:14: error: 'IFNAMSIZ' undeclared here > (not in a function) > char master[IFNAMSIZ]; /* Name of master FRAD device */ > ^ > In file included from /dpdk-16.04/drivers/net/mlx5/mlx5.c:64:0: > /dpdk-16.04/drivers/net/mlx5/mlx5.h:175:53: warning: 'struct ifreq' > declared inside parameter list > int priv_ifreq(const struct priv *, int req, struct ifreq *); > ^ > dpdk-16.04/drivers/net/mlx5/mlx5.h:175:53: warning: its scope is only this > definition or declaration, which is probably not what you want > dpdk-16.04/drivers/net/mlx5/mlx5.c: In function 'mlx5_pci_devinit': > dpdk-16.04/drivers/net/mlx5/mlx5.c:572:25: error: 'IFF_UP' undeclared > (first use in this function) > priv_set_flags(priv, ~IFF_UP, IFF_UP); > ^ > /dpdk-16.04/drivers/net/mlx5/mlx5.c:572:25: note: each undeclared > identifier is reported only once for each function it appears in > /dpdk-16.04/mk/internal/rte.compile-pre.mk:126: recipe for target > 'mlx5.o' failed > make[6]: *** [mlx5.o] Error 1 > /dpdk-16.04/mk/rte.subdir.mk:61: recipe for target 'mlx5' failed > make[5]: *** [mlx5] Error 2 > /dpdk-16.04/mk/rte.subdir.mk:61: recipe for target 'net' failed > make[4]: *** [net] Error 2 > /dpdk-16.04/mk/rte.sdkbuild.mk:77: recipe for target 'drivers' failed > make[3]: *** [drivers] Error 2 > /dpdk-16.04/mk/rte.sdkroot.mk:123: recipe for target 'all' failed > make[2]: *** [all] Error 2 > /dpdk-16.04/mk/rte.sdkinstall.mk:84: recipe for target 'pre_install' > failed > make[1]: *** [pre_install] Error 2 > dpdk-16.04/mk/rte.sdkroot.mk:98: recipe for target 'install' failed > make: *** [install] Error 2 > > Can anybody please tell me how to fix this? Thank you very much for your > help. > > All the best, > Xiaoban >