From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46]) by dpdk.org (Postfix) with ESMTP id A17861B343 for ; Thu, 2 Nov 2017 08:31:14 +0100 (CET) Received: by mail-pg0-f46.google.com with SMTP id j3so4346278pga.1 for ; Thu, 02 Nov 2017 00:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=A8tQrAh7ZWGNEqafpEuioJhMWXI8YyeS3nFR3vmhp0k=; b=O1iACd9ZB2R5i/Nx4WCaUB/H7xFtY0SLJeeq+M8Y8cdZEggRTVAsb0csT7VHYAi/rc KiHQ8XgLArRw1k3r+qeIgcbwR4ZKChJs0RvjqrlDUj1k332Q1dYQhDC3EKFLcVeLouFp NEOmwdX4FXe988ZTeI/OW01J62dzRArlD/ItHyXhJsIxryxnB9aYGVoCEg16Oaq/HBo9 tWk15L/whixbuD7Z7bN24uWSKSK+OTydgMjINLLehOuzV4xjNuSqAiSIf7WZXLcN59nl bkPiu7WSadTb/ucxGQBOdcK9CjuenXuyXBsEx9BvRjWuDPGARNKBehdJMChVU03wJpSE Im5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=A8tQrAh7ZWGNEqafpEuioJhMWXI8YyeS3nFR3vmhp0k=; b=bMLLacA+X0JpzZ7DCZnIbRwavEO7PeCRW6u9uULjxmE9FWZgS8g9rH4m86AB1u1bYl kukL+6f5RPS5hRqMgcwojDHYPEtnTeodaIrAnNRpbKFloI5C0SjajqZAqdrmwC1v4scx 3JAm/ixK38RqEV/2KsBtUWPpaDU00Q50bULkWdQilZEVJCtmvMi4Qi6WlcT9DcWxg84s ohvRdM+KVgy3kPLf+yJT/AM3Wl0iOETB29ITKX4kMTa+K9O4DTsFopZFvmSaTHhDMf53 ObnFIcOUv6ioiy93x+10f8eIAI1tD8TRE/eGe+xsFfazrC8fQpHUo5nzlooB86XOgRVU CCmw== X-Gm-Message-State: AMCzsaXCPhxuQxnr1/EYoVnB5SOAEleLCmYQURpQRnUhudTg8mlviCC+ OC+UA5QcRNYtHWNfg0VxP1Ox8+wE/BbrmQwx4AWVyBnL X-Google-Smtp-Source: ABhQp+RIle4NKVdOdloKyDiny6rgEKjsCR7+8fXaB4EcFvcUrm+bZu6N//hhw3xNubt+nJvWOSwGp5rbzRr+zRRnunU= X-Received: by 10.98.59.65 with SMTP id i62mr2759723pfa.143.1509607873570; Thu, 02 Nov 2017 00:31:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.181.108 with HTTP; Thu, 2 Nov 2017 00:31:12 -0700 (PDT) Received: by 10.100.181.108 with HTTP; Thu, 2 Nov 2017 00:31:12 -0700 (PDT) In-Reply-To: References: <20171031225048.34120581@shemminger-XPS-13-9360> From: Stephen Hemminger Date: Thu, 2 Nov 2017 08:31:12 +0100 Message-ID: To: James Bensley Cc: users Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-users] DPDK support for 82579 X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 07:31:14 -0000 On Nov 1, 2017 22:11, "James Bensley" wrote: On 31 October 2017 at 21:50, Stephen Hemminger wrote: > First off, I assume the device works for normal Linux networking. > Then check the PCI-id value for the device and see if it is present in drivers/net/e1000 > in DPDK. If not, then it maybe as simple as adding the necessary ID value to the > table. Also, check current git. > > It maybe more complex where some PHY code has to be backported from > BSD into DPDK. Unfortunately, the device support in DPDK lags behind Linux > and BSD. There are many variants and even Intel doesn't have resources to > keep DPDK up to all the current PCI id values. Hi Stephen, That has worked! Yes this is a working NIC built into a laptop. bensley@ubuntu-laptop:/opt/dpdk/dpdk-17.08/drivers/net/e1000$ lspci -nn | grep Eth 00:19.0 Ethernet controller [0200]: Intel Corporation 82579LM Gigabit Network Connection [8086:1502] (rev 04) bensley@ubuntu-laptop:/opt/dpdk/dpdk-17.08/drivers/net/e1000$ grep -r 1502 * base/e1000_hw.h:#define E1000_DEV_ID_PCH2_LV_LM 0x1502 ^ This PCI-id is alread "known" but not mapped to the driver so I just added the two lines to em_ethdev.c below, recompiled DPDK and Pktgen and it works... bensley@ubuntu-laptop:/opt/dpdk/dpdk-17.08/drivers/net/e1000$ grep -r E1000_DEV_ID_PCH2_LV_LM * base/e1000_hw.h:#define E1000_DEV_ID_PCH2_LV_LM 0x1502 base/e1000_api.c: case E1000_DEV_ID_PCH2_LV_LM: em_ethdev.c: { RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_PCH2_LV_LM) }, em_ethdev.c: case E1000_DEV_ID_PCH2_LV_LM: Thanks very much for your help! Cheers, James. It would be good if you could send a full patch to dev@dpdk.org