Re: [dpdk-users] compilation error while building mlx5 of dpdk-16.04 on Ubuntu 16.04

["Wu, Xiaoban" <Xiaoban_Wu@student.uml.edu>]

Dear Javier,


Thanks very much to your help, the compilation problem has been solved.


All the best,

Xiaoban

________________________________
From: Javier Blazquez <jblazquez@riotgames.com>
Sent: Tuesday, July 26, 2016 3:34:01 PM
To: Wu, Xiaoban
Cc: users@dpdk.org
Subject: Re: [dpdk-users] compilation error while building mlx5 of dpdk-16.04 on Ubuntu 16.04

One more diff:

diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
index 9b4455b..6c63dcc 100644
--- a/drivers/net/mlx5/Makefile
+++ b/drivers/net/mlx5/Makefile
@@ -60,6 +60,8 @@ CFLAGS += -O3
 CFLAGS += -std=gnu99 -Wall -Wextra
 CFLAGS += -g
 CFLAGS += -I.
+CFLAGS += -D_BSD_SOURCE
+CFLAGS += -D_DEFAULT_SOURCE
 CFLAGS += -D_XOPEN_SOURCE=600
 CFLAGS += $(WERROR_FLAGS)
 CFLAGS += -Wno-strict-prototypes


On Tue, Jul 26, 2016 at 12:33 PM, Javier Blazquez <jblazquez@riotgames.com<mailto:jblazquez@riotgames.com>> wrote:
I remember having this issue on Ubuntu 16.04 as well. It's fixed in DPDK 16.07 (there's an -rc5 version out already) but if I remember correctly I made a local patch for DPDK 16.04 to keep going. I _think_ it was this patch, but I'm not sure, you may want to try it:

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index c99ef7e..3a86609 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -39,7 +39,6 @@
 #include <limits.h>
 #include <net/if.h>
 #include <netinet/in.h>
-#include <linux/if.h>

 /* Verbs header. */
 /* ISO C doesn't support unnamed structs/unions, disabling -pedantic. */
diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index 32af304..757f8e4 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -44,7 +44,6 @@
 #include <sys/ioctl.h>
 #include <sys/socket.h>
 #include <netinet/in.h>
-#include <linux/if.h>
 #include <linux/ethtool.h>
 #include <linux/sockios.h>
 #include <fcntl.h>
@@ -657,7 +656,7 @@ mlx5_link_update_unlocked(struct rte_eth_dev *dev, int wait_to_complete)
        memset(&dev_link, 0, sizeof(dev_link));
        dev_link.link_status = ((ifr.ifr_flags & IFF_UP) &&
                                (ifr.ifr_flags & IFF_RUNNING));
-       ifr.ifr_data = &edata;
+       ifr.ifr_data = (void *)&edata;
        if (priv_ifreq(priv, SIOCETHTOOL, &ifr)) {
                WARN("ioctl(SIOCETHTOOL, ETHTOOL_GSET) failed: %s",
                     strerror(errno));
@@ -864,7 +863,7 @@ mlx5_dev_get_flow_ctrl(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        if (mlx5_is_secondary())
                return -E_RTE_SECONDARY;

-       ifr.ifr_data = &ethpause;
+       ifr.ifr_data = (void *)&ethpause;
        priv_lock(priv);
        if (priv_ifreq(priv, SIOCETHTOOL, &ifr)) {
                ret = errno;
@@ -915,7 +914,7 @@ mlx5_dev_set_flow_ctrl(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf)
        if (mlx5_is_secondary())
                return -E_RTE_SECONDARY;

-       ifr.ifr_data = &ethpause;
+       ifr.ifr_data = (void *)&ethpause;
        ethpause.autoneg = fc_conf->autoneg;
        if (((fc_conf->mode & RTE_FC_FULL) == RTE_FC_FULL) ||
            (fc_conf->mode & RTE_FC_RX_PAUSE))
diff --git a/drivers/net/mlx5/mlx5_mac.c b/drivers/net/mlx5/mlx5_mac.c
index c9cea48..f6b27bb 100644
--- a/drivers/net/mlx5/mlx5_mac.c
+++ b/drivers/net/mlx5/mlx5_mac.c
@@ -38,7 +38,6 @@
 #include <inttypes.h>
 #include <errno.h>
 #include <netinet/in.h>
-#include <linux/if.h>
 #include <sys/ioctl.h>
 #include <arpa/inet.h>


On Tue, Jul 26, 2016 at 10:49 AM, Wu, Xiaoban <Xiaoban_Wu@student.uml.edu<mailto:Xiaoban_Wu@student.uml.edu>> wrote:
Dear DPDK Users,


I successfully built the mlx5 on Ubuntu 14.04 before, but when I tried to build it on Ubuntu 16.04, I encountered these compilation errors. The kernel version is 4.4.0-31-generic. Build command: make install T=T=x86_64-native-linuxapp-gcc




  CC mlx5.o
In file included from /usr/include/linux/if.h:31:0,
                 from dpdk-16.04/drivers/net/mlx5/mlx5.h:42,
                 from /dpdk-16.04/drivers/net/mlx5/mlx5.c:64:
/usr/include/linux/hdlc/ioctl.h:76:14: error: 'IFNAMSIZ' undeclared here (not in a function)
  char master[IFNAMSIZ]; /* Name of master FRAD device */
              ^
In file included from /dpdk-16.04/drivers/net/mlx5/mlx5.c:64:0:
/dpdk-16.04/drivers/net/mlx5/mlx5.h:175:53: warning: 'struct ifreq' declared inside parameter list
 int priv_ifreq(const struct priv *, int req, struct ifreq *);
                                                     ^
dpdk-16.04/drivers/net/mlx5/mlx5.h:175:53: warning: its scope is only this definition or declaration, which is probably not what you want
dpdk-16.04/drivers/net/mlx5/mlx5.c: In function 'mlx5_pci_devinit':
dpdk-16.04/drivers/net/mlx5/mlx5.c:572:25: error: 'IFF_UP' undeclared (first use in this function)
   priv_set_flags(priv, ~IFF_UP, IFF_UP);
                         ^
/dpdk-16.04/drivers/net/mlx5/mlx5.c:572:25: note: each undeclared identifier is reported only once for each function it appears in
/dpdk-16.04/mk/internal/rte.compile-pre.mk:126<http://rte.compile-pre.mk:126>: recipe for target 'mlx5.o' failed
make[6]: *** [mlx5.o] Error 1
/dpdk-16.04/mk/rte.subdir.mk:61<http://rte.subdir.mk:61>: recipe for target 'mlx5' failed
make[5]: *** [mlx5] Error 2
/dpdk-16.04/mk/rte.subdir.mk:61<http://rte.subdir.mk:61>: recipe for target 'net' failed
make[4]: *** [net] Error 2
/dpdk-16.04/mk/rte.sdkbuild.mk:77<http://rte.sdkbuild.mk:77>: recipe for target 'drivers' failed
make[3]: *** [drivers] Error 2
/dpdk-16.04/mk/rte.sdkroot.mk:123<http://rte.sdkroot.mk:123>: recipe for target 'all' failed
make[2]: *** [all] Error 2
/dpdk-16.04/mk/rte.sdkinstall.mk:84<http://rte.sdkinstall.mk:84>: recipe for target 'pre_install' failed
make[1]: *** [pre_install] Error 2
dpdk-16.04/mk/rte.sdkroot.mk:98<http://rte.sdkroot.mk:98>: recipe for target 'install' failed
make: *** [install] Error 2

Can anybody please tell me how to fix this? Thank you very much for your help.

All the best,
Xiaoban