Re: [dpdk-users] PF link status is not getting detected correctly by dpdk driver in VM

["Van Haaren, Harry" <harry.van.haaren@intel.com>]

> From: users [mailto:users-bounces@dpdk.org] On Behalf Of Tushar Mulkar
> Sent: Thursday, January 11, 2018 1:55 PM
> To: users@dpdk.org
> Subject: Re: [dpdk-users] PF link status is not getting detected correctly
> by dpdk driver in VM
> 
> Hi All,

Hi!


> So finally I am able to find the issue.  Actually in dpdk i40evf driver,
> the way link up/down is propagated is not working for me. Below change set
> worked for me.

Please send a patch to dev@dpdk.org (http://dpdk.org/doc/guides/contributing/patches.html)

In the commit message, please describe the issue a bit more, and how the patch
fixes it. Also add a "signoff" so it can be accepted into the DPDK source.

Also CC the i40e maintainers to bring it to their attention.
From the MAINTAINERS file, i40e heading:
Beilei Xing <beilei.xing@intel.com>
Qi Zhang <qi.z.zhang@intel.com>


Regards, -Harry


> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> b/drivers/net/i40e/i40e_ethdev_vf.c
> index 87a760796..0389f4bfa 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -2235,13 +2235,13 @@ i40evf_dev_link_update(struct rte_eth_dev *dev,
>                 new_link.link_speed = ETH_SPEED_NUM_100M;
>                 break;
>         }
> +
>         /* full duplex only */
>         new_link.link_duplex = ETH_LINK_FULL_DUPLEX;
> -       new_link.link_status = vf->link_up ? ETH_LINK_UP :
> -                                            ETH_LINK_DOWN;
> +    new_link.link_status = (vf->link_up & true) ? ETH_LINK_UP :
> +                                            ETH_LINK_DOWN;
> 
>         i40evf_dev_atomic_write_link_status(dev, &new_link);
> -
>         return 0;
>  }
> 
> 

<snip>