From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0FB74A0471 for ; Wed, 14 Aug 2019 05:19:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71E501BE8B; Wed, 14 Aug 2019 05:19:51 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20061.outbound.protection.outlook.com [40.107.2.61]) by dpdk.org (Postfix) with ESMTP id A19331BE8B for ; Wed, 14 Aug 2019 05:19:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LESZTyCSkVT5diRBJ3LI5oPZyjJt+61nf/r+J98vYr8=; b=NsIXeOcXmluiSDxTV8sQYCej5cSiBAnQJg2i+KcnCbvhGyKUdC7IFO99w2vdFyIis+wEjT7AMiV7H5bnEqXw6wRbcSDU9jjtPWIkpGczHxqSfdN00DVPWaGV9Rn0v0ikG6fl47khAO7b3cOuPs+RYoNl0YGSQHIQgVSSVZup4U4= Received: from DB7PR08CA0007.eurprd08.prod.outlook.com (2603:10a6:5:16::20) by VI1PR0801MB1856.eurprd08.prod.outlook.com (2603:10a6:800:57::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.14; Wed, 14 Aug 2019 03:19:47 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::208) by DB7PR08CA0007.outlook.office365.com (2603:10a6:5:16::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2157.13 via Frontend Transport; Wed, 14 Aug 2019 03:19:47 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18 via Frontend Transport; Wed, 14 Aug 2019 03:19:45 +0000 Received: ("Tessian outbound 1e6e633a5b56:v26"); Wed, 14 Aug 2019 03:19:42 +0000 X-CR-MTA-TID: 64aa7808 Received: from 09b332d4b919.1 (cr-mta-lb-1.cr-mta-net [104.47.9.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7D764A8E-B932-49BE-9382-C516365B4DB1.1; Wed, 14 Aug 2019 03:19:37 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2059.outbound.protection.outlook.com [104.47.9.59]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 09b332d4b919.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 14 Aug 2019 03:19:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a+fQr53riCxXw4UFEZR9dZFDT0lKawpbOdwVPqQj4Vs4GusTHtrKGJ0MEQPguNCQG79uL/ZG0rj/6nATew8clDyXtNvJT/g2r/8Xi6yueS7GWBSZ2jr/dQxyAzj+GGUDdzocqHszU1TWcBK23SSXq09Frn2pm4KfCfSVpmwp0y7h+y94q4s0NLpir/ohRaUl3OBJl6LGbosiGWy611bRv0JFDzJeuUy7p8SpqZfB5uGApExaka0geuCPAgnwWk4DWwTtaFkFGhfLLtqYDy+OtVnvECz4AFQu8Xeu2sDVldhmeEXytGbbSpCxmVnd+lB+MmK2rSZo4wsAWpkORFoOSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4HJGRfgEJBcF09tIaxhD8SKjZidtBqumAvMHBTr5l8=; b=IeluiK//uEfiKBMfJALUOWTJeZUTAzRc6sgkEjjLzNotSRy5vMsSvKMC5KafVVdJi/2mtRTo2TzJZMVtsXp3rcsd3Z1RTRO26YJJqCKlVaqtih+m4AF0+75h4p/VXkKxLr6QoGYZVaTkuGX732/sejxkn+gfhyQN/Bozok/dCA7F/n9UBNAZPzl6HZbWp7huxO6NuTkFUYPfBAfuaN6q/Sq5pYqy7xrij8eyBzOh+SHt3E09acOWUXGB7bA8T2yJxJiWiOYd9f7Z/Hkr6BJ1HDSS1j6N836BvBWevY2IJdklELGgZ3Ul91Tbxhc9AGG51C7AdlAXk88VCjgjKsZjqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f4HJGRfgEJBcF09tIaxhD8SKjZidtBqumAvMHBTr5l8=; b=pMIv7pXFPmF0bWubH4IVkiPh89JUV08qDj9HFnB3t5RXg/39f0RyhiOnZw+HlxiAiI+Qp66jzbLVsNzwj10/yopTNRsfEEtkTdxglCS8N3J9WC6xG31jjZ3n1b4HdKCHdxbe12ggOXjzuBIlac4h4ap/T3MtAqkGWnhgofMvrE4= Received: from VI1PR08MB5376.eurprd08.prod.outlook.com (52.133.244.200) by VI1PR08MB3584.eurprd08.prod.outlook.com (20.177.61.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.16; Wed, 14 Aug 2019 03:19:34 +0000 Received: from VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::8130:867e:2371:9c0]) by VI1PR08MB5376.eurprd08.prod.outlook.com ([fe80::8130:867e:2371:9c0%2]) with mapi id 15.20.2157.022; Wed, 14 Aug 2019 03:19:34 +0000 From: "Gavin Hu (Arm Technology China)" To: "Zhang, Qi Z" , "Richardson, Bruce" , "Ananyev, Konstantin" CC: "users@dpdk.org" , Honnappa Nagarahalli , "Phil Yang (Arm Technology China)" , "Ruifeng Wang (Arm Technology China)" Thread-Topic: i40e vPMD fix out of order Rx read issue Thread-Index: AdVCzJhDNbgBl9FATkWplfpJPawhKgAEGCLwAC59RaAAIKjSIAOMKbFQ Date: Wed, 14 Aug 2019 03:19:34 +0000 Message-ID: References: <039ED4275CED7440929022BC67E7061153D71548@SHSMSX105.ccr.corp.intel.com> <039ED4275CED7440929022BC67E7061153D7485E@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153D7485E@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: c0774c80-c5a8-419a-ad2f-b01ae0dab871.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 93f8ef26-dd8e-44d8-47a6-08d7206641e3 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VI1PR08MB3584; X-MS-TrafficTypeDiagnostic: VI1PR08MB3584:|VI1PR0801MB1856: X-MS-Exchange-PUrlCount: 5 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 01294F875B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(39860400002)(346002)(376002)(136003)(199004)(189003)(13464003)(3846002)(66066001)(5024004)(6436002)(66476007)(76116006)(66556008)(66946007)(55016002)(6116002)(64756008)(66446008)(486006)(8936002)(102836004)(55236004)(76176011)(53936002)(26005)(6306002)(53546011)(6506007)(316002)(186003)(81156014)(33656002)(81166006)(25786009)(9686003)(478600001)(7696005)(476003)(99286004)(8676002)(256004)(6246003)(52536014)(74316002)(14454004)(4326008)(14444005)(229853002)(71200400001)(71190400001)(110136005)(2906002)(966005)(305945005)(11346002)(5660300002)(86362001)(7736002)(446003)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB3584; H:VI1PR08MB5376.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: yigZB+pQW2n1zVdqMoKY3vfI1hKeXlMbDuyNS864huLGubcAPyzSa+x4A3sZlb60AWuiJZqI1kEc4S5cyJxIj11eNrPKBG8cXFaA+QKYsAqLbnABzPVFjwIHiVNtsoYC0U1RQxSSrsgY84+0/8zUjUkOHLI3/Sy4UZo04Y+KPXC2E0YVB/60sS98/YP+Soc0KPo7VR1pLeiD82W9qJatqQjvXtxPdh65IbmLK27gLPdsYHoWLK8JQMxO9OABXRqkgWt4mg/Rsa9nX3qNVm7HlfdrWVVpih1a6I06GM183Phvv3slM3rYhhgua2PEyYlUGFC2s253KgwPLuuX/xPTO0WTY7nVGzvpaKLLp5GtT1U+1vgBt5wOcGxviKCMr6qrPG8kvQd3sOPYni2xsuD3joNasDYk/WdGifdKXyeyoKo= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3584 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Gavin.Hu@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(39860400002)(376002)(346002)(2980300002)(189003)(40434004)(13464003)(199004)(476003)(336012)(74316002)(25786009)(229853002)(446003)(14454004)(966005)(5024004)(14444005)(47776003)(102836004)(26826003)(4326008)(33656002)(305945005)(7736002)(66066001)(186003)(6116002)(478600001)(126002)(486006)(53546011)(63370400001)(63350400001)(23726003)(6506007)(8676002)(22756006)(7696005)(3846002)(26005)(76176011)(11346002)(110136005)(97756001)(50466002)(316002)(36906005)(76130400001)(5660300002)(70206006)(356004)(81156014)(81166006)(8936002)(2906002)(86362001)(46406003)(52536014)(99286004)(6246003)(54906003)(55016002)(70586007)(8746002)(9686003)(6306002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0801MB1856; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 5f848faf-7710-4f04-b6b5-08d720663b48 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(710020)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR0801MB1856; X-Forefront-PRVS: 01294F875B X-Microsoft-Antispam-Message-Info: 41G8hzIGc3cpxvEQRUKRmmt9f2ZAMN6rlS3CqIp6Ttudg/5Tsloudlix3O0u1S+5Z/425/9vWJauZuq1hfNl/dqswxD6aUAlz5xemBDpmFrIWIZkBzUNgUUTX0nMR8OKeOgAaUdrnVEfIFf/tbaxRjhPNNTuhY0Cap+mVuKJ8rV6VAPkV8Hk2zQjQho8abRR285tHv5gqxB9setXbap/0OfZNybz/qaKMJlGj3SO8bNwpgFA9NlpkkVfEkzC1FuTwmJa2BIswLL+/uMD0GSG6tjJtk/IjngznLhOTFZLy8fFEFq1wJHVSAiAaDaMJmk4cG1Rtion7dz7V9vjimvr4Cr7a3RRUzbcQWVxmSc3KlfdQahLrcs0MCuudoGvn9svyx4wuaH1/Jvq0PjaanX5TzgV5tv39EOl506yJnauwgo= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2019 03:19:45.9110 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93f8ef26-dd8e-44d8-47a6-08d7206641e3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1856 Subject: Re: [dpdk-users] i40e vPMD fix out of order Rx read issue X-BeenThere: users@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK usage discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: users-bounces@dpdk.org Sender: "users" Hi Qi, > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, July 27, 2019 9:33 AM > To: Gavin Hu (Arm Technology China) ; Richardson, > Bruce ; Ananyev, Konstantin > > Cc: users@dpdk.org; Honnappa Nagarahalli > ; Phil Yang (Arm Technology China) > ; Ruifeng Wang (Arm Technology China) > > Subject: RE: i40e vPMD fix out of order Rx read issue > > > > > -----Original Message----- > > From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > > Sent: Friday, July 26, 2019 6:01 PM > > To: Zhang, Qi Z ; Richardson, Bruce > > ; Ananyev, Konstantin > > > > Cc: users@dpdk.org; Honnappa Nagarahalli > > ; Phil Yang (Arm Technology China) > > ; Ruifeng Wang (Arm Technology China) > > > > Subject: RE: i40e vPMD fix out of order Rx read issue > > > > Hi Qi, > > > > Thanks for your explanation! > > I did some testing and found the barriers caused a big drop in RFC2544 = NDR > > performance on aarch64, how about it on X86? > For x86, I think we don't have performance drop, the memory barrier just > change the compiler's behavior to avoid generate out of order read > instructions, and x86 guarantee no out of read execution, so it does not = add > new instructions that cost CPU cycles. > > > Is it possible to count DD bits in a way of surviving across the out-of= -order > > descriptors reading? > > I think it is possible, but this will impact performance on x86, > but for aarch64, you can try out to see if that benefit and do proper > optimization on related vPMD implementation. The patches for aarch64 are in community review, and performances gain were= measured both for ixgbe and i40e vPMD. Very appreciate if you can further review and= comment. Here are the patch links: IXGBE vPMD: http://patches.dpdk.org/patch/57649/ http://patches.dpdk.org/patch/57650/ I40e vPMD: http://patches.dpdk.org/cover/57651/ http://patches.dpdk.org/patch/57652/ > > > > Best Regards, > > Gavin > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Thursday, July 25, 2019 8:11 PM > > > To: Gavin Hu (Arm Technology China) ; Richardson, > > > Bruce ; Ananyev, Konstantin > > > > > > Cc: users@dpdk.org; Honnappa Nagarahalli > > > ; Phil Yang (Arm Technology China) > > > > > > Subject: RE: i40e vPMD fix out of order Rx read issue > > > > > > Hi Gavin: > > > > > > in vPMD, we read 4 or 8 packets as batch, we count DD bits for packet > > > received, but not check the if they are continues or not, we assume i= t > > > should always be 1000, 1100, 1110, 1111 ....(take batch size is 4 as > > > example) while the out of order read instruction generated by compile= r > > > will cause driver to get un-continues DD bits, like 1011, the > > > descriptor on the hole actually is invalid since when it is read , > > > descriptor is not write back yet, but we still process this as 1110, = it cause > an > > corrupted mbuf returned. > > > > > > hope this is helpful. > > > > > > Regards > > > Qi > > > > > > > -----Original Message----- > > > > From: Gavin Hu (Arm Technology China) [mailto:Gavin.Hu@arm.com] > > > > Sent: Thursday, July 25, 2019 5:57 PM > > > > To: Zhang, Qi Z ; Richardson, Bruce > > > > ; Ananyev, Konstantin > > > > > > > > Cc: users@dpdk.org; Honnappa Nagarahalli > > > > ; Phil Yang (Arm Technology China) > > > > > > > > Subject: i40e vPMD fix out of order Rx read issue > > > > > > > > Hi Qi, > > > > > > > > I am working on optimizing the i40e vPMD on aarch64 and I see this > > > > patch relevant. > > > > Could you illuminate what issue this patch was fixing? > > > > I understand the PMD works at the driver layer, for delivery of L2 > packets. > > > > It does not own the responsibility to keep order(the responsibility > > > > lies with > > > the > > > > protocol stack, like TCP)? > > > > > > > > http://patches.dpdk.org/patch/16665/ > > > > > > > > Best regards, > > > > Gavin > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments ar= e > > > > confidential and may also be privileged. If you are not the intende= d > > > > recipient, please notify the sender immediately and do not disclose > > > > the contents to any other person, use it for any purpose, or store > > > > or copy the information in any medium. Thank you. > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended > recipient, > > please notify the sender immediately and do not disclose the contents t= o > any > > other person, use it for any purpose, or store or copy the information = in any > > medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.