From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 62741C55C for ; Fri, 19 Feb 2016 16:42:59 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id g62so76693270wme.0 for ; Fri, 19 Feb 2016 07:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=7ppQqVkaEoWOycpHJwZ7UIJtJvwBtwZNykrak+WONq0=; b=VhrbDusdruqeCbud1pXyjYLx9bO/k9UDMVDK4UbImXu/OOWvZwvrMbFT5dZxsBXJfp oB+7mhJdZuETFnh/8ONlV/iYKh+j/Zx6lNVVWDZtW2QjCRAigpHRr3G46hBdDfsyeAa/ 66TxxXAFgZCSFkMnAwJKd6Ozo/epQS/XU50Bct6J5uxdAP0cZ6/0UZFfzqw4ozAa//mq rsg3N+lTGNHe8jcfRveldmRKRSCSNoHni2Iwww69TfeKOPsam15NOH6Ss2H/J91pmV9e Y7Ie7qnWX3dWUMG0WshsiFHMyuFuNkoDX50G6tXYWwcbdv6dlGIg6JXYDt/FwqUNLsty jZWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=7ppQqVkaEoWOycpHJwZ7UIJtJvwBtwZNykrak+WONq0=; b=lifxKpRpaJpxoHlW18K5gPpfoQqxaUfFZ47oRvuAKXnrxZ9rvk02FAK2GnnHEjwjnN FIoKcUJxQJcb7DbRKARUXmZdoIUh3rYtM8sGa60o8JJvLMHQl8U5yXzOPDktkXp8fVFH enJTjFUIpUg1Ue6ctWeMVcMPRmMPrNthopGXpISqgO23shf3NItIsJCWW3Wpg/4qFmdx jekDON16PQnXbVaf67sK6EGvM2oFEa05EShMQLNS/IwgNP6mwgdC0KK4aUsx5VnYLdbb KqO3A75KlpKQvVSY5QYZJ+dcsyoi5EbH4yaUJEyMfxWIdd9KsClaGa0SPgofXIxwLxu/ tZbw== X-Gm-Message-State: AG10YOSa2DreFgJamROGJ53Z/kOVSNbd/XfYCJYgWsRDNxnfasOwDgybPcTNGcpTTKomu+rD X-Received: by 10.194.185.237 with SMTP id ff13mr15478745wjc.129.1455896579244; Fri, 19 Feb 2016 07:42:59 -0800 (PST) Received: from xps13.localnet (111.204.154.77.rev.sfr.net. [77.154.204.111]) by smtp.gmail.com with ESMTPSA id m67sm8128907wma.10.2016.02.19.07.42.57 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Feb 2016 07:42:58 -0800 (PST) From: Thomas Monjalon To: Harry van Haaren Date: Fri, 19 Feb 2016 16:41:24 +0100 Message-ID: <3007148.IAHfjgh8Jf@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <4769307.x4D9cxKz1O@xps13> References: <1455892502-14350-1-git-send-email-harry.van.haaren@intel.com> <4769307.x4D9cxKz1O@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: web@dpdk.org Subject: Re: [dpdk-web] [PATCH] download: add icons to main 3 links X-BeenThere: web@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: website maintenance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 15:42:59 -0000 2016-02-19 16:36, Thomas Monjalon: > 2016-02-19 14:35, Harry van Haaren: > > This patch integrates icons from the Google material icon set > > for the download, quick-start, and web-browsing links. > > I agree on the idea. > > > The links are layed out using panes horizontally, and re-ordered: > > Download | Quick Start | Older versions and Web interface > > "Web interface" does not well describe the cgit link. > What about this kind of title? "Other Versions & git" > > > Defines a new .well CSS attribute for panes behind icons. > > What means "well"? Why not button? > > > Signed-off-by: Harry van Haaren > > --- > > > > There are multiple ways to link to the Google icons, this patch > > includes the stylesheet, as it its the most flexible for using > > multiple icons. > > > > Other options are to save the SVG code directly in the page > > (cannot resize icon easily) or save the .svg to a file and > > display it (requires adding each icon to be used manually). > > Unless you feel strongly against including the stylesheet, > > this is the most effective solution. > > Yes the stylesheet include looks good. > > > +.well { > > + background-color: rgba(0, 35, 60, 0.07); > > + text-align: center; > > + padding-top: 1em; > > + padding-bottom: 1em; > > + margin-left: 0.7em; > > + margin-right: 0.7em; > > + box-shadow: inset 2px 2px 2px rgba(0,0,0,0.3); > > + border-radius: 0.7em 0.7em 0.7em 0.7em; > > + color : #00233b; > > +} > > I think the orange hover effect is missing. I forgot to say that a margin is missing below the big buttons. > Thanks Harry for bringing some fresh air :)