From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"ci@dpdk.org" <ci@dpdk.org>,
Lincoln Lavoie <lylavoie@iol.unh.edu>,
"dpdklab@iol.unh.edu" <dpdklab@iol.unh.edu>
Cc: nd <nd@arm.com>,
"zoltan.kiss@schaman.hu" <zoltan.kiss@schaman.hu>,
nd <nd@arm.com>
Subject: Re: [dpdk-ci] [PATCH] ring: fix size of name array in ring structure
Date: Tue, 19 Oct 2021 07:01:21 +0000 [thread overview]
Message-ID: <273dc081fab040e3969541a234f9ad44@intel.com> (raw)
In-Reply-To: <DBAPR08MB5814D46BE1E11C10ACE9644598BC9@DBAPR08MB5814.eurprd08.prod.outlook.com>
I saw a lot of patches failed on test_scatter_mbuf_2048, the case could be passed in intel lab.
This is maintained by UNL guys.
+ unl.
> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: 2021年10月18日 22:54
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; dev@dpdk.org;
> andrew.rybchenko@oktetlabs.ru; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: nd <nd@arm.com>; zoltan.kiss@schaman.hu; Tu, Lijuan
> <lijuan.tu@intel.com>; nd <nd@arm.com>
> Subject: RE: [PATCH] ring: fix size of name array in ring structure
>
> This patch has a CI failure in DTS in test_scatter_mbuf_2048 for Fortville_Spirit
> NIC. I am not sure how this change is related to the failure. The log is as follows:
>
> TestScatter: Test Case test_scatter_mbuf_2048 Result FAILED: 'packet receive
> error'
>
> Has anyone seen this error? Is this a known issue?
>
> Thanks,
> Honnappa
>
> > -----Original Message-----
> > From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Sent: Thursday, October 14, 2021 3:56 PM
> > To: dev@dpdk.org; Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;
> > andrew.rybchenko@oktetlabs.ru; konstantin.ananyev@intel.com
> > Cc: nd <nd@arm.com>; zoltan.kiss@schaman.hu
> > Subject: [PATCH] ring: fix size of name array in ring structure
> >
> > Use correct define for the name array size. The change breaks ABI and
> > hence cannot be backported to stable branches.
> >
> > Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data
> > types")
> > Cc: zoltan.kiss@schaman.hu
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > ---
> > lib/ring/rte_ring_core.h | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h index
> > 31f7200fa9..46ad584f9c 100644
> > --- a/lib/ring/rte_ring_core.h
> > +++ b/lib/ring/rte_ring_core.h
> > @@ -118,12 +118,7 @@ struct rte_ring_hts_headtail {
> > * a problem.
> > */
> > struct rte_ring {
> > - /*
> > - * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
> > - * compatibility requirements, it could be changed to
> > RTE_RING_NAMESIZE
> > - * next time the ABI changes
> > - */
> > - char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned;
> > + char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
> > /**< Name of the ring. */
> > int flags; /**< Flags supplied at creation. */
> > const struct rte_memzone *memzone;
> > --
> > 2.25.1
parent reply other threads:[~2021-10-19 7:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <DBAPR08MB5814D46BE1E11C10ACE9644598BC9@DBAPR08MB5814.eurprd08.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273dc081fab040e3969541a234f9ad44@intel.com \
--to=lijuan.tu@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=ci@dpdk.org \
--cc=dev@dpdk.org \
--cc=dpdklab@iol.unh.edu \
--cc=konstantin.ananyev@intel.com \
--cc=lylavoie@iol.unh.edu \
--cc=nd@arm.com \
--cc=zoltan.kiss@schaman.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).