DPDK CI discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Lincoln Lavoie <lylavoie@iol.unh.edu>
Cc: Aaron Conole <aconole@redhat.com>, dev <dev@dpdk.org>,
	ci@dpdk.org, Michael Santana <msantana@redhat.com>,
	dpdklab <dpdklab@iol.unh.edu>
Subject: Re: [dpdklab] Re: [dpdk-ci] [RFC] Proposal for allowing rerun of tests
Date: Tue, 25 Jan 2022 13:05:22 +0000	[thread overview]
Message-ID: <5d231097-cc57-a794-f57d-67c6c138e15c@redhat.com> (raw)
In-Reply-To: <CAOE1vsPkKurhTYTNh2HGA4mKcG4=zCp-nfLr8qmpri6mML9z_g@mail.gmail.com>

On 21/01/2022 17:57, Lincoln Lavoie wrote:
> Hi Kevin,
> 

Hi Lincoln,

> I'll add some notes around this to the 2022 planning doc.  The retests
> requests for the periodic tests are tricky from the discussed patchworks /
> mailing list approach, because there isn't an associated patch or patch
> ID.  So, we just need to document or agree on how to "flag" what the
> request is, so the system could uniquely ID what branch / test to rerun.
> 
> I'll also add this to the list for the dashboard technical debt as well, as
> there may be a graphical interface stuff (i.e. a button) we could add to
> the UNH-IOL hosted testing.
> 

 From my point of view, I don't really mind how a re-test is triggered. 
I was just suggesting a "button" as a way of saying that we mightn't 
need the complexity of parsing emails etc. as there would be just a few 
  branch maintainers and a few requests. But if it's more complex 
updating the dashboard, then that might not be best solution.

As always, please consider this just one request. If others don't see 
relative value in it, then makes sense to drop it or select something 
more important ahead of it.

thanks,
Kevin.

> Cheers,
> Lincoln
> 
> On Fri, Jan 21, 2022 at 9:00 AM Kevin Traynor <ktraynor@redhat.com> wrote:
> 
>> On 13/04/2021 14:50, Aaron Conole wrote:
>>> Greetings,
>>>
>>> During the various CI pipelines, sometimes a test setup or lab will
>>> have an internal failure unrelated to the specific patch.  Perhaps
>>> 'master' branch (or the associated -next branch) is broken and we cannot
>>> get a successful run anyway.  Perhaps a network outage occurs during
>>> infrastructure setup.  Perhaps some other transient error clobbers the
>>> setup.  In all of these cases the report to the mailing flags the patch
>>> as 'FAIL'.
>>>
>>> It would be very helpful if maintainers had the ability to tell various
>>> CI infrastructures to restart / rerun patch tests.  For now, this has to
>>> be done by the individual managers of those labs.  Some labs, it isn't
>>> possible.  Others, it's possible but is a very time-consuming process to
>>> restart a test case.  In all cases, a maintainer needs to spend time
>>> communicating with a lab manager.  This could be made a bit nicer.
>>>
>>
>> Just to tie two relevant threads together. I made a request in
>> http://mails.dpdk.org/archives/ci/2022-January/001593.html for a
>> "retest" button (or really any manual but self-sufficient way) to
>> kick-off immediately what is run in periodic branch testing. Something
>> might be there already, that i'm just not aware of.
>>
>> This could be used by LTS maintainers, and possibly main, *-next branch
>> maintainers coming up to releases.
>>
>> thanks,
>> Kevin.
>>
>>> One proposal we (Michael and I) have toyed with for our lab is having
>>> the infrastructure monitor patchwork comments for a restart flag, and
>>> kick off based on that information.  Patchwork tracks all of the
>>> comments for each patch / series so we could look at the series that
>>> are still in a state for 'merging' (new, assigned, etc) and check the
>>> patch .comments API for new comments.  Getting the data from PW should
>>> be pretty simple - but I think that knowing whether to kick off the
>>> test might be more difficult.  We have concerns about which messages we
>>> should accept (for example, can anyone ask for a series to be rerun, and
>>> we'll need to track which rerun messages we've accepted).  The
>>> convention needs to be something we all can work with (ie: /Re-check:
>>> [checkname] or something as a single line in the email).
>>>
>>> This is just a start to identify and explain the concern.  Maybe there
>>> are other issues we've not considered, or maybe folks think this is a
>>> terrible idea not worth spending any time developing.  I think there's
>>> enough use for it that I am raising it here, and we can discuss it.
>>>
>>> Thanks,
>>> -Aaron
>>>
>>
>>
> 


      reply	other threads:[~2022-01-25 13:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 13:50 Aaron Conole
2021-04-13 14:47 ` Thomas Monjalon
2021-04-13 14:59   ` David Marchand
2021-04-13 15:04     ` [dpdk-ci] [dpdk-dev] " Bruce Richardson
2021-04-13 15:17       ` Thomas Monjalon
2021-04-21 15:02         ` Aaron Conole
2021-04-27  8:56           ` David Marchand
2022-01-21 14:00 ` [dpdk-ci] " Kevin Traynor
2022-01-21 17:57   ` [dpdklab] " Lincoln Lavoie
2022-01-25 13:05     ` Kevin Traynor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d231097-cc57-a794-f57d-67c6c138e15c@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=aconole@redhat.com \
    --cc=ci@dpdk.org \
    --cc=dev@dpdk.org \
    --cc=dpdklab@iol.unh.edu \
    --cc=lylavoie@iol.unh.edu \
    --cc=msantana@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).