DPDK CI discussions
 help / color / mirror / Atom feed
* [dpdk-ci] Please install libatomic on your systems
@ 2021-07-02 13:34 David Marchand
  2021-07-02 16:31 ` Lincoln Lavoie
  0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2021-07-02 13:34 UTC (permalink / raw)
  To: ci, dpdklab
  Cc: Aaron Conole, Lincoln Lavoie, Thomas Monjalon, Andrew Rybchenko

Hello all,

This is a call for action for CI(s).

Summary:
It is not mandatory to install libatomic on *all* systems, but still
recommended to avoid losing coverage on net/sfc.
But it is *mandatory* if the ABI check is ran on this system.


Details:
The net/sfc driver will now depend on the libatomic package.
This driver was always selected and built so far.
But now, if libatomic is not installed, this driver won't be compiled anymore.

Absence of this driver binary will be flagged as a failure by the ABI
check: the check interprets a hw support removal as a ABI breakage.

Example of output:
...
[2727/2727] Linking target drivers/librte_event_octeontx2.so.21.3
Error: cannot find librte_net_sfc.dump in
/home/dmarchan/builds/build-gcc-shared/install


-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Please install libatomic on your systems
  2021-07-02 13:34 [dpdk-ci] Please install libatomic on your systems David Marchand
@ 2021-07-02 16:31 ` Lincoln Lavoie
  2021-07-07 11:18   ` David Marchand
  0 siblings, 1 reply; 8+ messages in thread
From: Lincoln Lavoie @ 2021-07-02 16:31 UTC (permalink / raw)
  To: David Marchand
  Cc: ci, dpdklab, Aaron Conole, Thomas Monjalon, Andrew Rybchenko

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

Thanks David,

I've created an issue in our Jira to track this and we'll confirm when this
has been installed on all the systems in the UNH-IOL Community Lab.

Cheers,
Lincoln



On Fri, Jul 2, 2021 at 9:34 AM David Marchand <david.marchand@redhat.com>
wrote:

> Hello all,
>
> This is a call for action for CI(s).
>
> Summary:
> It is not mandatory to install libatomic on *all* systems, but still
> recommended to avoid losing coverage on net/sfc.
> But it is *mandatory* if the ABI check is ran on this system.
>
>
> Details:
> The net/sfc driver will now depend on the libatomic package.
> This driver was always selected and built so far.
> But now, if libatomic is not installed, this driver won't be compiled
> anymore.
>
> Absence of this driver binary will be flagged as a failure by the ABI
> check: the check interprets a hw support removal as a ABI breakage.
>
> Example of output:
> ...
> [2727/2727] Linking target drivers/librte_event_octeontx2.so.21.3
> Error: cannot find librte_net_sfc.dump in
> /home/dmarchan/builds/build-gcc-shared/install
>
>
> --
> David Marchand
>
>

-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 2647 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] Please install libatomic on your systems
  2021-07-02 16:31 ` Lincoln Lavoie
@ 2021-07-07 11:18   ` David Marchand
  2021-07-07 12:27     ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
  0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2021-07-07 11:18 UTC (permalink / raw)
  To: Lincoln Lavoie
  Cc: ci, dpdklab, Aaron Conole, Thomas Monjalon, Andrew Rybchenko

Hello Lincoln,

On Fri, Jul 2, 2021 at 6:32 PM Lincoln Lavoie <lylavoie@iol.unh.edu> wrote:
>
> Thanks David,
>
> I've created an issue in our Jira to track this and we'll confirm when this has been installed on all the systems in the UNH-IOL Community Lab.
>

Thanks, do you have a ETA?


-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: Please install libatomic on your systems
  2021-07-07 11:18   ` David Marchand
@ 2021-07-07 12:27     ` Lincoln Lavoie
  2021-07-07 17:51       ` Brandon Lo
  0 siblings, 1 reply; 8+ messages in thread
From: Lincoln Lavoie @ 2021-07-07 12:27 UTC (permalink / raw)
  To: David Marchand
  Cc: ci, dpdklab, Aaron Conole, Thomas Monjalon, Andrew Rybchenko

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

Hi David,

I know Brandon started the work yesterday.  Note, the lab was closed July 2
through July 5, for the USA holiday. He can confirm what the ETA is on the
different parts of the lab (i.e. containers vs the bare-metal systems).

Cheers,
Lincoln

On Wed, Jul 7, 2021 at 7:18 AM David Marchand <david.marchand@redhat.com>
wrote:

> Hello Lincoln,
>
> On Fri, Jul 2, 2021 at 6:32 PM Lincoln Lavoie <lylavoie@iol.unh.edu>
> wrote:
> >
> > Thanks David,
> >
> > I've created an issue in our Jira to track this and we'll confirm when
> this has been installed on all the systems in the UNH-IOL Community Lab.
> >
>
> Thanks, do you have a ETA?
>
>
> --
> David Marchand
>
>

-- 
*Lincoln Lavoie*
Principal Engineer, Broadband Technologies
21 Madbury Rd., Ste. 100, Durham, NH 03824
lylavoie@iol.unh.edu
https://www.iol.unh.edu
+1-603-674-2755 (m)
<https://www.iol.unh.edu>

[-- Attachment #2: Type: text/html, Size: 2255 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: Please install libatomic on your systems
  2021-07-07 12:27     ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
@ 2021-07-07 17:51       ` Brandon Lo
  2021-07-07 18:36         ` David Marchand
  0 siblings, 1 reply; 8+ messages in thread
From: Brandon Lo @ 2021-07-07 17:51 UTC (permalink / raw)
  To: Lincoln Lavoie
  Cc: David Marchand, ci, dpdklab, Aaron Conole, Thomas Monjalon,
	Andrew Rybchenko

Hi David,

I have added the dependency to all containers / virtual machines that
run the ABI check test.
Could you also point me to the correct branch to compile with this new
dependency installed?
It would help me double check to ensure that I did not miss anything
and the ABI test results will remain stable on the dashboard.

Thanks,
Brandon

On Wed, Jul 7, 2021 at 8:27 AM Lincoln Lavoie <lylavoie@iol.unh.edu> wrote:
>
> Hi David,
>
> I know Brandon started the work yesterday.  Note, the lab was closed July 2 through July 5, for the USA holiday. He can confirm what the ETA is on the different parts of the lab (i.e. containers vs the bare-metal systems).
>
> Cheers,
> Lincoln
>
> On Wed, Jul 7, 2021 at 7:18 AM David Marchand <david.marchand@redhat.com> wrote:
>>
>> Hello Lincoln,
>>
>> On Fri, Jul 2, 2021 at 6:32 PM Lincoln Lavoie <lylavoie@iol.unh.edu> wrote:
>> >
>> > Thanks David,
>> >
>> > I've created an issue in our Jira to track this and we'll confirm when this has been installed on all the systems in the UNH-IOL Community Lab.
>> >
>>
>> Thanks, do you have a ETA?
>>
>>
>> --
>> David Marchand
>>
>
>
> --
> Lincoln Lavoie
> Principal Engineer, Broadband Technologies
> 21 Madbury Rd., Ste. 100, Durham, NH 03824
> lylavoie@iol.unh.edu
> https://www.iol.unh.edu
> +1-603-674-2755 (m)
>


-- 

Brandon Lo

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

blo@iol.unh.edu

www.iol.unh.edu

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: Please install libatomic on your systems
  2021-07-07 17:51       ` Brandon Lo
@ 2021-07-07 18:36         ` David Marchand
  2021-07-15  8:00           ` David Marchand
  0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2021-07-07 18:36 UTC (permalink / raw)
  To: Brandon Lo
  Cc: Lincoln Lavoie, ci, dpdklab, Aaron Conole, Thomas Monjalon,
	Andrew Rybchenko

On Wed, Jul 7, 2021 at 7:52 PM Brandon Lo <blo@iol.unh.edu> wrote:
>
> Hi David,
>
> I have added the dependency to all containers / virtual machines that
> run the ABI check test.
> Could you also point me to the correct branch to compile with this new
> dependency installed?

The main branch should pass the usual tests, compile, ut, abi.
Adding this dependency won't change anything for current main.

As for the patches requiring this update, they are from this patchset:
http://patchwork.dpdk.org/project/dpdk/list/?series=17590
Re-running the checks on this series should give all green flags.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: Please install libatomic on your systems
  2021-07-07 18:36         ` David Marchand
@ 2021-07-15  8:00           ` David Marchand
  2021-07-15 16:56             ` Brandon Lo
  0 siblings, 1 reply; 8+ messages in thread
From: David Marchand @ 2021-07-15  8:00 UTC (permalink / raw)
  To: Brandon Lo, Lincoln Lavoie
  Cc: ci, dpdklab, Aaron Conole, Thomas Monjalon, Andrew Rybchenko

On Wed, Jul 7, 2021 at 8:36 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Wed, Jul 7, 2021 at 7:52 PM Brandon Lo <blo@iol.unh.edu> wrote:
> >
> > Hi David,
> >
> > I have added the dependency to all containers / virtual machines that
> > run the ABI check test.
> > Could you also point me to the correct branch to compile with this new
> > dependency installed?
>
> The main branch should pass the usual tests, compile, ut, abi.
> Adding this dependency won't change anything for current main.
>
> As for the patches requiring this update, they are from this patchset:
> http://patchwork.dpdk.org/project/dpdk/list/?series=17590
> Re-running the checks on this series should give all green flags.
>

Any update?
sfc series are blocked because of this.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-ci] [dpdklab] Re: Please install libatomic on your systems
  2021-07-15  8:00           ` David Marchand
@ 2021-07-15 16:56             ` Brandon Lo
  0 siblings, 0 replies; 8+ messages in thread
From: Brandon Lo @ 2021-07-15 16:56 UTC (permalink / raw)
  To: David Marchand
  Cc: Lincoln Lavoie, ci, dpdklab, Aaron Conole, Thomas Monjalon,
	Andrew Rybchenko

On Thu, Jul 15, 2021 at 4:01 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Jul 7, 2021 at 8:36 PM David Marchand <david.marchand@redhat.com> wrote:
> >
> > On Wed, Jul 7, 2021 at 7:52 PM Brandon Lo <blo@iol.unh.edu> wrote:
> > >
> > > Hi David,
> > >
> > > I have added the dependency to all containers / virtual machines that
> > > run the ABI check test.
> > > Could you also point me to the correct branch to compile with this new
> > > dependency installed?
> >
> > The main branch should pass the usual tests, compile, ut, abi.
> > Adding this dependency won't change anything for current main.
> >
> > As for the patches requiring this update, they are from this patchset:
> > http://patchwork.dpdk.org/project/dpdk/list/?series=17590
> > Re-running the checks on this series should give all green flags.
> >
>
> Any update?
> sfc series are blocked because of this.
>
>
> --
> David Marchand
>

Just confirming, we talked briefly about this during the community meeting.
This patchset should be fine now.
I will see if rerunning the unit test on the ARM machine will yield a
better result.

Thanks,
Brandon

--

Brandon Lo

UNH InterOperability Laboratory

21 Madbury Rd, Suite 100, Durham, NH 03824

blo@iol.unh.edu

www.iol.unh.edu

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-15 16:57 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 13:34 [dpdk-ci] Please install libatomic on your systems David Marchand
2021-07-02 16:31 ` Lincoln Lavoie
2021-07-07 11:18   ` David Marchand
2021-07-07 12:27     ` [dpdk-ci] [dpdklab] " Lincoln Lavoie
2021-07-07 17:51       ` Brandon Lo
2021-07-07 18:36         ` David Marchand
2021-07-15  8:00           ` David Marchand
2021-07-15 16:56             ` Brandon Lo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).