* Re: abidiff assert
[not found] ` <8734rtwqfw.fsf@redhat.com>
@ 2024-04-10 16:24 ` Patrick Robb
0 siblings, 0 replies; only message in thread
From: Patrick Robb @ 2024-04-10 16:24 UTC (permalink / raw)
To: Dodji Seketeli; +Cc: David Marchand, Tyler Retzlaff, dpdklab, ci
Hi Dodji,
Thank you for sussing out the issue. We will have to upgrade from
libabigail 2.2 to latest.
I would normally take you up on the offer to help, but in this case,
one of the Community Lab members (Cody Cheng) is already performing
some dependency updates for the CI Containers template engine, which
is the application responsible for building these dpdk CI container
images: https://git.dpdk.org/tools/dpdk-ci/tree/containers
Cody, please make updates for libabigail a part of the template engine
updates you are working on now. Thank you!
On Wed, Apr 10, 2024 at 4:51 AM Dodji Seketeli <dodji@redhat.com> wrote:
>
> Hello all,
>
> Patrick Robb <probb@iol.unh.edu> writes:
>
> [...]
>
> > Thanks for your patience, I got sidetracked with some other items.
>
> No problem.
>
> >You can download this tarball of dpdk source, the abi reference
> >directory (created off of 23.11), and dpdk install directory (contains
> >new abi ref).
>
> [...]
>
> > download here: https://drive.google.com/file/d/1Hkt9QmwSPFUmZln3XoN_pup1UNc0VajO/view?usp=sharing
>
> Thank you very much, I have been able to download it just fine.
>
> [...]
>
> > Then you can run the abi check like:
> >
> > dpdk/devtools/check-abi.sh reference build_install
>
> I could run it just fine, thanks.
>
> [...]
>
> So, from what I can see, the problem seems to have been fixed in
> libabigail 2.3 and is subsequently still fixed in current development
> version from libabigail's Git repository (from the master branch).
>
> Here is what I am seeing:
>
> --------------------------------------->8<--------------------------------------------
> $ which abidiff
> /usr/bin/abidiff
> $ abidiff --version
> abidiff: 2.3.0
> $ ./dpdk/devtools/check-abi.sh reference build_install
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (4 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added (2 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (28 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (29 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added variables
>
> Functions changes summary: 0 Removed, 0 Changed (12 filtered out), 0 Added (1 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed (5 filtered out), 0 Changed (290 filtered out), 0 Added (25 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (2 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (8 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (6 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added (1 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added (7 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed (13 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (11 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (3 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) variable
>
> Functions changes summary: 0 Removed, 0 Changed (15 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added (1 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) variable
>
> Functions changes summary: 0 Removed, 0 Changed (10 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added (1 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added (8 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (5 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed (26 filtered out), 0 Added variables
>
> Functions changes summary: 0 Removed, 0 Changed (14 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed (14 filtered out), 0 Added variables
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (24 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added (1 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (2 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (121 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (52 filtered out), 0 Added (9 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added (2 filtered out) variables
> --------------------------------------->8<--------------------------------------------
>
> Then, I did a little local change to check-abi.sh to allow me to point
> to a version of "abidiff" of my choice:
>
> ---------------------------------->8<-----------------------------------------
> $ diff -u dpdk/devtools/check-abi.sh.orig dpdk/devtools/check-abi.sh
> --- dpdk/devtools/check-abi.sh.orig 2024-04-06 07:07:47.961207167 +0200
> +++ dpdk/devtools/check-abi.sh 2024-04-10 10:18:41.530061541 +0200
> @@ -13,6 +13,17 @@
> ABIDIFF_SUPPRESSIONS=$(dirname $(readlink -f $0))/libabigail.abignore
> ABIDIFF_OPTIONS="--suppr $ABIDIFF_SUPPRESSIONS --no-added-syms"
>
> +if test x$ABIDIFF = x ; then
> + ABIDIFF=`which abidiff`
> +fi
> +
> +if test x$ABIDIFF = x ; then
> + echo "Could not find abidiff"
> + exit 1
> +fi
> +
> +export ABIDIFF
> +
> if [ ! -d $refdir ]; then
> echo "Error: reference directory '$refdir' does not exist." >&2
> exit 1
> @@ -49,7 +60,7 @@
> echo "Error: cannot find $name in $newdir" >&2
> return 1
> fi
> - abidiff $ABIDIFF_OPTIONS $lib $lib2 || {
> + $ABIDIFF $ABIDIFF_OPTIONS $lib $lib2 || {
> abiret=$?
> echo "Error: ABI issue reported for abidiff $ABIDIFF_OPTIONS $lib $lib2" >&2
> if [ $(($abiret & 3)) -ne 0 ]; then
>
> ---------------------------------->8<-----------------------------------------
>
> With that patched check-abi.sh, I could test the current development
> version of libabigail and here is what I am getting:
>
> ---------------------------------->8<-----------------------------------------
> $ ABIDIFF=/home/dodji/git/libabigail/fixes/build/tools/abidiff ./dpdk/devtools/check-abi.sh reference build_install
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (4 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (28 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added (2 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (8 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (6 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added (1 filtered out) functions
> Functions changes summary: 0 Removed, 0 Changed (10 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Variables changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added (7 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (3 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) variable
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added variables
>
> Functions changes summary: 0 Removed, 0 Changed (11 filtered out), 0 Added functions
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added variable
>
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (13 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (12 filtered out), 0 Added (1 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added (1 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed (26 filtered out), 0 Added variables
>
> Functions changes summary: 0 Removed, 0 Changed (3 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (29 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (5 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added (8 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (14 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added function
> Variables changes summary: 0 Removed, 0 Changed (14 filtered out), 0 Added variables
>
> Functions changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (15 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added (1 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (1 filtered out), 0 Added function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (9 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (24 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added (1 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (4 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed (121 filtered out), 0 Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (1 filtered out) function
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> Functions changes summary: 0 Removed (5 filtered out), 0 Changed (290 filtered out), 0 Added (25 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added (2 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed (52 filtered out), 0 Added (9 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed (2 filtered out), 0 Added (2 filtered out) variables
>
> Functions changes summary: 0 Removed, 0 Changed, 0 Added (2 filtered out) functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> $
>
> ---------------------------------->8<-----------------------------------------
>
>
> Patrick Robb <probb@iol.unh.edu> writes:
>
> >> > Libabigail version in use is 2.2.0.
>
> I would propose that you move to the current libabigail 2.4 that was
> released a while ago, if possible. Is there something I could do to
> help with that?
>
> In any case, many thanks for providing me with this environment. It was
> extremely helpful in understanding what is going on.
>
> Cheers,
>
> --
> Dodji
>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-10 16:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1712088530-24948-5-git-send-email-roretzla@linux.microsoft.com>
[not found] ` <660c7eb6.050a0220.32712.3cf2SMTPIN_ADDED_MISSING@mx.google.com>
[not found] ` <20240402225856.GA24633@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
[not found] ` <87y19uluxx.fsf@redhat.com>
[not found] ` <CAJFAV8wDWAcnwvbdjTSGgw1WuBZWBR5SCqx1uuv8b=QmwLh4Gg@mail.gmail.com>
[not found] ` <CAJvnSUAjkDv4ikD1zGM5YDJsjjGTkd4J5Oj4z=qM5twTdPqQkA@mail.gmail.com>
[not found] ` <87plv5laby.fsf@redhat.com>
[not found] ` <CAJvnSUAAdKxBw6mx3i+U_mEmbXuA5LwfgVcPK2d3g9D7bRyFyQ@mail.gmail.com>
[not found] ` <8734rtwqfw.fsf@redhat.com>
2024-04-10 16:24 ` abidiff assert Patrick Robb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).