Re: [PATCH] net/hns3: support new device

[Jie Hai <haijie1@huawei.com>]

On 2024/3/6 18:00, Ferruh Yigit wrote:
> On 3/6/2024 9:21 AM, Jie Hai wrote:
>> This patch adds new device to the driver.
>>
Hi, Ferruh,
Thanks for your reivew.
> 
> Just checking if a documentation update is rquired,hns3.rst has
> following description, "network engine found in the HiSilicon Kunpeng
> 920 SoC and Kunpeng 930 SoC", is this still holds with new device support?
> 
The new device can be found on the latter SoC, which is HIP09 and HIP10.

> Also you may want to update release notes to announce the new device
> support.
Yes, It will be updateed.
> 
> Can you please give some more details in the commit log about the new
> supported device, and if possible provide product links etc..
> 
OK.
> 
> You may also request to backport this change to LTS (by adding stable
> tag), assuming LTS code already supports these new devices. LTS
> maintainers can decide to pick or not pick the patch to LTS release.
> 
OK.
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>> ---
>>   drivers/net/hns3/hns3_cmd.c    | 4 +++-
>>   drivers/net/hns3/hns3_ethdev.c | 2 ++
>>   drivers/net/hns3/hns3_ethdev.h | 2 ++
>>   3 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c
>> index 2c1664485bef..001ff49b368b 100644
>> --- a/drivers/net/hns3/hns3_cmd.c
>> +++ b/drivers/net/hns3/hns3_cmd.c
>> @@ -545,7 +545,9 @@ hns3_set_dcb_capability(struct hns3_hw *hw)
>>   	if (device_id == HNS3_DEV_ID_25GE_RDMA ||
>>   	    device_id == HNS3_DEV_ID_50GE_RDMA ||
>>   	    device_id == HNS3_DEV_ID_100G_RDMA_MACSEC ||
>> -	    device_id == HNS3_DEV_ID_200G_RDMA)
>> +	    device_id == HNS3_DEV_ID_200G_RDMA ||
>> +	    device_id == HNS3_DEV_ID_100G_ROH ||
>> +	    device_id == HNS3_DEV_ID_200G_ROH)
>>   		hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_DCB_B, 1);
>>   }
>>   
>> diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
>> index b10d1216d2d1..9730b9a7e9f6 100644
>> --- a/drivers/net/hns3/hns3_ethdev.c
>> +++ b/drivers/net/hns3/hns3_ethdev.c
>> @@ -6649,6 +6649,8 @@ static const struct rte_pci_id pci_id_hns3_map[] = {
>>   	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_50GE_RDMA) },
>>   	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_RDMA_MACSEC) },
>>   	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_RDMA) },
>> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_ROH) },
>> +	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_ROH) },
>>   	{ .vendor_id = 0, }, /* sentinel */
>>   };
>>   
>> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
>> index 12d8299def39..e70c5fff2a45 100644
>> --- a/drivers/net/hns3/hns3_ethdev.h
>> +++ b/drivers/net/hns3/hns3_ethdev.h
>> @@ -28,7 +28,9 @@
>>   #define HNS3_DEV_ID_25GE_RDMA			0xA222
>>   #define HNS3_DEV_ID_50GE_RDMA			0xA224
>>   #define HNS3_DEV_ID_100G_RDMA_MACSEC		0xA226
>> +#define HNS3_DEV_ID_100G_ROH	                0xA227
>>   #define HNS3_DEV_ID_200G_RDMA			0xA228
>> +#define HNS3_DEV_ID_200G_ROH	                0xA22C
>>   #define HNS3_DEV_ID_100G_VF			0xA22E
>>   #define HNS3_DEV_ID_100G_RDMA_PFC_VF		0xA22F
>>   
> 
> .