From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix offloads for the newly attached port
Date: Thu, 1 Jul 2021 17:01:34 +0300 [thread overview]
Message-ID: <04b70a3a-6d79-6e25-27ee-a07cf4931ea1@oktetlabs.ru> (raw)
In-Reply-To: <20210619154012.27295-1-viacheslavo@nvidia.com>
On 6/19/21 6:40 PM, Viacheslav Ovsiienko wrote:
> For the newly attached ports (with "port attach" command) the
> default offloads settings, configured from application command
> line, were not applied, causing port start failure following
> the attach. For example, if scattering offload was configured
> in command line and rxpkts was configured for multiple segments,
> the newly attached port start was failed due to missing scattering
> offload enable in the new port settings. The missing code to apply
> the offloads to the new device and its queues is added.
>
> Cc: stable@dpdk.org
> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
Two above lines should be swapped.
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
The patch duplicates too much from init_config() function.
Please, factor out a helper function to do the job and
use it in init_config() and reconfig().
next prev parent reply other threads:[~2021-07-01 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 15:40 Viacheslav Ovsiienko
2021-06-23 9:09 ` Singh, Aman Deep
2021-07-01 14:01 ` Andrew Rybchenko [this message]
2021-07-12 10:24 ` [dpdk-dev] [PATCH v2] " Viacheslav Ovsiienko
2021-07-12 12:40 ` [dpdk-dev] [PATCH v3] " Viacheslav Ovsiienko
2021-07-13 5:37 ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2021-07-13 9:50 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b70a3a-6d79-6e25-27ee-a07cf4931ea1@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).