DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>, dev@dpdk.org
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH 06/17] net/bnxt: update HWRM API to version 1.10.1.6
Date: Fri, 25 Oct 2019 14:22:58 +0100	[thread overview]
Message-ID: <08d46129-1681-69ef-ee15-129696d07c6c@intel.com> (raw)
In-Reply-To: <20191024074432.30705-7-somnath.kotur@broadcom.com>

On 10/24/2019 8:44 AM, Somnath Kotur wrote:
> @@ -32523,7 +33886,7 @@
> 
>  struct hwrm_nvm_write_input {
> 
> * The requested length of the allocated NVM for the item, in bytes. This value may be greater than or equal to the specified data length (dir_data_length).
> * If this value is less than the specified data length, it will be ignored.
> * The response will contain the actual allocated item length, which may be greater than the requested item length.
> - * The purpose for allocating more than the required number of bytes for an item's data is to pre-allocate extra storage (padding) to accomodate
> + * The purpose for allocating more than the required number of bytes for an item's data is to pre-allocate extra storage (padding) to accommodate
> * the potential future growth of an item (e.g. upgraded firmware with a size increase, log growth, expanded configuration data).
> */
> uint32_t dir_item_length;

We are more flexible on the base files and their compatibility to
our coding convention, but for later can it be possible to take the
line length under more control.

> 
> @@ -33105,7 +34468,7 @@
> 
>  struct hwrm_nvm_install_update_input {
> 
> #define HWRM_NVM_INSTALL_UPDATE_INPUT_FLAGS_ERASE_UNUSED_SPACE \
> UINT32_C(0x1)
> /*
> - * If set to 1, then unspecifed images, images not in the package file, will be safely deleted.
> + * If set to 1, then unspecified images, images not in the package file, will be safely deleted.
> * When combined with erase_unused_space then unspecified images will be securely erased.
> */
> #define HWRM_NVM_INSTALL_UPDATE_INPUT_FLAGS_REMOVE_UNUSED_PKG \
> 
> -- 
> 2.10.1.613.g2cc2e70
> 
> 
> 
> 
> 


  reply	other threads:[~2019-10-25 13:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  7:44 [dpdk-dev] [PATCH v2 00/17] bnxt patchset with bug fixes Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 01/17] net/bnxt: fix unused value in free filter mem Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 02/17] net/bnxt: fix ping failure with MTU change Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH v2 03/17] net/bnxt: fix to set MAX RSS contexts for maximal reservation Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 04/17] net/bnxt: fix to write the correct MTU to FW Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 05/17] net/bnxt: fix RSS configuration failure for thor-based controllers Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 06/17] net/bnxt: update HWRM API to version 1.10.1.6 Somnath Kotur
2019-10-25 13:22   ` Ferruh Yigit [this message]
2019-10-24  7:44 ` [dpdk-dev] [PATCH 07/17] net/bnxt: use mac index, while checking for default mac Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 08/17] net/bnxt: fix a possible race between start and interrupt handler Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 09/17] net/bnxt: fix to use HWRM_CFA_L2_FILTER as the filter_type for non-ntuple flows Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 10/17] net/bnxt: expose some missing counters in port statistics Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 11/17] net/bnxt: fix to check for zero mac address while parsing flow arguments Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 12/17] net/bnxt: fix segfault after removing and adding the slaves Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 13/17] net/bnxt: add more checks for fw reset Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 14/17] net/bnxt: add PCI IDs for 57500 series NPAR devices Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 15/17] net/bnxt: add a wrapper function for thor device check Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 16/17] net/bnxt: fix a possible memory leak Somnath Kotur
2019-10-24  7:44 ` [dpdk-dev] [PATCH 17/17] net/bnxt: call bnxt_uninit_locks from bnxt_uninit_resources Somnath Kotur
2019-10-24 18:40 ` [dpdk-dev] [PATCH v2 00/17] bnxt patchset with bug fixes Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08d46129-1681-69ef-ee15-129696d07c6c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=somnath.kotur@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).