From: Somnath Kotur <somnath.kotur@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: [dpdk-dev] [PATCH 13/17] net/bnxt: add more checks for fw reset
Date: Thu, 24 Oct 2019 13:14:28 +0530 [thread overview]
Message-ID: <20191024074432.30705-14-somnath.kotur@broadcom.com> (raw)
In-Reply-To: <20191024074432.30705-1-somnath.kotur@broadcom.com>
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Added check for fw reset or fw errors in few more routines.
While processing the events, if it is fw fatal or non-fatal
event, there is no need to process the remaining events as
driver triggers recovery mechanism.
Also added a check for fw reset or fatal error in bnxt_disable_int()
to avoid bar access in case of fatal error.
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Rahul Gupta <rahul.gupta@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_irq.c | 8 ++++++++
drivers/net/bnxt/bnxt_rxr.c | 3 +++
2 files changed, 11 insertions(+)
diff --git a/drivers/net/bnxt/bnxt_irq.c b/drivers/net/bnxt/bnxt_irq.c
index 4feb637..846325e 100644
--- a/drivers/net/bnxt/bnxt_irq.c
+++ b/drivers/net/bnxt/bnxt_irq.c
@@ -37,6 +37,11 @@ void bnxt_int_handler(void *param)
return;
}
+ if (is_bnxt_in_error(bp)) {
+ pthread_mutex_unlock(&bp->def_cp_lock);
+ return;
+ }
+
cons = RING_CMP(cpr->cp_ring_struct, raw_cons);
cmp = &cpr->cp_desc_ring[cons];
@@ -104,6 +109,9 @@ void bnxt_disable_int(struct bnxt *bp)
if (BNXT_NUM_ASYNC_CPR(bp) == 0)
return;
+ if (is_bnxt_in_error(bp))
+ return;
+
if (!cpr || !cpr->cp_db.doorbell)
return;
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index 03dae57..ee1444c 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -639,6 +639,9 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
evt =
bnxt_event_hwrm_resp_handler(rxq->bp,
(struct cmpl_base *)rxcmp);
+ /* If the async event is Fatal error, return */
+ if (unlikely(is_bnxt_in_error(rxq->bp)))
+ goto done;
}
raw_cons = NEXT_RAW_CMP(raw_cons);
--
2.10.1.613.g2cc2e70
next prev parent reply other threads:[~2019-10-24 7:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 7:44 [dpdk-dev] [PATCH v2 00/17] bnxt patchset with bug fixes Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 01/17] net/bnxt: fix unused value in free filter mem Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 02/17] net/bnxt: fix ping failure with MTU change Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH v2 03/17] net/bnxt: fix to set MAX RSS contexts for maximal reservation Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 04/17] net/bnxt: fix to write the correct MTU to FW Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 05/17] net/bnxt: fix RSS configuration failure for thor-based controllers Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 06/17] net/bnxt: update HWRM API to version 1.10.1.6 Somnath Kotur
2019-10-25 13:22 ` Ferruh Yigit
2019-10-24 7:44 ` [dpdk-dev] [PATCH 07/17] net/bnxt: use mac index, while checking for default mac Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 08/17] net/bnxt: fix a possible race between start and interrupt handler Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 09/17] net/bnxt: fix to use HWRM_CFA_L2_FILTER as the filter_type for non-ntuple flows Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 10/17] net/bnxt: expose some missing counters in port statistics Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 11/17] net/bnxt: fix to check for zero mac address while parsing flow arguments Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 12/17] net/bnxt: fix segfault after removing and adding the slaves Somnath Kotur
2019-10-24 7:44 ` Somnath Kotur [this message]
2019-10-24 7:44 ` [dpdk-dev] [PATCH 14/17] net/bnxt: add PCI IDs for 57500 series NPAR devices Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 15/17] net/bnxt: add a wrapper function for thor device check Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 16/17] net/bnxt: fix a possible memory leak Somnath Kotur
2019-10-24 7:44 ` [dpdk-dev] [PATCH 17/17] net/bnxt: call bnxt_uninit_locks from bnxt_uninit_resources Somnath Kotur
2019-10-24 18:40 ` [dpdk-dev] [PATCH v2 00/17] bnxt patchset with bug fixes Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024074432.30705-14-somnath.kotur@broadcom.com \
--to=somnath.kotur@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).