From: Thomas Monjalon <thomas@monjalon.net>
To: Ciara Power <ciara.power@intel.com>, Akhil Goyal <gakhil@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
Anoob Joseph <anoobj@marvell.com>,
"mdr@ashroe.eu" <mdr@ashroe.eu>,
Declan Doherty <declan.doherty@intel.com>
Subject: Re: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create
Date: Mon, 07 Feb 2022 14:02:03 +0100 [thread overview]
Message-ID: <11916826.O9o76ZdvQC@thomas> (raw)
In-Reply-To: <CO6PR18MB4484D0AB3663D14DF7F19A0ED82C9@CO6PR18MB4484.namprd18.prod.outlook.com>
07/02/2022 10:04, Akhil Goyal:
> > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst
> > b/doc/guides/prog_guide/cryptodev_lib.rst
> > index 62bd3577f5..8e16461dc6 100644
> > --- a/doc/guides/prog_guide/cryptodev_lib.rst
> > +++ b/doc/guides/prog_guide/cryptodev_lib.rst
> > @@ -1236,10 +1236,10 @@ crypto operations is similar except change to
> > respective op and xform setup).
> > * Create asym crypto session and initialize it for the crypto device.
> > * The session structure is hidden from the app, so void * is used.
> > */
> > - void *asym_session;
> > - asym_session =
> > rte_cryptodev_asym_session_create(asym_session_pool,
> > + void *asym_session = NULL;
> > + ret = rte_cryptodev_asym_session_create(&asym_session,
> > asym_session_pool,
> > cdev_id, &modex_xform);
> > - if (asym_session == NULL)
> > + if (ret < 0)
> > rte_exit(EXIT_FAILURE, "Session could not be created\n");
>
> Sample Code in the rst files is no more added. @Thomas: Could you please confirm?
> Probably a separate patch is required to clean this up.
Yes the target is to remove them.
Instead we want to include parts of examples with a specific syntax.
See literalinclude here:
https://doc.dpdk.org/guides/contributing/documentation.html#code-and-literal-block-sections
next prev parent reply other threads:[~2022-02-07 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 16:04 [PATCH v3 0/4] crypto: improve asym session usage Ciara Power
2022-02-03 16:04 ` [PATCH v3 1/4] crypto: use single buffer for asymmetric session Ciara Power
2022-02-07 8:19 ` [EXT] " Akhil Goyal
2022-02-07 14:22 ` Power, Ciara
2022-02-03 16:04 ` [PATCH v3 2/4] crypto: hide asym session structure Ciara Power
2022-02-03 16:04 ` [PATCH v3 3/4] crypto: add asym session user data API Ciara Power
2022-02-07 8:41 ` [EXT] " Akhil Goyal
2022-02-03 16:04 ` [PATCH v3 4/4] crypto: modify return value for asym session create Ciara Power
2022-02-07 9:04 ` [EXT] " Akhil Goyal
2022-02-07 13:02 ` Thomas Monjalon [this message]
2022-02-07 14:50 ` Power, Ciara
2022-02-08 20:21 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11916826.O9o76ZdvQC@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=ciara.power@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=mdr@ashroe.eu \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).