From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
David Christensen <drc@linux.vnet.ibm.com>
Cc: dev@dpdk.org, Takeshi Yoshimura <tyos@jp.ibm.com>, dwilder@us.ibm.com
Subject: Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window
Date: Tue, 9 Jul 2019 11:22:46 +0100 [thread overview]
Message-ID: <11a0b685-9606-9481-9c76-80a10b76cf7b@intel.com> (raw)
In-Reply-To: <2084101.Qpx90Az0he@xps>
On 08-Jul-19 6:45 PM, Thomas Monjalon wrote:
> 08/07/2019 18:47, David Christensen:
>>> Please, any review or ack for this patch?
>>>
>>> 07/06/2019 04:28, Takeshi Yoshimura:
>>>> sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl.
>>>> However, Linux 4.17 or before returns incorrect page_shift for Power9.
>>>> I added the code for retrying creation of sPAPR DMA window.
>>>>
>>>> Signed-off-by: Takeshi Yoshimura <tyos@jp.ibm.com>
>>
>> I've shared my comments with Takeshi and I don't think the patch is
>> ready in it's current state. It appears to modify x86 functionality and
>> I'm not comfortable with signing off on that since it's in an anrea I'm
>> not familiar with.
>
> It is a function specific to sPAPR.
> So there is no risk for x86 or Arm.
> As you didn't share your comments publicly,
> this patch has been merged in 19.08-rc1.
>
I have a suspicion that David has confused this patch with another one,
which did indeed touch a lot of code (but still didn't touch x86 AFAIR).
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-07-09 10:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 2:28 Takeshi Yoshimura
2019-07-04 16:01 ` Thomas Monjalon
2019-07-08 16:47 ` David Christensen
2019-07-08 17:45 ` Thomas Monjalon
2019-07-09 10:22 ` Burakov, Anatoly [this message]
2019-07-05 8:15 ` Burakov, Anatoly
2019-07-07 21:21 ` Thomas Monjalon
2019-07-10 10:32 ` Burakov, Anatoly
2019-07-10 12:17 ` Thomas Monjalon
2019-07-10 12:35 ` Burakov, Anatoly
2019-07-10 12:39 ` Thomas Monjalon
2019-07-10 16:01 ` Burakov, Anatoly
2019-07-11 0:50 ` David Christensen
2019-07-11 2:18 ` Takeshi T Yoshimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11a0b685-9606-9481-9c76-80a10b76cf7b@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=dwilder@us.ibm.com \
--cc=thomas@monjalon.net \
--cc=tyos@jp.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).