* ixgbe link status semi-broken on FreeBSD
@ 2024-02-15 0:38 Lewis Donzis
0 siblings, 0 replies; only message in thread
From: Lewis Donzis @ 2024-02-15 0:38 UTC (permalink / raw)
To: dev
I keep meaning to mention this because we've been patching the ixgbe driver for a while...
In ixgbe_ethdev.c, function ixgbe_dev_link_update_share(), we find the following:
/* BSD has no interrupt mechanism, so force NIC status synchronization. */
#ifdef RTE_EXEC_ENV_FREEBSD
wait = 1;
#endif
Which changes the behavior of rte_eth_link_get_nowait() and causes it to wait. For a port that does not have link up, this takes approximately 12-14 seconds before it returns, which is highly undesirable.
However, after disabling this one line of code, it still appears to work properly. It returns the correct link status on ports that are up or down, but does so without any delay.
So I'm wondering, is this still necessary? No doubt, FreeBSD doesn't support interrupts, but why does that require that we wait in this case? Empirically, it works much better without that line of code.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-15 0:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 0:38 ixgbe link status semi-broken on FreeBSD Lewis Donzis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).