* [dpdk-dev] [PATCH] net/mlx5: fix memory leak when parsing device params
@ 2017-01-22 8:24 Shahaf Shuler
2017-01-23 12:04 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Shahaf Shuler @ 2017-01-22 8:24 UTC (permalink / raw)
To: adrien.mazarguil; +Cc: dev, stable
in case of an error argument list is not freed.
Fixes: e72dd09b614e ("net/mlx5: add support for configuration through kvargs")
CC: stable@dpdk.org
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 8da29d2..d527e5b 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -339,8 +339,10 @@
if (rte_kvargs_count(kvlist, params[i])) {
ret = rte_kvargs_process(kvlist, params[i],
mlx5_args_check, priv);
- if (ret != 0)
+ if (ret != 0) {
+ rte_kvargs_free(kvlist);
return ret;
+ }
}
}
rte_kvargs_free(kvlist);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix memory leak when parsing device params
2017-01-22 8:24 [dpdk-dev] [PATCH] net/mlx5: fix memory leak when parsing device params Shahaf Shuler
@ 2017-01-23 12:04 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-01-23 12:04 UTC (permalink / raw)
To: Shahaf Shuler, adrien.mazarguil; +Cc: dev, stable
On 1/22/2017 8:24 AM, Shahaf Shuler wrote:
> in case of an error argument list is not freed.
>
> Fixes: e72dd09b614e ("net/mlx5: add support for configuration through kvargs")
> CC: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-23 12:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-22 8:24 [dpdk-dev] [PATCH] net/mlx5: fix memory leak when parsing device params Shahaf Shuler
2017-01-23 12:04 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).