From: Thomas Monjalon <thomas@monjalon.net>
To: Rasesh Mody <rmody@marvell.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: fix meson build failure
Date: Wed, 06 Nov 2019 12:02:43 +0100 [thread overview]
Message-ID: <1602077.SlinmuVpUp@xps> (raw)
In-Reply-To: <20191106054520.19580-1-rmody@marvell.com>
06/11/2019 06:45, Rasesh Mody:
> Use kernel headers for __le* types to avoid potential conflicts
> resulting in redefinition errors for Linux build environments.
Errors happen only with "some" Linux environments.
> Add check for FreeBSD execution environments.
>
> Without this fix, aarch64 builds can fail with error [1] below.
>
> [1]
> In file included from ../drivers/net/bnx2x/bnx2x.h:22,
> from ../drivers/net/bnx2x/bnx2x_ethdev.c:8:
> ../drivers/net/bnx2x/bnx2x_osal.h:27:17: error: conflicting types for
> ‘uint64_t’
> #define __le64 uint64_t
> ^~~~~~~~
> In file included from /usr/include/stdint.h:37,
> from
> /usr/lib/gcc/aarch64-linux-gnu/8/include/stdint.h:9,
> from
> ../lib/librte_eal/common/include/arch/arm/rte_byteorder.h:16,
> from ../drivers/net/bnx2x/bnx2x.h:17,
> from ../drivers/net/bnx2x/bnx2x_ethdev.c:8:
> /usr/include/aarch64-linux-gnu/bits/stdint-uintn.h:27:20: note: previous
> declaration of ‘uint64_t’ was here
> typedef __uint64_t uint64_t;
> ^~~~~~~~
>
> Fixes: 38dff79ba736 ("net/bnx2x: update HSI")
>
> v2:
> Use RTE_EXEC_ENV_FREEBSD in place of __FreeBSD__
It's a bit strange to change the existing __FreeBSD__ in this patch.
I'll add a note to mention this change in the commit.
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
> Tested-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Tested-by: Gavin Hu <gavin.hu@arm.com>
Applied, thanks
prev parent reply other threads:[~2019-11-06 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 6:02 [dpdk-dev] [PATCH] " Rasesh Mody
2019-11-05 18:14 ` Thomas Monjalon
2019-11-06 5:45 ` [dpdk-dev] [PATCH v2] " Rasesh Mody
2019-11-06 11:02 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602077.SlinmuVpUp@xps \
--to=thomas@monjalon.net \
--cc=GR-Everest-DPDK-Dev@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=rmody@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).