* [PATCH v1] baseband/acc100: avoid out-of-bounds access corner cases
@ 2022-02-22 23:43 Nicolas Chautru
2022-02-23 11:01 ` [EXT] " Akhil Goyal
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Chautru @ 2022-02-22 23:43 UTC (permalink / raw)
To: dev, gakhil; +Cc: john.mcnamara, sean.morrissey, trix, Nicolas Chautru
Coverity issue: 375803, 375813, 375819, 375827, 375831
The actual maximum number of gather pointers should have been limited
Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions")
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/acc100/rte_acc100_pmd.c | 3 +--
drivers/baseband/acc100/rte_acc100_pmd.h | 1 +
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c
index 1c6080f..cc69c76 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.c
+++ b/drivers/baseband/acc100/rte_acc100_pmd.c
@@ -1460,8 +1460,7 @@
next_triplet++;
while (cb_len > 0) {
- if (next_triplet < ACC100_DMA_MAX_NUM_POINTERS &&
- m->next != NULL) {
+ if (next_triplet < ACC100_DMA_MAX_NUM_POINTERS_IN && m->next != NULL) {
m = m->next;
*seg_total_left = rte_pktmbuf_data_len(m);
diff --git a/drivers/baseband/acc100/rte_acc100_pmd.h b/drivers/baseband/acc100/rte_acc100_pmd.h
index 03ed0b3..cbcece2 100644
--- a/drivers/baseband/acc100/rte_acc100_pmd.h
+++ b/drivers/baseband/acc100/rte_acc100_pmd.h
@@ -113,6 +113,7 @@
#define ACC100_SW_RING_MEM_ALLOC_ATTEMPTS 5
#define ACC100_MAX_QUEUE_DEPTH 1024
#define ACC100_DMA_MAX_NUM_POINTERS 14
+#define ACC100_DMA_MAX_NUM_POINTERS_IN 7
#define ACC100_DMA_DESC_PADDING 8
#define ACC100_FCW_PADDING 12
#define ACC100_DESC_FCW_OFFSET 192
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [EXT] [PATCH v1] baseband/acc100: avoid out-of-bounds access corner cases
2022-02-22 23:43 [PATCH v1] baseband/acc100: avoid out-of-bounds access corner cases Nicolas Chautru
@ 2022-02-23 11:01 ` Akhil Goyal
0 siblings, 0 replies; 2+ messages in thread
From: Akhil Goyal @ 2022-02-23 11:01 UTC (permalink / raw)
To: Nicolas Chautru, dev; +Cc: john.mcnamara, sean.morrissey, trix, stable
> Coverity issue: 375803, 375813, 375819, 375827, 375831
> The actual maximum number of gather pointers should have been limited
> Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions")
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
Cc: stable@dpdk.org
Applied to dpdk-next-crypto
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-23 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-22 23:43 [PATCH v1] baseband/acc100: avoid out-of-bounds access corner cases Nicolas Chautru
2022-02-23 11:01 ` [EXT] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).