* [PATCH] pipeline: fix rss configuration
@ 2023-03-02 7:08 Yogesh Jangra
2023-03-10 16:59 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Yogesh Jangra @ 2023-03-02 7:08 UTC (permalink / raw)
To: dev
Cc: cristian.dumitrescu, kamalakannan.r, harshad.suresh.narayane,
yogesh.jangra
Currently, the rss object is configured after action, which leads
to rss instruction failure, when rss instruction is called from
action block. To resolve the error, rss object is configured
before action and apply block.
Fixes: 8ba342ce6f0 (pipeline: add RSS)
Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
Signed-off-by: Kamalakannan R <kamalakannan.r@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/pipeline/rte_swx_pipeline_spec.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/lib/pipeline/rte_swx_pipeline_spec.c b/lib/pipeline/rte_swx_pipeline_spec.c
index a164275526..006b24082a 100644
--- a/lib/pipeline/rte_swx_pipeline_spec.c
+++ b/lib/pipeline/rte_swx_pipeline_spec.c
@@ -3557,6 +3557,18 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
+ /* rss. */
+ for (i = 0; i < s->n_rss; i++) {
+ struct rss_spec *rss_spec = &s->rss[i];
+
+ status = rte_swx_pipeline_rss_config(p, rss_spec->name);
+ if (status) {
+ if (err_msg)
+ *err_msg = "rss object configuration error.";
+ return status;
+ }
+ }
+
/* metarray. */
for (i = 0; i < s->n_metarrays; i++) {
struct metarray_spec *metarray_spec = &s->metarrays[i];
@@ -3678,18 +3690,6 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
- /* rss. */
- for (i = 0; i < s->n_rss; i++) {
- struct rss_spec *rss_spec = &s->rss[i];
-
- status = rte_swx_pipeline_rss_config(p, rss_spec->name);
- if (status) {
- if (err_msg)
- *err_msg = "rss object configuration error.";
- return status;
- }
- }
-
/* apply. */
for (i = 0; i < s->n_apply; i++) {
struct apply_spec *apply_spec = &s->apply[i];
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pipeline: fix rss configuration
2023-03-02 7:08 [PATCH] pipeline: fix rss configuration Yogesh Jangra
@ 2023-03-10 16:59 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2023-03-10 16:59 UTC (permalink / raw)
To: Yogesh Jangra
Cc: dev, cristian.dumitrescu, kamalakannan.r, harshad.suresh.narayane
02/03/2023 08:08, Yogesh Jangra:
> Currently, the rss object is configured after action, which leads
> to rss instruction failure, when rss instruction is called from
> action block. To resolve the error, rss object is configured
> before action and apply block.
>
> Fixes: 8ba342ce6f0 (pipeline: add RSS)
>
> Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
> Signed-off-by: Kamalakannan R <kamalakannan.r@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pipeline: fix rss configuration
@ 2023-03-02 6:30 Yogesh Jangra
0 siblings, 0 replies; 5+ messages in thread
From: Yogesh Jangra @ 2023-03-02 6:30 UTC (permalink / raw)
To: dev
Cc: cristian.dumitrescu, kamalakannan.r, harshad.suresh.narayane,
yogesh.jangra, R
Currently, the rss object is configured after action, which leads
to rss instruction failure, when rss instruction is called from
action block. To resolve the error, rss object is configured
before action and apply block.
Fixes: 8ba342ce6f0 (pipeline: add RSS)
Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
Signed-off-by: R, Kamalakannan <kamalakannan.r@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/pipeline/rte_swx_pipeline_spec.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/lib/pipeline/rte_swx_pipeline_spec.c b/lib/pipeline/rte_swx_pipeline_spec.c
index a164275526..006b24082a 100644
--- a/lib/pipeline/rte_swx_pipeline_spec.c
+++ b/lib/pipeline/rte_swx_pipeline_spec.c
@@ -3557,6 +3557,18 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
+ /* rss. */
+ for (i = 0; i < s->n_rss; i++) {
+ struct rss_spec *rss_spec = &s->rss[i];
+
+ status = rte_swx_pipeline_rss_config(p, rss_spec->name);
+ if (status) {
+ if (err_msg)
+ *err_msg = "rss object configuration error.";
+ return status;
+ }
+ }
+
/* metarray. */
for (i = 0; i < s->n_metarrays; i++) {
struct metarray_spec *metarray_spec = &s->metarrays[i];
@@ -3678,18 +3690,6 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
- /* rss. */
- for (i = 0; i < s->n_rss; i++) {
- struct rss_spec *rss_spec = &s->rss[i];
-
- status = rte_swx_pipeline_rss_config(p, rss_spec->name);
- if (status) {
- if (err_msg)
- *err_msg = "rss object configuration error.";
- return status;
- }
- }
-
/* apply. */
for (i = 0; i < s->n_apply; i++) {
struct apply_spec *apply_spec = &s->apply[i];
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pipeline: fix rss configuration
@ 2023-03-02 5:29 Yogesh Jangra
0 siblings, 0 replies; 5+ messages in thread
From: Yogesh Jangra @ 2023-03-02 5:29 UTC (permalink / raw)
To: dev
Cc: cristian.dumitrescu, kamalakannan.r, harshad.suresh.narayane,
yogesh.jangra, R
From: yjangra <yogesh.jangra@intel.com>
Currently, the rss object is configured after action, which leads
to rss instruction failure, when rss instruction is called from
action block. To resolve the error, rss object is configured
before action and apply block.
Fixes: 8ba342ce6f0 (pipeline: add RSS)
Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
Signed-off-by: R, Kamalakannan <kamalakannan.r@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/pipeline/rte_swx_pipeline_spec.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/lib/pipeline/rte_swx_pipeline_spec.c b/lib/pipeline/rte_swx_pipeline_spec.c
index a164275526..006b24082a 100644
--- a/lib/pipeline/rte_swx_pipeline_spec.c
+++ b/lib/pipeline/rte_swx_pipeline_spec.c
@@ -3557,6 +3557,18 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
+ /* rss. */
+ for (i = 0; i < s->n_rss; i++) {
+ struct rss_spec *rss_spec = &s->rss[i];
+
+ status = rte_swx_pipeline_rss_config(p, rss_spec->name);
+ if (status) {
+ if (err_msg)
+ *err_msg = "rss object configuration error.";
+ return status;
+ }
+ }
+
/* metarray. */
for (i = 0; i < s->n_metarrays; i++) {
struct metarray_spec *metarray_spec = &s->metarrays[i];
@@ -3678,18 +3690,6 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
- /* rss. */
- for (i = 0; i < s->n_rss; i++) {
- struct rss_spec *rss_spec = &s->rss[i];
-
- status = rte_swx_pipeline_rss_config(p, rss_spec->name);
- if (status) {
- if (err_msg)
- *err_msg = "rss object configuration error.";
- return status;
- }
- }
-
/* apply. */
for (i = 0; i < s->n_apply; i++) {
struct apply_spec *apply_spec = &s->apply[i];
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] pipeline: fix rss configuration
@ 2023-03-02 5:22 yjangra
0 siblings, 0 replies; 5+ messages in thread
From: yjangra @ 2023-03-02 5:22 UTC (permalink / raw)
To: dev
Cc: cristian.dumitrescu, kamalakannan.r, harshad.suresh.narayane,
yogesh.jangra, R
Currently, the rss object is configured after action, which leads
to rss instruction failure, when rss instruction is called from
action block. To resolve the error, rss object is configured
before action and apply block.
Fixes: 8ba342ce6f0 (pipeline: add RSS)
Signed-off-by: Yogesh Jangra <yogesh.jangra@intel.com>
Signed-off-by: R, Kamalakannan <kamalakannan.r@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
lib/pipeline/rte_swx_pipeline_spec.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/lib/pipeline/rte_swx_pipeline_spec.c b/lib/pipeline/rte_swx_pipeline_spec.c
index a164275526..006b24082a 100644
--- a/lib/pipeline/rte_swx_pipeline_spec.c
+++ b/lib/pipeline/rte_swx_pipeline_spec.c
@@ -3557,6 +3557,18 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
+ /* rss. */
+ for (i = 0; i < s->n_rss; i++) {
+ struct rss_spec *rss_spec = &s->rss[i];
+
+ status = rte_swx_pipeline_rss_config(p, rss_spec->name);
+ if (status) {
+ if (err_msg)
+ *err_msg = "rss object configuration error.";
+ return status;
+ }
+ }
+
/* metarray. */
for (i = 0; i < s->n_metarrays; i++) {
struct metarray_spec *metarray_spec = &s->metarrays[i];
@@ -3678,18 +3690,6 @@ pipeline_spec_configure(struct rte_swx_pipeline *p,
}
}
- /* rss. */
- for (i = 0; i < s->n_rss; i++) {
- struct rss_spec *rss_spec = &s->rss[i];
-
- status = rte_swx_pipeline_rss_config(p, rss_spec->name);
- if (status) {
- if (err_msg)
- *err_msg = "rss object configuration error.";
- return status;
- }
- }
-
/* apply. */
for (i = 0; i < s->n_apply; i++) {
struct apply_spec *apply_spec = &s->apply[i];
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-10 16:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-02 7:08 [PATCH] pipeline: fix rss configuration Yogesh Jangra
2023-03-10 16:59 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2023-03-02 6:30 Yogesh Jangra
2023-03-02 5:29 Yogesh Jangra
2023-03-02 5:22 yjangra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).