From: Ferruh Yigit <ferruh.yigit@intel.com> To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Konstantin Ananyev <konstantin.ananyev@intel.com>, <dev@dpdk.org> Cc: <xiaoyun.li@intel.com>, <anoobj@marvell.com>, <jerinj@marvell.com>, <ndabilpuram@marvell.com>, <adwivedi@marvell.com>, <shepard.siegel@atomicrules.com>, <ed.czeck@atomicrules.com>, <john.miller@atomicrules.com>, <irusskikh@marvell.com>, <ajit.khaparde@broadcom.com>, <somnath.kotur@broadcom.com>, <rahul.lakkireddy@chelsio.com>, <hemant.agrawal@nxp.com>, <sachin.saxena@oss.nxp.com>, <haiyue.wang@intel.com>, <johndale@cisco.com>, <hyonkim@cisco.com>, <qi.z.zhang@intel.com>, <xiao.w.wang@intel.com>, <humin29@huawei.com>, <yisen.zhuang@huawei.com>, <oulijun@huawei.com>, <beilei.xing@intel.com>, <jingjing.wu@intel.com>, <qiming.yang@intel.com>, <matan@nvidia.com>, <viacheslavo@nvidia.com>, <sthemmin@microsoft.com>, <longli@microsoft.com>, <heinrich.kuhn@corigine.com>, <kirankumark@marvell.com>, <mczekaj@marvell.com>, <jiawenwu@trustnetic.com>, <jianwang@trustnetic.com>, <maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>, <thomas@monjalon.net>, <mdr@ashroe.eu>, <jay.jayatheerthan@intel.com> Subject: Re: [dpdk-dev] [PATCH v6 5/6] ethdev: add API to retrieve multiple ethernet addresses Date: Wed, 13 Oct 2021 19:58:34 +0100 Message-ID: <1c5b3d36-ae6f-a452-fa37-626ac8c59b5c@intel.com> (raw) In-Reply-To: <7e0a4705-dc4c-0b69-ad08-320ff2635386@oktetlabs.ru> On 10/13/2021 3:31 PM, Andrew Rybchenko wrote: > On 10/13/21 4:37 PM, Konstantin Ananyev wrote: >> Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet > > ethernet -> Ethernet > >> addresses assigned to given port. >> Change testpmd to use this new function and avoid referencing directly >> rte_eth_devices[]. >> >> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > > Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > > except one nit below > > [snip] > >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >> index f4c92b3b5e..dbc14f4a23 100644 >> --- a/lib/ethdev/rte_ethdev.h >> +++ b/lib/ethdev/rte_ethdev.h >> @@ -3007,6 +3007,27 @@ int rte_eth_dev_set_rx_queue_stats_mapping(uint16_t port_id, >> */ >> int rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr); >> >> +/** > > Experimental header is missing > I can add while merging to next-net. >> + * Retrieve the Ethernet addresses of an Ethernet device. >> + * >> + * @param port_id >> + * The port identifier of the Ethernet device. >> + * @param ma >> + * A pointer to an array of structures of type *ether_addr* to be filled with >> + * the Ethernet addresses of the Ethernet device. >> + * @param num >> + * Number of elements in the @p ma array. >> + * Note that rte_eth_dev_info::max_mac_addrs can be used to retrieve >> + * max number of Ethernet addresses for given port. >> + * @return >> + * - number of retrieved addresses if successful >> + * - (-ENODEV) if *port_id* invalid. >> + * - (-EINVAL) if bad parameter. >> + */ >> +__rte_experimental >> +int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma, >> + unsigned int num); >> + >> /** >> * Retrieve the contextual information of an Ethernet device. >> * > > [snip] >
next prev parent reply other threads:[~2021-10-13 18:58 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <0211007112750.25526-1-konstantin.ananyev@intel.com> 2021-10-13 13:36 ` [dpdk-dev] [PATCH v6 0/6] hide eth dev related structures Konstantin Ananyev 2021-10-13 13:36 ` [dpdk-dev] [PATCH v6 1/6] ethdev: allocate max space for internal queue array Konstantin Ananyev 2021-10-13 14:20 ` Andrew Rybchenko 2021-10-13 13:37 ` [dpdk-dev] [PATCH v6 2/6] ethdev: change input parameters for rx_queue_count Konstantin Ananyev 2021-10-13 13:37 ` [dpdk-dev] [PATCH v6 3/6] ethdev: copy fast-path API into separate structure Konstantin Ananyev 2021-10-13 14:25 ` Andrew Rybchenko 2021-10-13 13:37 ` [dpdk-dev] [PATCH v6 4/6] ethdev: make fast-path functions to use new flat array Konstantin Ananyev 2021-10-13 13:37 ` [dpdk-dev] [PATCH v6 5/6] ethdev: add API to retrieve multiple ethernet addresses Konstantin Ananyev 2021-10-13 14:31 ` Andrew Rybchenko 2021-10-13 18:58 ` Ferruh Yigit [this message] 2021-10-13 13:37 ` [dpdk-dev] [PATCH v6 6/6] ethdev: hide eth dev related structures Konstantin Ananyev 2021-10-13 14:32 ` Andrew Rybchenko 2021-10-13 20:16 ` [dpdk-dev] [PATCH v6 0/6] " Ferruh Yigit 2021-10-14 10:12 ` [dpdk-dev] 回复: " Feifei Wang 2021-10-18 16:04 ` [dpdk-dev] " Ali Alnubani 2021-10-18 16:47 ` Ferruh Yigit 2021-10-18 23:47 ` Ajit Khaparde
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1c5b3d36-ae6f-a452-fa37-626ac8c59b5c@intel.com \ --to=ferruh.yigit@intel.com \ --cc=adwivedi@marvell.com \ --cc=ajit.khaparde@broadcom.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=anoobj@marvell.com \ --cc=beilei.xing@intel.com \ --cc=chenbo.xia@intel.com \ --cc=dev@dpdk.org \ --cc=ed.czeck@atomicrules.com \ --cc=haiyue.wang@intel.com \ --cc=heinrich.kuhn@corigine.com \ --cc=hemant.agrawal@nxp.com \ --cc=humin29@huawei.com \ --cc=hyonkim@cisco.com \ --cc=irusskikh@marvell.com \ --cc=jay.jayatheerthan@intel.com \ --cc=jerinj@marvell.com \ --cc=jianwang@trustnetic.com \ --cc=jiawenwu@trustnetic.com \ --cc=jingjing.wu@intel.com \ --cc=john.miller@atomicrules.com \ --cc=johndale@cisco.com \ --cc=kirankumark@marvell.com \ --cc=konstantin.ananyev@intel.com \ --cc=longli@microsoft.com \ --cc=matan@nvidia.com \ --cc=maxime.coquelin@redhat.com \ --cc=mczekaj@marvell.com \ --cc=mdr@ashroe.eu \ --cc=ndabilpuram@marvell.com \ --cc=oulijun@huawei.com \ --cc=qi.z.zhang@intel.com \ --cc=qiming.yang@intel.com \ --cc=rahul.lakkireddy@chelsio.com \ --cc=sachin.saxena@oss.nxp.com \ --cc=shepard.siegel@atomicrules.com \ --cc=somnath.kotur@broadcom.com \ --cc=sthemmin@microsoft.com \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ --cc=xiao.w.wang@intel.com \ --cc=xiaoyun.li@intel.com \ --cc=yisen.zhuang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git