DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Ali Alnubani <alialnu@nvidia.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	 "dev@dpdk.org" <dev@dpdk.org>,
	"jerinj@marvell.com" <jerinj@marvell.com>,
	Raslan Darawsheh <rasland@nvidia.com>,
	 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Qi Zhang <qi.z.zhang@intel.com>,
	 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	 "xiaoyun.li@intel.com" <xiaoyun.li@intel.com>,
	"anoobj@marvell.com" <anoobj@marvell.com>,
	 "ndabilpuram@marvell.com" <ndabilpuram@marvell.com>,
	"adwivedi@marvell.com" <adwivedi@marvell.com>,
	 "shepard.siegel@atomicrules.com"
	<shepard.siegel@atomicrules.com>,
	 "ed.czeck@atomicrules.com" <ed.czeck@atomicrules.com>,
	 "john.miller@atomicrules.com" <john.miller@atomicrules.com>,
	 "irusskikh@marvell.com" <irusskikh@marvell.com>,
	 "somnath.kotur@broadcom.com" <somnath.kotur@broadcom.com>,
	 "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>,
	 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	 "sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>,
	"haiyue.wang@intel.com" <haiyue.wang@intel.com>,
	 "johndale@cisco.com" <johndale@cisco.com>,
	"hyonkim@cisco.com" <hyonkim@cisco.com>,
	 "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>,
	"humin29@huawei.com" <humin29@huawei.com>,
	 "yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
	"oulijun@huawei.com" <oulijun@huawei.com>,
	 "beilei.xing@intel.com" <beilei.xing@intel.com>,
	"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
	 "qiming.yang@intel.com" <qiming.yang@intel.com>,
	Matan Azrad <matan@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	"sthemmin@microsoft.com" <sthemmin@microsoft.com>,
	 NBU-Contact-longli <longli@microsoft.com>,
	 "heinrich.kuhn@corigine.com" <heinrich.kuhn@corigine.com>,
	 "kirankumark@marvell.com" <kirankumark@marvell.com>,
	"mczekaj@marvell.com" <mczekaj@marvell.com>,
	 "jiawenwu@trustnetic.com" <jiawenwu@trustnetic.com>,
	 "jianwang@trustnetic.com" <jianwang@trustnetic.com>,
	 "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"chenbo.xia@intel.com" <chenbo.xia@intel.com>,
	 NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	"mdr@ashroe.eu" <mdr@ashroe.eu>,
	 "jay.jayatheerthan@intel.com" <jay.jayatheerthan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6 0/6] hide eth dev related structures
Date: Mon, 18 Oct 2021 16:47:41 -0700
Message-ID: <CACZ4nhu4JwqHs90ZN5jMcFVPsoh6TR7y7kNXZhuXyNzvZ5qLHw@mail.gmail.com> (raw)
In-Reply-To: <e9e4ba5d-e340-43f8-856d-0069a99367c9@intel.com>

On Mon, Oct 18, 2021 at 9:47 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 10/18/2021 5:04 PM, Ali Alnubani wrote:
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
> >> Sent: Wednesday, October 13, 2021 11:16 PM
> >> To: Konstantin Ananyev <konstantin.ananyev@intel.com>; dev@dpdk.org;
> >> jerinj@marvell.com; Ajit Khaparde <ajit.khaparde@broadcom.com>; Raslan
> >> Darawsheh <rasland@nvidia.com>; Andrew Rybchenko
> >> <andrew.rybchenko@oktetlabs.ru>; Qi Zhang <qi.z.zhang@intel.com>;
> >> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> >> Cc: xiaoyun.li@intel.com; anoobj@marvell.com; jerinj@marvell.com;
> >> ndabilpuram@marvell.com; adwivedi@marvell.com;
> >> shepard.siegel@atomicrules.com; ed.czeck@atomicrules.com;
> >> john.miller@atomicrules.com; irusskikh@marvell.com;
> >> ajit.khaparde@broadcom.com; somnath.kotur@broadcom.com;
> >> rahul.lakkireddy@chelsio.com; hemant.agrawal@nxp.com;
> >> sachin.saxena@oss.nxp.com; haiyue.wang@intel.com; johndale@cisco.com;
> >> hyonkim@cisco.com; qi.z.zhang@intel.com; xiao.w.wang@intel.com;
> >> humin29@huawei.com; yisen.zhuang@huawei.com; oulijun@huawei.com;
> >> beilei.xing@intel.com; jingjing.wu@intel.com; qiming.yang@intel.com;
> >> Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> >> <viacheslavo@nvidia.com>; sthemmin@microsoft.com; NBU-Contact-longli
> >> <longli@microsoft.com>; heinrich.kuhn@corigine.com;
> >> kirankumark@marvell.com; andrew.rybchenko@oktetlabs.ru;
> >> mczekaj@marvell.com; jiawenwu@trustnetic.com;
> >> jianwang@trustnetic.com; maxime.coquelin@redhat.com;
> >> chenbo.xia@intel.com; NBU-Contact-Thomas Monjalon
> >> <thomas@monjalon.net>; mdr@ashroe.eu; jay.jayatheerthan@intel.com
> >> Subject: Re: [dpdk-dev] [PATCH v6 0/6] hide eth dev related structures
> >>
> >> On 10/13/2021 2:36 PM, Konstantin Ananyev wrote:
> >>> v6 changes:
> >>> - Update comments (Andrew)
> >>> - Move callback related variables under corresponding ifdefs (Andrew)
> >>> - Few nits in rte_eth_macaddrs_get (Andrew)
> >>> - Rebased on top of next-net tree
> >>>
> >>> v5 changes:
> >>> - Fix spelling (Thomas/David)
> >>> - Rename internal helper functions (David)
> >>> - Reorder patches and update commit messages (Thomas)
> >>> - Update comments (Thomas)
> >>> - Changed layout in rte_eth_fp_ops, to group functions and
> >>>      related data based on their functionality:
> >>>      first 64B line for Rx, second one for Tx.
> >>>      Didn't observe any real performance difference comparing to
> >>>      original layout. Though decided to keep a new one, as it seems
> >>>      a bit more plausible.
> >>>
> >>> v4 changes:
> >>>    - Fix secondary process attach (Pavan)
> >>>    - Fix build failure (Ferruh)
> >>>    - Update lib/ethdev/verion.map (Ferruh)
> >>>      Note that moving newly added symbols from EXPERIMENTAL to DPDK_22
> >>>      section makes checkpatch.sh to complain.
> >>>
> >>> v3 changes:
> >>>    - Changes in public struct naming (Jerin/Haiyue)
> >>>    - Split patches
> >>>    - Update docs
> >>>    - Shamelessly included Andrew's patch:
> >>>      https://patches.dpdk.org/project/dpdk/patch/20210928154856.1015020-
> >> 1-andrew.rybchenko@oktetlabs.ru/
> >>>      into these series.
> >>>      I have to do similar thing here, so decided to avoid duplicated effort.
> >>>
> >>> The aim of these patch series is to make rte_ethdev core data structures
> >>> (rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback, etc.) internal to
> >>> DPDK and not visible to the user.
> >>> That should allow future possible changes to core ethdev related structures
> >>> to be transparent to the user and help to improve ABI/API stability.
> >>> Note that current ethdev API is preserved, but it is a formal ABI break.
> >>>
> >>> The work is based on previous discussions at:
> >>> https://www.mail-archive.com/dev@dpdk.org/msg211405.html
> >>> https://www.mail-archive.com/dev@dpdk.org/msg216685.html
> >>> and consists of the following main points:
> >>> 1. Copy public 'fast' function pointers (rx_pkt_burst(), etc.) and
> >>>      related data pointer from rte_eth_dev into a separate flat array.
> >>>      We keep it public to still be able to use inline functions for these
> >>>      'fast' calls (like rte_eth_rx_burst(), etc.) to avoid/minimize slowdown.
> >>>      Note that apart from function pointers itself, each element of this
> >>>      flat array also contains two opaque pointers for each ethdev:
> >>>      1) a pointer to an array of internal queue data pointers
> >>>      2)  points to array of queue callback data pointers.
> >>>      Note that exposing this extra information allows us to avoid extra
> >>>      changes inside PMD level, plus should help to avoid possible
> >>>      performance degradation.
> >>> 2. Change implementation of 'fast' inline ethdev functions
> >>>      (rte_eth_rx_burst(), etc.) to use new public flat array.
> >>>      While it is an ABI breakage, this change is intended to be transparent
> >>>      for both users (no changes in user app is required) and PMD developers
> >>>      (no changes in PMD is required).
> >>>      One extra note - with new implementation RX/TX callback invocation
> >>>      will cost one extra function call with this changes. That might cause
> >>>      some slowdown for code-path with RX/TX callbacks heavily involved.
> >>>      Hope such trade-off is acceptable for the community.
> >>> 3. Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and
> >> related
> >>>      things into internal header: <ethdev_driver.h>.
> >>>
> >>> That approach was selected to:
> >>>     - Avoid(/minimize) possible performance losses.
> >>>     - Minimize required changes inside PMDs.
> >>>
> >>> Performance testing results (ICX 2.0GHz, E810 (ice)):
> >>>    - testpmd macswap fwd mode, plus
> >>>      a) no RX/TX callbacks:
> >>>         no actual slowdown observed
> >>>      b) bpf-load rx 0 0 JM ./dpdk.org/examples/bpf/t3.o:
> >>>         ~2% slowdown
> >>>    - l3fwd: no actual slowdown observed
> >>>
> >>> Would like to thank everyone who already reviewed and tested previous
> >>> versions of these series. All other interested parties please don't be shy
> >>> and provide your feedback.
> >>>
> >>> Konstantin Ananyev (6):
> >>>     ethdev: allocate max space for internal queue array
> >>>     ethdev: change input parameters for rx_queue_count
> >>>     ethdev: copy fast-path API into separate structure
> >>>     ethdev: make fast-path functions to use new flat array
> >>>     ethdev: add API to retrieve multiple ethernet addresses
> >>>     ethdev: hide eth dev related structures
> >>>
> >>
> >> For series,
> >> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>
> >> No performance regression detected on my testing.
> >>
> >> I am merging the series to next-net now which helps testing,
> >> but before merging to main repo it will be good to get more
> >> ack and test results (I can squash new tags later).
> >>
> >> @Jerin, @Ajit, @Raslan, @Andrew, @Qi, @Honnappa,
> >> Can you please test this set for any possible regression?
> >>
> >> Series applied to dpdk-next-net/main, thanks.
> >>
> >
> > Tested (on dpdk-next-net/main) single and multi-core packet forwarding performance with testpmd on both ConnectX-5 and ConnectX-6 Dx. I didn't see any noticeable regressions.
> >
>
> Thanks!
>
> At this stage I am putting set to pull request for main repo.
> Last day for anyone who wants to test the set.
I tested dpdk-next-net/main. My testing was limited and did not reveal
any issues.

      reply	other threads:[~2021-10-18 23:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0211007112750.25526-1-konstantin.ananyev@intel.com>
2021-10-13 13:36 ` Konstantin Ananyev
2021-10-13 13:36   ` [dpdk-dev] [PATCH v6 1/6] ethdev: allocate max space for internal queue array Konstantin Ananyev
2021-10-13 14:20     ` Andrew Rybchenko
2021-10-13 13:37   ` [dpdk-dev] [PATCH v6 2/6] ethdev: change input parameters for rx_queue_count Konstantin Ananyev
2021-10-13 13:37   ` [dpdk-dev] [PATCH v6 3/6] ethdev: copy fast-path API into separate structure Konstantin Ananyev
2021-10-13 14:25     ` Andrew Rybchenko
2021-10-13 13:37   ` [dpdk-dev] [PATCH v6 4/6] ethdev: make fast-path functions to use new flat array Konstantin Ananyev
2021-10-13 13:37   ` [dpdk-dev] [PATCH v6 5/6] ethdev: add API to retrieve multiple ethernet addresses Konstantin Ananyev
2021-10-13 14:31     ` Andrew Rybchenko
2021-10-13 18:58       ` Ferruh Yigit
2021-10-13 13:37   ` [dpdk-dev] [PATCH v6 6/6] ethdev: hide eth dev related structures Konstantin Ananyev
2021-10-13 14:32     ` Andrew Rybchenko
2021-10-13 20:16   ` [dpdk-dev] [PATCH v6 0/6] " Ferruh Yigit
2021-10-14 10:12     ` [dpdk-dev] 回复: " Feifei Wang
2021-10-18 16:04     ` [dpdk-dev] " Ali Alnubani
2021-10-18 16:47       ` Ferruh Yigit
2021-10-18 23:47         ` Ajit Khaparde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACZ4nhu4JwqHs90ZN5jMcFVPsoh6TR7y7kNXZhuXyNzvZ5qLHw@mail.gmail.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=adwivedi@marvell.com \
    --cc=alialnu@nvidia.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=anoobj@marvell.com \
    --cc=beilei.xing@intel.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ed.czeck@atomicrules.com \
    --cc=ferruh.yigit@intel.com \
    --cc=haiyue.wang@intel.com \
    --cc=heinrich.kuhn@corigine.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=humin29@huawei.com \
    --cc=hyonkim@cisco.com \
    --cc=irusskikh@marvell.com \
    --cc=jay.jayatheerthan@intel.com \
    --cc=jerinj@marvell.com \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=johndale@cisco.com \
    --cc=kirankumark@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=longli@microsoft.com \
    --cc=matan@nvidia.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mczekaj@marvell.com \
    --cc=mdr@ashroe.eu \
    --cc=ndabilpuram@marvell.com \
    --cc=oulijun@huawei.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=rasland@nvidia.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=sthemmin@microsoft.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=xiao.w.wang@intel.com \
    --cc=xiaoyun.li@intel.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git